From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D88AC83000 for ; Wed, 29 Apr 2020 20:08:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18B5B2076B for ; Wed, 29 Apr 2020 20:08:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="tTr5oIxG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726887AbgD2UIS (ORCPT ); Wed, 29 Apr 2020 16:08:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726456AbgD2UIS (ORCPT ); Wed, 29 Apr 2020 16:08:18 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 503A6C03C1AE for ; Wed, 29 Apr 2020 13:08:17 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id t9so1228687pjw.0 for ; Wed, 29 Apr 2020 13:08:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CaOvHrpjpl1Q9+/sxJyu4rwMqwZKM0XDTDnQcZ/KDRM=; b=tTr5oIxGnTUBOMB60P7sw8ehBgN/PidC62jKa8hfQcs/0Jg1mNn1JjCn05VSJoUu8k lhiXpG19QLgJ1JXooTWv3jgpj4l+vQ7RN54J543/RBg/nKHzzOSKnWk4Acwd8VsgCHm6 /HHwFBYMMFomIX76FXT9PRU4Hy5t69TZtvOucnSrK/C05x8AQ9QZcp1BanknewUOJ0Rd 9tCeIxk08Eoms+3POH+wXroXVU2G0GI6mthaIULyxuvPYi1v4C3B0Stix0jdU8GpfkUQ saTlazsrXWfg+JugMTSB/EF1uMOlqJXwY0C7FdtU+acTr5PjVrlH78x3+Jj5RnyE6Cvh o6Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CaOvHrpjpl1Q9+/sxJyu4rwMqwZKM0XDTDnQcZ/KDRM=; b=EQcWIAOiEgVIFxRJJIiBiosoTXWfP/8IsAcqA6KfJDBx7A7vuSsz8gt+XXulUfNU+o PLZgsgkk8RXi9yeJaoofh6xYsWvFRnklnCBx5RhhYaxFtKyFwxjuyo6ZjyLB/bR1ehtV Lf9IX6IB0DmljETVNZe3pjM64jaZcExa3v9aRe0t9dvUFo5yq0Fk5uzX4WVcAVMcKXEu lQImc/kXCwqoQkmJ1Zo+7pnoqs3POY7pth4xJwwR7hfvDVFvOGxMHJt3s7YKfZU1q2Yg MQuVgS35Wi2yTBInanl+Zh4d+b8eFa72AWZ1Id/pBdLN/5Z0ml6tMWl9gJ1nwVKX/k2f /Nog== X-Gm-Message-State: AGi0Pua7xrUmYrGmYp/8ef15hg4h9OLBA3xc6UHfgrs3lWJst8rdbHiD G104XPmov5JGtNIUcgY3I0A6ye2kxpbOyQ== X-Google-Smtp-Source: APiQypLWechwzx07hYUNjCpyR29fgLtLf2z32NLvDynPpJMpOdrsgkSyo676BKnFfRyJxkTLpUcuxg== X-Received: by 2002:a17:90a:de8d:: with SMTP id n13mr126682pjv.173.1588190896334; Wed, 29 Apr 2020 13:08:16 -0700 (PDT) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id d20sm109376pjs.12.2020.04.29.13.08.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Apr 2020 13:08:15 -0700 (PDT) Subject: Re: Build 0.6 version fail on musl libc To: =?UTF-8?Q?Milan_P=2e_Stani=c4=87?= Cc: Christoph Hellwig , io-uring@vger.kernel.org References: <20200428192956.GA32615@arya.arvanta.net> <04edfda7-0443-62e1-81af-30aa820cf256@kernel.dk> <20200429152646.GA17156@infradead.org> <6528f839-274d-9d46-dea6-b20a90ac8cf8@kernel.dk> <20200429193315.GA31807@arya.arvanta.net> <4f9df512-75a6-e4ca-4f06-21857ac44afb@kernel.dk> <20200429200158.GA3515@arya.arvanta.net> From: Jens Axboe Message-ID: <962a1063-7986-fba9-f64e-05f6770763bc@kernel.dk> Date: Wed, 29 Apr 2020 14:08:14 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200429200158.GA3515@arya.arvanta.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 4/29/20 2:01 PM, Milan P. Stanić wrote: > On Wed, 2020-04-29 at 13:38, Jens Axboe wrote: >> On 4/29/20 1:33 PM, Milan P. Stanić wrote: >>> On Wed, 2020-04-29 at 10:14, Jens Axboe wrote: >>>> On 4/29/20 9:29 AM, Jens Axboe wrote: >>>>> On 4/29/20 9:26 AM, Christoph Hellwig wrote: >>>>>> On Wed, Apr 29, 2020 at 09:24:40AM -0600, Jens Axboe wrote: >>>>>>> >>>>>>> Not sure what the best fix is there, for 32-bit, your change will truncate >>>>>>> the offset to 32-bit as off_t is only 4 bytes there. At least that's the >>>>>>> case for me, maybe musl is different if it just has a nasty define for >>>>>>> them. >>>>>>> >>>>>>> Maybe best to just make them uint64_t or something like that. >>>>>> >>>>>> The proper LFS type would be off64_t. >>>>> >>>>> Is it available anywhere? Because I don't have it. >>>> >>>> There seems to be better luck with __off64_t, but I don't even know >>>> how widespread that is... Going to give it a go, we'll see. >>> >>> AFAIK, __off64_t is glibc specific, defined in /usr/include/fcntl.h: >>> ------ >>> # ifndef __USE_FILE_OFFSET64 >>> typedef __off_t off_t; >>> # else >>> typedef __off64_t off_t; >>> # endif >>> ------ >>> >>> So, this will not work on musl based Linux system, git commit id >>> b5096098c62adb19dbf4a39b480909766c9026e7 should be reverted. But you >>> know better what to do. >>> >>> I come with another quick and dirty patch attached to this mail but >>> again I think it is not proper solution, just playing to find (maybe) >>> 'good enough' workaround. >> >> Let's just use uint64_t. > > This works. Thanks. > > Next issue is this: > ---- > make[1]: Entering directory '/work/devel/liburing/src' > CC setup.ol > CC queue.ol > CC syscall.ol > In file included from syscall.c:9: > include/liburing/compat.h:6:2: error: unknown type name 'int64_t' > 6 | int64_t tv_sec; > | ^~~~~~~ > make[1]: *** [Makefile:43: syscall.ol] Error 1 > make[1]: Leaving directory '/work/devel/liburing/src' > make: *** [Makefile:12: all] Error 2 > ---- > > I fixed it with this patch: > -- > diff --git a/configure b/configure > index 30b0a5a..4b44177 100755 > --- a/configure > +++ b/configure > @@ -301,6 +301,7 @@ EOF > fi > if test "$__kernel_timespec" != "yes"; then > cat >> $compat_h << EOF > +#include > struct __kernel_timespec { > int64_t tv_sec; > long long tv_nsec; > -- > > but not sure will that work on glibc. That should work fine on glibc. Care to send as an actual patch, with commit message and signed-off-by? Then I'll add it to liburing. -- Jens Axboe