* [PATCH 1/1] io_uring/rw: fix error'ed retry return values
@ 2022-09-13 12:21 Pavel Begunkov
2022-09-13 13:47 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Begunkov @ 2022-09-13 12:21 UTC (permalink / raw)
To: io-uring; +Cc: Jens Axboe, asml.silence, kernel test robot
Kernel test robot reports that we test negativity of an unsigned in
io_fixup_rw_res() after a recent change, which masks error codes and
messes up the return value in case I/O is re-retried and failed with
an error.
Fixes: 4d9cb92ca41dd ("io_uring/rw: fix short rw error handling")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Pavel Begunkov <[email protected]>
---
io_uring/rw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/io_uring/rw.c b/io_uring/rw.c
index 1e18a44adcf5..76ebcfebc9a6 100644
--- a/io_uring/rw.c
+++ b/io_uring/rw.c
@@ -206,7 +206,7 @@ static bool __io_complete_rw_common(struct io_kiocb *req, long res)
return false;
}
-static inline unsigned io_fixup_rw_res(struct io_kiocb *req, unsigned res)
+static inline int io_fixup_rw_res(struct io_kiocb *req, long res)
{
struct io_async_rw *io = req->async_data;
--
2.37.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] io_uring/rw: fix error'ed retry return values
2022-09-13 12:21 [PATCH 1/1] io_uring/rw: fix error'ed retry return values Pavel Begunkov
@ 2022-09-13 13:47 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2022-09-13 13:47 UTC (permalink / raw)
To: Pavel Begunkov, io-uring; +Cc: kernel test robot
On Tue, 13 Sep 2022 13:21:23 +0100, Pavel Begunkov wrote:
> Kernel test robot reports that we test negativity of an unsigned in
> io_fixup_rw_res() after a recent change, which masks error codes and
> messes up the return value in case I/O is re-retried and failed with
> an error.
>
>
Applied, thanks!
[1/1] io_uring/rw: fix error'ed retry return values
commit: 62bb0647b14646fa6c9aa25ecdf67ad18f13523c
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-13 13:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-13 12:21 [PATCH 1/1] io_uring/rw: fix error'ed retry return values Pavel Begunkov
2022-09-13 13:47 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox