From: Jens Axboe <[email protected]>
To: "Matthew Wilcox (Oracle)" <[email protected]>
Cc: [email protected], [email protected],
[email protected], [email protected],
[email protected], Kanchan Joshi <[email protected]>,
Javier Gonzalez <[email protected]>
Subject: Re: [PATCH 1/2] fs: Abstract calling the kiocb completion function
Date: Wed, 8 Jul 2020 16:37:21 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 7/8/20 4:26 PM, Matthew Wilcox (Oracle) wrote:
> diff --git a/crypto/af_alg.c b/crypto/af_alg.c
> index b1cd3535c525..590dbbcd0e9f 100644
> --- a/crypto/af_alg.c
> +++ b/crypto/af_alg.c
> @@ -1045,7 +1045,7 @@ void af_alg_async_cb(struct crypto_async_request *_req, int err)
> af_alg_free_resources(areq);
> sock_put(sk);
>
> - iocb->ki_complete(iocb, err ? err : (int)resultlen, 0);
> + complete_kiocb(iocb, err ? err : (int)resultlen, 0);
I'd prefer having it called kiocb_complete(), seems more in line with
what you'd expect in terms of naming for an exported interface.
--
Jens Axboe
next prev parent reply other threads:[~2020-07-08 22:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 22:26 [PATCH 0/2] Remove kiocb ki_complete Matthew Wilcox (Oracle)
2020-07-08 22:26 ` [PATCH 1/2] fs: Abstract calling the kiocb completion function Matthew Wilcox (Oracle)
2020-07-08 22:37 ` Jens Axboe [this message]
2020-07-08 22:40 ` Matthew Wilcox
2020-07-08 22:50 ` Jens Axboe
2020-07-08 22:26 ` [PATCH 2/2] fs: Remove kiocb->ki_complete Matthew Wilcox (Oracle)
2020-07-08 22:38 ` Jens Axboe
2020-07-09 3:25 ` Jens Axboe
2020-07-09 5:23 ` kernel test robot
2020-07-08 22:33 ` [PATCH 0/2] Remove kiocb ki_complete Jens Axboe
2020-07-09 10:17 ` Christoph Hellwig
2020-07-09 11:10 ` Matthew Wilcox
2020-07-09 13:26 ` Christoph Hellwig
2020-07-09 13:32 ` Matthew Wilcox
2020-07-09 13:53 ` Jens Axboe
2020-07-09 13:37 ` Pavel Begunkov
2020-07-09 13:43 ` Matthew Wilcox
2020-07-09 13:49 ` Pavel Begunkov
2020-07-09 13:53 ` Matthew Wilcox
2020-07-09 13:59 ` Pavel Begunkov
2020-07-09 13:55 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox