From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9916C388F9 for ; Sun, 8 Nov 2020 11:27:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 71969206F4 for ; Sun, 8 Nov 2020 11:27:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SzRs7AIq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726210AbgKHL1k (ORCPT ); Sun, 8 Nov 2020 06:27:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725911AbgKHL1j (ORCPT ); Sun, 8 Nov 2020 06:27:39 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8258C0613CF for ; Sun, 8 Nov 2020 03:27:36 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id p22so5490863wmg.3 for ; Sun, 08 Nov 2020 03:27:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=F98xXv6vSLfe6D8YpSHe9e79Gz7xnPj35L3vglZjOJU=; b=SzRs7AIqucQpId/kbQIIhcmeRkC5XiWuauM1sP9qNwliBvqh1RErD7eRf1ymS1Z+lC zTznyFduo5zmWtgKxVBW0sQs17x8H1AKQppaQe9QJ8s/oViFI6dQWXClpc+vsdkuh7XQ iwp1humlnCvpdwLwquxJCmKnROOt/DMKMb9MObWHiNszwRx8J1h/2DyYDvl+l4Ij8gLa THCIRyv3yb/oz93rER8LYY0QQBQ5m/hkGHhVDocz1R2JHgZvSPAtiuw3ekb+YxxCVGvG S9AYIZHbqcJ5imkPNS8SLVRWzflrlScQ8uE86+N7A2FnsxuQq0t7UOZR2THhcsNLeQHL I3RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=F98xXv6vSLfe6D8YpSHe9e79Gz7xnPj35L3vglZjOJU=; b=NJGrMAfpbyc2OewFB+z/0pt1TB/GHRI2t9sKZll/uV3lbLdig6g5KKd3/LFzZGkNdL FDGGQK8rG9cIEpfl+rfp7bAtEnpgb5Ojgs+VabYVTlrirzmXWaM6FYsHvdVbXbYdsoJo fY7zDhUd3n0uitIweESEnfh1Gwc1m4KxfK/rcV9L3eBd5OxWsqEa/QxJd0IfepUxBhwg 9abfU33aqLzb4L8RoY526UYBHPUUPcy1ujMiEloMIDYC5LB+mst9moxo648ofvkArvMA 1JjzuqYpDqOng3A6FX1QxiSTD3uFlcePPVgn6ZCD/drn8vzzS5OxvuLKtAD6VbjEHXSn F8Mg== X-Gm-Message-State: AOAM5334t2LGrcZiCQ/xC1BBAgEjamAuwmEj5hXQlbBryChvtRx/Pa1j ox07VdR/voJcNuTQ5NYpbf0= X-Google-Smtp-Source: ABdhPJzRFgYlGtLOFPGXWnRlIVxK3otBzwk99uYtEhSg3lyME7SE1BDsVPY9F3IQvo1J9zsBOsm44A== X-Received: by 2002:a7b:c015:: with SMTP id c21mr9033952wmb.22.1604834855519; Sun, 08 Nov 2020 03:27:35 -0800 (PST) Received: from [192.168.1.96] (host109-152-100-228.range109-152.btcentralplus.com. [109.152.100.228]) by smtp.gmail.com with ESMTPSA id o184sm9157388wmo.37.2020.11.08.03.27.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Nov 2020 03:27:34 -0800 (PST) Subject: Re: [PATCH 5.11] io_uring: NULL files dereference by SQPOLL To: Jens Axboe , io-uring@vger.kernel.org, Josef Grieb References: <24446f4e23e80803d3ab1a4d27a6d1a605e37b32.1604783766.git.asml.silence@gmail.com> <39db5769-5aef-96f5-305c-2a3250d9ba73@gmail.com> <030c3ccb-8777-9c28-1835-5afbbb1c3eb1@gmail.com> <97fce91e-4ace-f98b-1e7e-d41d9c15cfb8@kernel.dk> <3094f974-1b67-1550-a116-a1f1fca84df2@kernel.dk> From: Pavel Begunkov Autocrypt: addr=asml.silence@gmail.com; prefer-encrypt=mutual; keydata= mQINBFmKBOQBEAC76ZFxLAKpDw0bKQ8CEiYJRGn8MHTUhURL02/7n1t0HkKQx2K1fCXClbps bdwSHrhOWdW61pmfMbDYbTj6ZvGRvhoLWfGkzujB2wjNcbNTXIoOzJEGISHaPf6E2IQx1ik9 6uqVkK1OMb7qRvKH0i7HYP4WJzYbEWVyLiAxUj611mC9tgd73oqZ2pLYzGTqF2j6a/obaqha +hXuWTvpDQXqcOZJXIW43atprH03G1tQs7VwR21Q1eq6Yvy2ESLdc38EqCszBfQRMmKy+cfp W3U9Mb1w0L680pXrONcnlDBCN7/sghGeMHjGKfNANjPc+0hzz3rApPxpoE7HC1uRiwC4et83 CKnncH1l7zgeBT9Oa3qEiBlaa1ZCBqrA4dY+z5fWJYjMpwI1SNp37RtF8fKXbKQg+JuUjAa9 Y6oXeyEvDHMyJYMcinl6xCqCBAXPHnHmawkMMgjr3BBRzODmMr+CPVvnYe7BFYfoajzqzq+h EyXSl3aBf0IDPTqSUrhbmjj5OEOYgRW5p+mdYtY1cXeK8copmd+fd/eTkghok5li58AojCba jRjp7zVOLOjDlpxxiKhuFmpV4yWNh5JJaTbwCRSd04sCcDNlJj+TehTr+o1QiORzc2t+N5iJ NbILft19Izdn8U39T5oWiynqa1qCLgbuFtnYx1HlUq/HvAm+kwARAQABtDFQYXZlbCBCZWd1 bmtvdiAoc2lsZW5jZSkgPGFzbWwuc2lsZW5jZUBnbWFpbC5jb20+iQJOBBMBCAA4FiEE+6Ju PTjTbx479o3OWt5b1Glr+6UFAlmKBOQCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQ Wt5b1Glr+6WxZA//QueaKHzgdnOikJ7NA/Vq8FmhRlwgtP0+E+w93kL+ZGLzS/cUCIjn2f4Q Mcutj2Neg0CcYPX3b2nJiKr5Vn0rjJ/suiaOa1h1KzyNTOmxnsqE5fmxOf6C6x+NKE18I5Jy xzLQoktbdDVA7JfB1itt6iWSNoOTVcvFyvfe5ggy6FSCcP+m1RlR58XxVLH+qlAvxxOeEr/e aQfUzrs7gqdSd9zQGEZo0jtuBiB7k98t9y0oC9Jz0PJdvaj1NZUgtXG9pEtww3LdeXP/TkFl HBSxVflzeoFaj4UAuy8+uve7ya/ECNCc8kk0VYaEjoVrzJcYdKP583iRhOLlZA6HEmn/+Gh9 4orG67HNiJlbFiW3whxGizWsrtFNLsSP1YrEReYk9j1SoUHHzsu+ZtNfKuHIhK0sU07G1OPN 2rDLlzUWR9Jc22INAkhVHOogOcc5ajMGhgWcBJMLCoi219HlX69LIDu3Y34uIg9QPZIC2jwr 24W0kxmK6avJr7+n4o8m6sOJvhlumSp5TSNhRiKvAHB1I2JB8Q1yZCIPzx+w1ALxuoWiCdwV M/azguU42R17IuBzK0S3hPjXpEi2sK/k4pEPnHVUv9Cu09HCNnd6BRfFGjo8M9kZvw360gC1 reeMdqGjwQ68o9x0R7NBRrtUOh48TDLXCANAg97wjPoy37dQE7e5Ag0EWYoE5AEQAMWS+aBV IJtCjwtfCOV98NamFpDEjBMrCAfLm7wZlmXy5I6o7nzzCxEw06P2rhzp1hIqkaab1kHySU7g dkpjmQ7Jjlrf6KdMP87mC/Hx4+zgVCkTQCKkIxNE76Ff3O9uTvkWCspSh9J0qPYyCaVta2D1 Sq5HZ8WFcap71iVO1f2/FEHKJNz/YTSOS/W7dxJdXl2eoj3gYX2UZNfoaVv8OXKaWslZlgqN jSg9wsTv1K73AnQKt4fFhscN9YFxhtgD/SQuOldE5Ws4UlJoaFX/yCoJL3ky2kC0WFngzwRF Yo6u/KON/o28yyP+alYRMBrN0Dm60FuVSIFafSqXoJTIjSZ6olbEoT0u17Rag8BxnxryMrgR dkccq272MaSS0eOC9K2rtvxzddohRFPcy/8bkX+t2iukTDz75KSTKO+chce62Xxdg62dpkZX xK+HeDCZ7gRNZvAbDETr6XI63hPKi891GeZqvqQVYR8e+V2725w+H1iv3THiB1tx4L2bXZDI DtMKQ5D2RvCHNdPNcZeldEoJwKoA60yg6tuUquvsLvfCwtrmVI2rL2djYxRfGNmFMrUDN1Xq F3xozA91q3iZd9OYi9G+M/OA01husBdcIzj1hu0aL+MGg4Gqk6XwjoSxVd4YT41kTU7Kk+/I 5/Nf+i88ULt6HanBYcY/+Daeo/XFABEBAAGJAjYEGAEIACAWIQT7om49ONNvHjv2jc5a3lvU aWv7pQUCWYoE5AIbDAAKCRBa3lvUaWv7pfmcEACKTRQ28b1y5ztKuLdLr79+T+LwZKHjX++P 4wKjEOECCcB6KCv3hP+J2GCXDOPZvdg/ZYZafqP68Yy8AZqkfa4qPYHmIdpODtRzZSL48kM8 LRzV8Rl7J3ItvzdBRxf4T/Zseu5U6ELiQdCUkPGsJcPIJkgPjO2ROG/ZtYa9DvnShNWPlp+R uPwPccEQPWO/NP4fJl2zwC6byjljZhW5kxYswGMLBwb5cDUZAisIukyAa8Xshdan6C2RZcNs rB3L7vsg/R8UCehxOH0C+NypG2GqjVejNZsc7bgV49EOVltS+GmGyY+moIzxsuLmT93rqyII 5rSbbcTLe6KBYcs24XEoo49Zm9oDA3jYvNpeYD8rDcnNbuZh9kTgBwFN41JHOPv0W2FEEWqe JsCwQdcOQ56rtezdCJUYmRAt3BsfjN3Jn3N6rpodi4Dkdli8HylM5iq4ooeb5VkQ7UZxbCWt UVMKkOCdFhutRmYp0mbv2e87IK4erwNHQRkHUkzbsuym8RVpAZbLzLPIYK/J3RTErL6Z99N2 m3J6pjwSJY/zNwuFPs9zGEnRO4g0BUbwGdbuvDzaq6/3OJLKohr5eLXNU3JkT+3HezydWm3W OPhauth7W0db74Qd49HXK0xe/aPrK+Cp+kU1HRactyNtF8jZQbhMCC8vMGukZtWaAwpjWiiH bA== Message-ID: <99a2727c-e888-56fa-1314-5cc2e0ce83e2@gmail.com> Date: Sun, 8 Nov 2020 11:24:31 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <3094f974-1b67-1550-a116-a1f1fca84df2@kernel.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 07/11/2020 23:18, Jens Axboe wrote: > On 11/7/20 3:47 PM, Pavel Begunkov wrote: >> On 07/11/2020 22:28, Jens Axboe wrote: >>> On 11/7/20 2:54 PM, Pavel Begunkov wrote: >>>> On 07/11/2020 21:18, Pavel Begunkov wrote: >>>>> On 07/11/2020 21:16, Pavel Begunkov wrote: >>>>>> SQPOLL task may find sqo_task->files == NULL, so >>>>>> __io_sq_thread_acquire_files() would left it unset and so all the >>>>>> following fails, e.g. attempts to submit. Fail if sqo_task doesn't have >>>>>> files. >>>>> >>>>> Josef, could you try this one? >>>> >>>> Hmm, as you said it happens often... IIUC there is a drawback with >>>> SQPOLL -- after the creator process/thread exits most of subsequent >>>> requests will start failing. >>>> I'd say from application correctness POV such tasks should exit >>>> only after their SQPOLL io_urings got killed. >>> >>> I don't think there's anything wrong with that - if you submit requests >>> and exit before they have completed, then you by definition are not >>> caring about the result of them. >> >> Other threads may use it as well thinking that this is fine as >> they share mm, files, etc. >> >> 1. task1 create io_uring >> 2. clone(CLONE_FILES|CLONE_VM|...) -> task2 >> 3. task1 exits >> 4. task2 continues to use io_uring > > Sure, but I think this is getting pretty contrived. Yes, if the task > that created the ring (and whose credentials are being used) exits, > then the ring is effectively dead if you're using SQPOLL. If you're > using threads, the threads go away too. Sibling threads are not necessarily go away, isn't it? And pre-5.11 that wasn't a problem as it didn't have files and mm was taken directly. -- Pavel Begunkov