From: Pavel Begunkov <[email protected]>
To: Jens Axboe <[email protected]>, [email protected]
Subject: Re: [PATCH 1/1] io_uring: fix mshot read defer taskrun cqe posting
Date: Thu, 7 Mar 2024 13:47:54 +0000 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 3/7/24 13:33, Jens Axboe wrote:
> On 3/6/24 9:02 AM, Pavel Begunkov wrote:
>> We can't post CQEs from io-wq with DEFER_TASKRUN set, normal completions
>> are handled but aux should be explicitly disallowed by opcode handlers.
>
> Looks good - but I can't help but think that it'd be nice to handle this
> from io_wq_submit_work() instead, and take it out of the opcode
> handlers themselves (like this one, and the recv/recvmsg part). That'd
> put it in the slow path instead.
I have a follow up cleanup patch, but I like this idea even more
> Anyway, it's applied, as it's a real fix and any work like the above
> should be done separately of course.
--
Pavel Begunkov
next prev parent reply other threads:[~2024-03-07 13:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 16:02 [PATCH 1/1] io_uring: fix mshot read defer taskrun cqe posting Pavel Begunkov
2024-03-07 13:31 ` Jens Axboe
2024-03-07 13:33 ` Jens Axboe
2024-03-07 13:47 ` Pavel Begunkov [this message]
2024-03-07 13:58 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox