From: Jens Axboe <[email protected]>
To: Daniele Salvatore Albano <[email protected]>
Cc: io-uring <[email protected]>
Subject: Re: [PATCH] io_files_update_prep shouldn't consider all the flags invalid
Date: Sat, 18 Jul 2020 14:23:17 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAKq9yRjwp6_hYbG3j11ekAg_1iJ8h_aLM+Kq7uCmgYvOHESFaA@mail.gmail.com>
On 7/18/20 11:29 AM, Daniele Salvatore Albano wrote:
> On Fri, 17 Jul 2020 at 23:48, Jens Axboe <[email protected]> wrote:
>>
>> On 7/17/20 4:39 PM, Daniele Salvatore Albano wrote:
>>> Sure thing, tomorrow I will put it together, review all the other ops
>>> as well, just in case (although I believe you may already have done
>>> it), and test it.
>>
>> I did take a quick look and these were the three I found. There
>> shouldn't be others, so I think we're good there.
>>
>>> For the test cases, should I submit a separate patch for liburing or
>>> do you prefer to use pull requests on gh?
>>
>> Either one is fine, I can work with either.
>>
>> --
>> Jens Axboe
>>
>
> I changed the patch name considering that is now affecting multiple
> functions, I will also create the PR for the test cases but it may
> take a few days, I wasn't using the other 2 functions and need to do
> some testing.
Thanks, I applied this one with a modified commit message. Also note
that your mailer is mangling patches, the whitespace is all damaged.
I fixed it up. Here's the end result:
https://git.kernel.dk/cgit/linux-block/commit/?h=io_uring-5.8&id=61710e437f2807e26a3402543bdbb7217a9c8620
--
Jens Axboe
next prev parent reply other threads:[~2020-07-18 20:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 17:32 [PATCH] io_files_update_prep shouldn't consider all the flags invalid Daniele Salvatore Albano
2020-07-17 16:13 ` Daniele Salvatore Albano
2020-07-17 16:21 ` Jens Axboe
2020-07-17 22:39 ` Daniele Salvatore Albano
2020-07-17 22:48 ` Jens Axboe
2020-07-18 17:29 ` Daniele Salvatore Albano
2020-07-18 20:23 ` Jens Axboe [this message]
2020-07-18 20:48 ` Daniele Salvatore Albano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox