From: Pavel Begunkov <[email protected]>
To: Fam Zheng <[email protected]>, [email protected]
Cc: Jens Axboe <[email protected]>, [email protected], [email protected]
Subject: Re: [PATCH] io_uring: Fix comment of io_get_sqe
Date: Tue, 15 Jun 2021 14:02:44 +0100 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 6/4/21 5:42 PM, Fam Zheng wrote:
> The sqe_ptr argument has been gone since 709b302faddf (io_uring:
> simplify io_get_sqring, 2020-04-08), made the return value of the
> function. Update the comment accordingly.
Reviewed-by: Pavel Begunkov <[email protected]>
>
> Signed-off-by: Fam Zheng <[email protected]>
> ---
> fs/io_uring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 903458afd56c..bb3685ba335d 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -6670,7 +6670,7 @@ static void io_commit_sqring(struct io_ring_ctx *ctx)
> }
>
> /*
> - * Fetch an sqe, if one is available. Note that sqe_ptr will point to memory
> + * Fetch an sqe, if one is available. Note this returns a pointer to memory
> * that is mapped by userspace. This means that care needs to be taken to
> * ensure that reads are stable, as we cannot rely on userspace always
> * being a good citizen. If members of the sqe are validated and then later
>
--
Pavel Begunkov
next prev parent reply other threads:[~2021-06-15 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 16:42 [PATCH] io_uring: Fix comment of io_get_sqe Fam Zheng
2021-06-15 13:02 ` Pavel Begunkov [this message]
2021-06-15 21:39 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox