public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jens Axboe <[email protected]>
To: Stefan Metzmacher <[email protected]>, [email protected]
Subject: Re: [PATCH v3 0/6] Complete setup before calling wake_up_new_task()
Date: Sun, 25 Apr 2021 10:28:39 -0600	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 4/24/21 5:26 PM, Stefan Metzmacher wrote:
> Hi,
> 
> now that we have an explicit wake_up_new_task() in order to start the
> result from create_io_thread(), we should set things up before calling
> wake_up_new_task().
> 
> Changes in v3:
>  - rebased on for-5.13/io_uring.
>  - I dropped this:
>   fs/proc: hide PF_IO_WORKER in get_task_cmdline()
>  - I added:
>   set_task_comm() overflow checks

Looks good to me, a few comments:

1) I agree with Pavel that the WARN on overflow is kinda silly,
   it doesn't matter that much. So I'd rather drop those for now.

2) Would really love it to see some decent commit messages, quite
   a few of them are empty. In general some reasoning is nice in
   the commit message, when you don't have the context available.

Do you want to do a v4 with 5-6/6 dropped for now, and 3-4 having
some reasoning? I can also just apply as-is and write some commit
message myself, let me know. I'll add 1-2 for now.

-- 
Jens Axboe


  parent reply	other threads:[~2021-04-25 16:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-24 23:26 [PATCH v3 0/6] Complete setup before calling wake_up_new_task() Stefan Metzmacher
2021-04-24 23:26 ` [PATCH v3 1/6] kernel: always initialize task->pf_io_worker to NULL Stefan Metzmacher
2021-04-24 23:26 ` [PATCH v3 2/6] io_uring: io_sq_thread() no longer needs to reset current->pf_io_worker Stefan Metzmacher
2021-04-24 23:26 ` [PATCH v3 3/6] io-wq: call set_task_comm() before wake_up_new_task() Stefan Metzmacher
2021-04-24 23:26 ` [PATCH v3 4/6] io_uring: complete sq_thread setup before calling wake_up_new_task() Stefan Metzmacher
2021-04-24 23:26 ` [PATCH v3 5/6] io-wq: warn about future set_task_comm() overflows Stefan Metzmacher
2021-04-25  0:08   ` Pavel Begunkov
2021-04-24 23:26 ` [PATCH v3 6/6] io_uring: " Stefan Metzmacher
2021-04-25 16:28 ` Jens Axboe [this message]
2021-04-26 16:01   ` [PATCH v3 0/6] Complete setup before calling wake_up_new_task() Stefan Metzmacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox