Re: [PATCH liburing v1] zcrx: Get the page size at runtime

[Haiyue Wang <haiyuewa@163.com>]

On 2025/4/19 23:12, Jens Axboe wrote:
> On 4/19/25 7:38 AM, Haiyue Wang wrote:
>> Use the API `sysconf()` to query page size at runtime, instead of using
>> hard code number 4096.
> 
> This is v2, no? It's customary to include a "changes since the last
> version" when posting a v2. JFYI.
> 

Got it. Will send v3, fix the tab issue.

>> @@ -329,7 +329,13 @@ static void parse_opts(int argc, char **argv)
>>   
>>   int main(int argc, char **argv)
>>   {
>> -	parse_opts(argc, argv);
>> +	page_size = sysconf(_SC_PAGESIZE);
>> +	if (page_size < 0) {
>> +		perror("sysconf(_SC_PAGESIZE)");
>> +		return 1;
>> +	}
>> +
>> +        parse_opts(argc, argv);
> 
> Whitespace damage here, it's using spaces rather than tabs.
> 
> Outside of that, I think this looks fine. liburing helpers should
> probably have something for this going forward, so every test that uses
> the correct page size (or still hardcodes 4096...) would get it right
> without needing to know about this. But that's beyond the scope of this
> change.
>