From: Jens Axboe <[email protected]>
To: Al Viro <[email protected]>
Cc: Pavel Begunkov <[email protected]>,
yangerkun <[email protected]>,
[email protected], [email protected],
[email protected]
Subject: Re: [PATCH] block: reexpand iov_iter after read/write
Date: Fri, 7 May 2021 08:59:21 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <YJRa4gQSWl3/[email protected]>
On 5/6/21 3:08 PM, Al Viro wrote:
> On Thu, May 06, 2021 at 01:15:01PM -0600, Jens Axboe wrote:
>
>> Attached output of perf annotate <func> for that last run.
>
> Heh... I wonder if keeping the value of iocb_flags(file) in
> struct file itself would have a visible effect...
A quick hack to get rid of the init_sync_kiocb() in new_sync_write() and
just eliminate the ki_flags read in eventfd_write(), as the test case is
blocking. That brings us closer to the ->write() method, down 7% vs the
previous 10%:
Executed in 468.23 millis fish external
usr time 95.09 millis 114.00 micros 94.98 millis
sys time 372.98 millis 76.00 micros 372.90 millis
Executed in 468.97 millis fish external
usr time 91.05 millis 89.00 micros 90.96 millis
sys time 377.92 millis 69.00 micros 377.85 millis
--
Jens Axboe
prev parent reply other threads:[~2021-05-07 14:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 7:18 [PATCH] block: reexpand iov_iter after read/write yangerkun
2021-04-06 1:28 ` yangerkun
2021-04-06 11:04 ` Pavel Begunkov
2021-04-07 14:16 ` yangerkun
2021-04-09 14:49 ` Pavel Begunkov
2021-04-15 17:37 ` Pavel Begunkov
2021-04-15 17:39 ` Pavel Begunkov
2021-04-28 6:16 ` yangerkun
2021-04-30 12:57 ` Pavel Begunkov
2021-04-30 14:35 ` Al Viro
2021-05-06 16:57 ` Pavel Begunkov
2021-05-06 17:17 ` Al Viro
2021-05-06 17:19 ` Jens Axboe
2021-05-06 18:55 ` Al Viro
2021-05-06 19:15 ` Jens Axboe
2021-05-06 21:08 ` Al Viro
2021-05-06 21:17 ` Matthew Wilcox
2021-05-07 14:59 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox