From: Jens Axboe <[email protected]>
To: beld zhang <[email protected]>, [email protected]
Subject: Re: fix max-workers not correctly set on multi-node system
Date: Tue, 2 Nov 2021 12:35:46 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAG7aomWpq3Gt9z9uqAQ5VCA_6pXgvVrL47yVx88xzX6bbotUXw@mail.gmail.com>
On 11/2/21 11:36 AM, beld zhang wrote:
> in io-wq.c: io_wq_max_workers(), new_count[] was changed right after
> each node's value was set.
> this cause the next node got the setting of the previous one,
> following patch fixed it.
>
> returned values are copied from node 0.
Thanks! I've applied this, with some minor changes:
- Your email client is not honoring tabs and spaces
- Improved the commit message a bit
- Use a separate bool to detect first node, instead of assuming
nodes are numbered from 0..N
- Move last copy out of RCU read lock protection
- Add fixes line
Here's the end result:
https://git.kernel.dk/cgit/linux-block/commit/?h=io_uring-5.16&id=71c9ce27bb57c59d8d7f5298e730c8096eef3d1f
--
Jens Axboe
prev parent reply other threads:[~2021-11-02 18:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 17:36 fix max-workers not correctly set on multi-node system beld zhang
2021-11-02 18:35 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox