From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCF441A8F81 for ; Wed, 4 Dec 2024 18:43:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733337814; cv=none; b=uLnixHs03+Yi55rB3wt9ypRJCN4sP6h6rQTiqANvmRBozs749gBjz7H1hXkpyuCqBVoEblQJRC6Lph4P62gOJvKIfYCl26ZGc6q2B5MROSbxtHmuXTS7iJIz2gZEZeduces8PrpMOrYJtWvJKGyjYfbEf0B+mJ6wujzZCswkvgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733337814; c=relaxed/simple; bh=EHUHYmqryRs/Z/xAHGeMfA6OuDGlUTFwWoqL2vGZRRk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Yjd4CaqBqZFKniZ0xu3lt7YMoibwGJz7VbQlLEF0JV8dVGNra4hGhEuYPXabWvhWhxj6l4LPyGB2aZcG8OdITEaB+42LSqsgxMVGfDVBUyz8UpmCtV1Sfi11zabQw+OmtJhLLsDEczvRXa5yAe55Ikj9aMMM9l7FwSIzYLDTSR0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=vVTHbReP; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="vVTHbReP" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-725958d5ee0so130894b3a.1 for ; Wed, 04 Dec 2024 10:43:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1733337812; x=1733942612; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Oy/Up58FD+Iwl3suRccXqqaWRSwiHYWxV6FovUOd6tg=; b=vVTHbRePJ+rRdMLTZ9kYdcrIANZCcqGVKDjW02DgLB6rHGXsNRFNOCBxkT79ZuSSQt G5Dn5fwXFWQXifMN9bV0Fr4j3CW/Y1UKG+NbwECoJL56jtJ0icSK9HzBN8uVrQpTz/am JG66wvf61i4k5mG6zDCh4HKFqKwA3cR0bV3V8Wkhg6kQLINflITNd6BYjP0nKtwPN5HI 5pa0pdipnEQy5KOPxb3fgrTW6LpPphca+p74BIfS/yB/blCjgIt9ObNvMRjUojwB3sgL BEts/ma74k28qfsX/j8Gz7FACNk6EB8oMS7A9p1DWCxvKj4I2aQLZXttlHtBJsiXN0x9 zBZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733337812; x=1733942612; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Oy/Up58FD+Iwl3suRccXqqaWRSwiHYWxV6FovUOd6tg=; b=ZKd9pkyn93NPdLBDnINUeVocXptdhAnT6RvyCYDc3nq94iCyFy3lckUsBzGDttAx+6 SvYa1jYXNXKVIXoEHutwOm4npJe13wJgb6AzYV2MjPNWS2k0/mp86bL+bEKgi9O9oCOm 7l7p4Rqe/bS/Nd0NB3rynFbjOow+EGmRF5lbQ5SzD+OO2JFbxRsHel0UMNjBeUiG5K9/ PWsb/jO9JQwEefuG85/hDRto1JtOf/EXUA27tfDJs4PqxLgnA8nn814AFgPfomSpbI3E u6ncB/6tstZVcDNnzASXfMESiENnToaT2nL0U/LGYiCgohTRAuW94S9Y2xQ660YcIsDt 54Vg== X-Forwarded-Encrypted: i=1; AJvYcCURFn7WUdyh+wv+kwD/LUIRGGm4p7LMeL0Sx/CkwiZLGoQxn325Nq0ZyEOSFmz8bMbcfnrywgT+ZQ==@vger.kernel.org X-Gm-Message-State: AOJu0YyEE9cGBkBAl6hRVgyFNX9nXrxJIHukdfJYWDErzZaxfy0ouzSm cYtY+LEqy7AvyHICJxnaRZoevzhcHSw0fWZtiYbGffewiIcej+L0N7fXDVO/JsU= X-Gm-Gg: ASbGncuAcv6+exaV7NrNX8T9jlkHAXEPR41m++zyL2cVV1gAALWK9Q1Gr0ghJ5+KQkX Q9UKkQnrNcvBzrEQQC+/GCJ9ZaddW+sUrgm469fBTKaFTxwgx654P+BH28Ctx+C4KVdudRqYN0Y +QcqdDgVga6agF7VvhssurfLUGklvEvFdk/y9+r6hwyvGiRFVHV1iSpaT2VMViBO65ahk2/y+pE T7NfamSfkROduGX1bu9+6TqFQjDc8PFV3rU+5IPCxzEuJcbKekDvIQtew== X-Google-Smtp-Source: AGHT+IEhungpF9IDwEdc0oVMgZLsXxL8b0lcjls9v/9SUNlSkhwUS3+q8TtzRXsvpGsf6QAJilCCTQ== X-Received: by 2002:a17:902:e5cf:b0:215:bc30:c952 with SMTP id d9443c01a7336-215bcea0b21mr104595775ad.6.1733337812102; Wed, 04 Dec 2024 10:43:32 -0800 (PST) Received: from ?IPV6:2620:10d:c096:122::1:2343? ([2620:10d:c090:600::1:f6f8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2157145fd3fsm70721165ad.264.2024.12.04.10.43.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Dec 2024 10:43:31 -0800 (PST) Message-ID: <9ddf41e2-bee6-4b31-a602-53b5485e0f6e@kernel.dk> Date: Wed, 4 Dec 2024 11:43:30 -0700 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [io-uring?] KASAN: null-ptr-deref Write in sys_io_uring_register To: Tamir Duberstein , Matthew Wilcox Cc: syzbot , asml.silence@gmail.com, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, Andrew Morton References: <67505f88.050a0220.17bd51.0069.GAE@google.com> <6be84787-b1d9-4a20-85f3-34d8d9a0d492@kernel.dk> <1ab4e254-0254-4089-888b-2ec2ce152302@kernel.dk> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 12/4/24 11:39 AM, Tamir Duberstein wrote: > On Wed, Dec 4, 2024 at 11:30 AM Tamir Duberstein wrote: >> >> On Wed, Dec 4, 2024 at 11:25 AM Matthew Wilcox wrote: >>> >>> On Wed, Dec 04, 2024 at 09:17:27AM -0700, Jens Axboe wrote: >>>>> XA_STATE(xas, xa, index); >>>>> - return xas_result(&xas, xas_store(&xas, NULL)); >>>>> + return xas_result(&xas, xa_zero_to_null(xas_store(&xas, NULL))); >>>>> } >>>>> EXPORT_SYMBOL(__xa_erase); >>>>> >>>>> This would explain deletion of a reserved entry returning >>>>> `XA_ZERO_ENTRY` rather than `NULL`. >>>> >>>> Yep this works. >>>> >>>>> My apologies for this breakage. Should I send a new version? A new >>>>> "fixes" patch? >>>> >>>> Since it seems quite drastically broken, and since it looks like Andrew >>>> is holding it, seems like the best course of action would be to have it >>>> folded with the existing patch. > > Is there anything I can do to help with this? I think Andrew will just fold it in once he sees this thread - but if you want to be sure, I'd send it out separately with a note below the '---' line asking him to fold it with the problematic patch. -- Jens Axboe