From: Jens Axboe <[email protected]>
To: Simon Zeni <[email protected]>, [email protected]
Subject: Re: [PATCH] Fix compilation with iso C standard
Date: Wed, 28 Oct 2020 19:05:27 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <C6OYVIZP1Q2H.2KH87B0QGDQ70@gengar>
On 10/28/20 7:00 PM, Simon Zeni wrote:
> On Wed Oct 28, 2020 at 12:31 PM EDT, Jens Axboe wrote:
>> All of this good stuff should be in the commit message before
>> the '---' or it won't make it into the git log. Which would be a
>> shame!
>>
>> I get a bunch of these with this applied:
>>
>> In file included from /usr/include/x86_64-linux-gnu/sys/types.h:25,
>> from setup.c:4:
>> /usr/include/features.h:187:3: warning: #warning "_BSD_SOURCE and
>> _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp]
>> 187 | # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use
>> _DEFAULT_SOURCE"
>> | ^~~~~~~
>
> I didn't want to fill the commit message with my patch explanation but I
> can make a v2 to fix that definition warning and add the text into the
> commit if you want.
That's what it's there for! The commit message is basically useless
without that added, the only bit you left is a throw-away.
--
Jens Axboe
prev parent reply other threads:[~2020-10-29 1:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 3:18 [PATCH] Fix compilation with iso C standard Simon Zeni
2020-10-28 22:31 ` Jens Axboe
2020-10-29 1:00 ` Simon Zeni
2020-10-29 1:05 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox