From: Jens Axboe <[email protected]>
To: Jiufei Xue <[email protected]>, [email protected]
Cc: [email protected]
Subject: Re: [PATCH v3 1/2] io_uring: change the poll events to be 32-bits
Date: Fri, 12 Jun 2020 08:58:42 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 6/11/20 8:30 PM, Jiufei Xue wrote:
> poll events should be 32-bits to cover EPOLLEXCLUSIVE.
>
> Signed-off-by: Jiufei Xue <[email protected]>
> ---
> fs/io_uring.c | 4 ++--
> include/uapi/linux/io_uring.h | 2 +-
> tools/io_uring/liburing.h | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 47790a2..6250227 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -4602,7 +4602,7 @@ static void io_poll_queue_proc(struct file *file, struct wait_queue_head *head,
> static int io_poll_add_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
> {
> struct io_poll_iocb *poll = &req->poll;
> - u16 events;
> + u32 events;
>
> if (unlikely(req->ctx->flags & IORING_SETUP_IOPOLL))
> return -EINVAL;
> @@ -8196,7 +8196,7 @@ static int __init io_uring_init(void)
> BUILD_BUG_SQE_ELEM(28, /* compat */ int, rw_flags);
> BUILD_BUG_SQE_ELEM(28, /* compat */ __u32, rw_flags);
> BUILD_BUG_SQE_ELEM(28, __u32, fsync_flags);
> - BUILD_BUG_SQE_ELEM(28, __u16, poll_events);
> + BUILD_BUG_SQE_ELEM(28, __u32, poll_events);
> BUILD_BUG_SQE_ELEM(28, __u32, sync_range_flags);
> BUILD_BUG_SQE_ELEM(28, __u32, msg_flags);
> BUILD_BUG_SQE_ELEM(28, __u32, timeout_flags);
> diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.h
> index 92c2269..afc7edd 100644
> --- a/include/uapi/linux/io_uring.h
> +++ b/include/uapi/linux/io_uring.h
> @@ -31,7 +31,7 @@ struct io_uring_sqe {
> union {
> __kernel_rwf_t rw_flags;
> __u32 fsync_flags;
> - __u16 poll_events;
> + __u32 poll_events;
> __u32 sync_range_flags;
> __u32 msg_flags;
> __u32 timeout_flags;
We obviously have the space in there as most other flag members are 32-bits, but
I'd want to double check if we're not changing the ABI here. Is this always
going to be safe, on any platform, regardless of endianess etc?
--
Jens Axboe
next prev parent reply other threads:[~2020-06-12 14:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 2:30 [PATCH v3] io_uring: add EPOLLEXCLUSIVE flag for POLL_ADD operation Jiufei Xue
2020-06-12 2:30 ` [PATCH v3 1/2] io_uring: change the poll events to be 32-bits Jiufei Xue
2020-06-12 14:58 ` Jens Axboe [this message]
2020-06-12 16:48 ` Jens Axboe
2020-06-15 2:49 ` Jiufei Xue
2020-06-15 15:09 ` Jens Axboe
2020-06-16 3:04 ` Jiufei Xue
2020-06-16 13:58 ` Jens Axboe
2020-06-16 18:45 ` Jens Axboe
2020-06-16 19:20 ` Pavel Begunkov
2020-06-16 19:27 ` Jens Axboe
2020-06-16 19:21 ` Jens Axboe
2020-06-16 21:46 ` Pavel Begunkov
2020-06-17 0:06 ` Jens Axboe
2020-06-17 1:39 ` Jiufei Xue
2020-06-12 2:30 ` [PATCH v3 2/2] io_uring: use EPOLLEXCLUSIVE flag to aoid thundering herd type behavior Jiufei Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox