public inbox for [email protected]
 help / color / mirror / Atom feed
From: Pavel Begunkov <[email protected]>
To: Jens Axboe <[email protected]>, [email protected]
Subject: Re: [PATCH liburing 3/3] tests: add more file registration tests
Date: Sun, 17 Apr 2022 15:28:42 +0100	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 4/17/22 14:00, Jens Axboe wrote:
> On 4/17/22 3:09 AM, Pavel Begunkov wrote:
>> diff --git a/test/file-register.c b/test/file-register.c
>> index bd15408..ee2fdcd 100644
>> --- a/test/file-register.c
>> +++ b/test/file-register.c
>> @@ -745,7 +745,90 @@ static int test_fixed_removal_ordering(void)
>>   	return 0;
>>   }
>>   
>> +/* mix files requiring SCM-accounting and not in a single register */
>> +static int test_mixed_af_unix(void)
>> +{
>> +	struct io_uring ring;
>> +	int i, ret, fds[2];
>> +	int reg_fds[32];
>> +	int sp[2];
>> +
>> +	ret = io_uring_queue_init(8, &ring, 0);
>> +	if (ret < 0) {
>> +		fprintf(stderr, "failed to init io_uring: %s\n", strerror(-ret));
>> +		return ret;
>> +	}
>> +	if (pipe(fds)) {
>> +		perror("pipe");
>> +		return -1;
>> +	}
>> +	if (socketpair(AF_UNIX, SOCK_DGRAM, 0, sp) != 0) {
>> +		perror("Failed to create Unix-domain socket pair\n");
>> +		return 1;
>> +	}
>> +
>> +	for (i = 0; i < 16; i++) {
>> +		reg_fds[i * 2] = fds[0];
>> +		reg_fds[i * 2 + 1] = sp[0];
>> +	}
>>   
>> +	ret = io_uring_register_files(&ring, reg_fds, 32);
>> +	if (!ret) {
>> +		fprintf(stderr, "file_register: %d\n", ret);
>> +		return ret;
>> +	}
> 
> This check looks wrong.

Agree, resending it

-- 
Pavel Begunkov

  reply	other threads:[~2022-04-17 14:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-17  9:09 [PATCH liburing 0/3] extra tests Pavel Begunkov
2022-04-17  9:09 ` [PATCH liburing 1/3] tests: reduce multicqe_drain waiting time Pavel Begunkov
2022-04-17  9:09 ` [PATCH liburing 2/3] tests: extend scm cycle breaking tests Pavel Begunkov
2022-04-17  9:09 ` [PATCH liburing 3/3] tests: add more file registration tests Pavel Begunkov
2022-04-17 13:00   ` Jens Axboe
2022-04-17 14:28     ` Pavel Begunkov [this message]
2022-04-17 13:01 ` (subset) [PATCH liburing 0/3] extra tests Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox