From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6079C4363C for ; Fri, 2 Oct 2020 17:16:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9951A20665 for ; Fri, 2 Oct 2020 17:16:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qk+tdboH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387688AbgJBRQ6 (ORCPT ); Fri, 2 Oct 2020 13:16:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726813AbgJBRQ6 (ORCPT ); Fri, 2 Oct 2020 13:16:58 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E299C0613D0 for ; Fri, 2 Oct 2020 10:16:57 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id w2so2402223wmi.1 for ; Fri, 02 Oct 2020 10:16:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Ha47qnmpVb7Spy8+3X8qrofuBMpz0VRcRhcHZnoDaqk=; b=Qk+tdboHcHIGzGxyJ2Knd4AhcHLMzSnaR1/Guij1Ej4kkWBrXtFCYYLNAXw7z0vkms Qt4fOyT7RecW0wvul7jtTj+FlizFSiPhpJ1uM3+qbB5Kt9s+8vPUwsZM9hr78rL/jSfb 8LHWBUtkz2qohBI4FexJQMRVuybiDltyWWtwLwdLmguvW3sEHNdsQWbG8WHzeuAEPC6i M4/YQzFMbJU4NRHDGDUE2ectCxKUiCMCKzJQUIShCClddxkGD+BHbYDkCRKBz8Wc3RDJ HL74RVJwVkNf6SUvT95teKyf3MIHYFNKeevIGw8i5ZkqJYF1i8N5spUb+TYYnHIzrhST pcPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ha47qnmpVb7Spy8+3X8qrofuBMpz0VRcRhcHZnoDaqk=; b=XfQBTsyssfTX5OeB+vMIv4noJxjDukNqSMpxW05l1eGrNiOXwtsOvZBsqVPSukVEBg TX13CLxUMROmqlU2rM6hywWL44WdfOBiS6PFlGA+L7qHeyyZIpEAUM8OGkecmvvUqnYi MOiX1SMvSGhrl63/ekKGH7mZghZshshAcVoh7ngBNHUmOAmeTQQllQTaPMCVYqJlu/bk DTjcMR9zYPYMJXLmkTsBCMWb0x2kMFhYSbJP9kdQASzAyp7mQcOGBPKJSeLTUxfAuRN/ Q1sDDcuCoeSMj1z2lI8KWysEhQv0QAyNa6SKOsUfvcP664709Ksjanzhs9Cefl4RWkLq igXg== X-Gm-Message-State: AOAM532l9u5fOVpbCvfwMZQDhpehToOXUSe5UU1n7NY8MNkGEoqeBL27 IxmW00v3EzBoTznthIKqb6R+knnbOZk= X-Google-Smtp-Source: ABdhPJxZ7oaCVbgCZgPxLxkdyjcY8C4DWX3pJa9XTOzSHvkK1nJYkKABCZ5rt9yVZme2VpPjdV+6ZA== X-Received: by 2002:a05:600c:410e:: with SMTP id j14mr4198149wmi.13.1601659015997; Fri, 02 Oct 2020 10:16:55 -0700 (PDT) Received: from [192.168.1.151] (host109-152-100-140.range109-152.btcentralplus.com. [109.152.100.140]) by smtp.gmail.com with ESMTPSA id d135sm2365112wmd.33.2020.10.02.10.16.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Oct 2020 10:16:55 -0700 (PDT) Subject: Re: [PATCH 1/5] io_uring: grab any needed state during defer prep To: Jens Axboe , io-uring@vger.kernel.org References: <20200914162555.1502094-1-axboe@kernel.dk> <20200914162555.1502094-2-axboe@kernel.dk> <77283ddd-77d9-41e1-31d2-2b9734ee2388@gmail.com> <79e9d619-882b-8915-32df-ced1886e1eb3@gmail.com> <6f514236-a584-e333-3ce2-8fd63c69c9c3@gmail.com> From: Pavel Begunkov Autocrypt: addr=asml.silence@gmail.com; prefer-encrypt=mutual; keydata= mQINBFmKBOQBEAC76ZFxLAKpDw0bKQ8CEiYJRGn8MHTUhURL02/7n1t0HkKQx2K1fCXClbps bdwSHrhOWdW61pmfMbDYbTj6ZvGRvhoLWfGkzujB2wjNcbNTXIoOzJEGISHaPf6E2IQx1ik9 6uqVkK1OMb7qRvKH0i7HYP4WJzYbEWVyLiAxUj611mC9tgd73oqZ2pLYzGTqF2j6a/obaqha +hXuWTvpDQXqcOZJXIW43atprH03G1tQs7VwR21Q1eq6Yvy2ESLdc38EqCszBfQRMmKy+cfp W3U9Mb1w0L680pXrONcnlDBCN7/sghGeMHjGKfNANjPc+0hzz3rApPxpoE7HC1uRiwC4et83 CKnncH1l7zgeBT9Oa3qEiBlaa1ZCBqrA4dY+z5fWJYjMpwI1SNp37RtF8fKXbKQg+JuUjAa9 Y6oXeyEvDHMyJYMcinl6xCqCBAXPHnHmawkMMgjr3BBRzODmMr+CPVvnYe7BFYfoajzqzq+h EyXSl3aBf0IDPTqSUrhbmjj5OEOYgRW5p+mdYtY1cXeK8copmd+fd/eTkghok5li58AojCba jRjp7zVOLOjDlpxxiKhuFmpV4yWNh5JJaTbwCRSd04sCcDNlJj+TehTr+o1QiORzc2t+N5iJ NbILft19Izdn8U39T5oWiynqa1qCLgbuFtnYx1HlUq/HvAm+kwARAQABtDFQYXZlbCBCZWd1 bmtvdiAoc2lsZW5jZSkgPGFzbWwuc2lsZW5jZUBnbWFpbC5jb20+iQJOBBMBCAA4FiEE+6Ju PTjTbx479o3OWt5b1Glr+6UFAlmKBOQCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQ Wt5b1Glr+6WxZA//QueaKHzgdnOikJ7NA/Vq8FmhRlwgtP0+E+w93kL+ZGLzS/cUCIjn2f4Q Mcutj2Neg0CcYPX3b2nJiKr5Vn0rjJ/suiaOa1h1KzyNTOmxnsqE5fmxOf6C6x+NKE18I5Jy xzLQoktbdDVA7JfB1itt6iWSNoOTVcvFyvfe5ggy6FSCcP+m1RlR58XxVLH+qlAvxxOeEr/e aQfUzrs7gqdSd9zQGEZo0jtuBiB7k98t9y0oC9Jz0PJdvaj1NZUgtXG9pEtww3LdeXP/TkFl HBSxVflzeoFaj4UAuy8+uve7ya/ECNCc8kk0VYaEjoVrzJcYdKP583iRhOLlZA6HEmn/+Gh9 4orG67HNiJlbFiW3whxGizWsrtFNLsSP1YrEReYk9j1SoUHHzsu+ZtNfKuHIhK0sU07G1OPN 2rDLlzUWR9Jc22INAkhVHOogOcc5ajMGhgWcBJMLCoi219HlX69LIDu3Y34uIg9QPZIC2jwr 24W0kxmK6avJr7+n4o8m6sOJvhlumSp5TSNhRiKvAHB1I2JB8Q1yZCIPzx+w1ALxuoWiCdwV M/azguU42R17IuBzK0S3hPjXpEi2sK/k4pEPnHVUv9Cu09HCNnd6BRfFGjo8M9kZvw360gC1 reeMdqGjwQ68o9x0R7NBRrtUOh48TDLXCANAg97wjPoy37dQE7e5Ag0EWYoE5AEQAMWS+aBV IJtCjwtfCOV98NamFpDEjBMrCAfLm7wZlmXy5I6o7nzzCxEw06P2rhzp1hIqkaab1kHySU7g dkpjmQ7Jjlrf6KdMP87mC/Hx4+zgVCkTQCKkIxNE76Ff3O9uTvkWCspSh9J0qPYyCaVta2D1 Sq5HZ8WFcap71iVO1f2/FEHKJNz/YTSOS/W7dxJdXl2eoj3gYX2UZNfoaVv8OXKaWslZlgqN jSg9wsTv1K73AnQKt4fFhscN9YFxhtgD/SQuOldE5Ws4UlJoaFX/yCoJL3ky2kC0WFngzwRF Yo6u/KON/o28yyP+alYRMBrN0Dm60FuVSIFafSqXoJTIjSZ6olbEoT0u17Rag8BxnxryMrgR dkccq272MaSS0eOC9K2rtvxzddohRFPcy/8bkX+t2iukTDz75KSTKO+chce62Xxdg62dpkZX xK+HeDCZ7gRNZvAbDETr6XI63hPKi891GeZqvqQVYR8e+V2725w+H1iv3THiB1tx4L2bXZDI DtMKQ5D2RvCHNdPNcZeldEoJwKoA60yg6tuUquvsLvfCwtrmVI2rL2djYxRfGNmFMrUDN1Xq F3xozA91q3iZd9OYi9G+M/OA01husBdcIzj1hu0aL+MGg4Gqk6XwjoSxVd4YT41kTU7Kk+/I 5/Nf+i88ULt6HanBYcY/+Daeo/XFABEBAAGJAjYEGAEIACAWIQT7om49ONNvHjv2jc5a3lvU aWv7pQUCWYoE5AIbDAAKCRBa3lvUaWv7pfmcEACKTRQ28b1y5ztKuLdLr79+T+LwZKHjX++P 4wKjEOECCcB6KCv3hP+J2GCXDOPZvdg/ZYZafqP68Yy8AZqkfa4qPYHmIdpODtRzZSL48kM8 LRzV8Rl7J3ItvzdBRxf4T/Zseu5U6ELiQdCUkPGsJcPIJkgPjO2ROG/ZtYa9DvnShNWPlp+R uPwPccEQPWO/NP4fJl2zwC6byjljZhW5kxYswGMLBwb5cDUZAisIukyAa8Xshdan6C2RZcNs rB3L7vsg/R8UCehxOH0C+NypG2GqjVejNZsc7bgV49EOVltS+GmGyY+moIzxsuLmT93rqyII 5rSbbcTLe6KBYcs24XEoo49Zm9oDA3jYvNpeYD8rDcnNbuZh9kTgBwFN41JHOPv0W2FEEWqe JsCwQdcOQ56rtezdCJUYmRAt3BsfjN3Jn3N6rpodi4Dkdli8HylM5iq4ooeb5VkQ7UZxbCWt UVMKkOCdFhutRmYp0mbv2e87IK4erwNHQRkHUkzbsuym8RVpAZbLzLPIYK/J3RTErL6Z99N2 m3J6pjwSJY/zNwuFPs9zGEnRO4g0BUbwGdbuvDzaq6/3OJLKohr5eLXNU3JkT+3HezydWm3W OPhauth7W0db74Qd49HXK0xe/aPrK+Cp+kU1HRactyNtF8jZQbhMCC8vMGukZtWaAwpjWiiH bA== Message-ID: <9f864917-a9c1-c588-ca4c-ec6e8033b95f@gmail.com> Date: Fri, 2 Oct 2020 20:14:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 02/10/2020 20:09, Jens Axboe wrote: > On 10/2/20 11:01 AM, Jens Axboe wrote: >> On 10/2/20 10:34 AM, Pavel Begunkov wrote: >>> On 02/10/2020 19:14, Pavel Begunkov wrote: >>>> On 19/09/2020 19:56, Pavel Begunkov wrote: >>>>> On 19/09/2020 18:27, Pavel Begunkov wrote: >>>>>> On 14/09/2020 19:25, Jens Axboe wrote: >>>>>>> Always grab work environment for deferred links. The assumption that we >>>>>>> will be running it always from the task in question is false, as exiting >>>>>>> tasks may mean that we're deferring this one to a thread helper. And at >>>>>>> that point it's too late to grab the work environment. >>>>> Forgot that they will be cancelled there. So, how it could happen? >>>>> Is that the initial thread will run task_work but loosing >>>>> some resources like mm prior to that? e.g. in do_exit() >>>> >>>> Jens, please let me know when you get time for that. I was thinking that >>>> you were meaning do_exit(), which does task_work_run() after killing mm, >>>> etc., but you mentioned a thread helper in the description... Which one >>>> do you mean? >>> >>> Either it refers to stuff after io_ring_ctx_wait_and_kill(), which >>> delegates the rest to io_ring_exit_work() via @system_unbound_wq. >> >> We punt the request to task_work. task_work is run, we're still in the >> right context. We fail with -EAGAIN, and then call io_queue_async_work() >> and we're not doing async prep at that point. > > BTW, I think we can improve on this for 5.10, on top of your cleanups. > So that would certainly be welcome! Yeah, I was going for that, it'll be in my way anyway. -- Pavel Begunkov