From: Chaitanya Kulkarni <[email protected]>
To: Colin King <[email protected]>,
Alexander Viro <[email protected]>,
Jens Axboe <[email protected]>,
"[email protected]" <[email protected]>,
"[email protected]" <[email protected]>
Cc: "[email protected]"
<[email protected]>,
"[email protected]" <[email protected]>
Subject: Re: [PATCH] io_uring: remove redundant variable pointer nxt and io_wq_assign_next call
Date: Mon, 6 Apr 2020 22:59:18 +0000 [thread overview]
Message-ID: <BYAPR04MB4965E6F6CCDA94AAD2EA1DDB86C20@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: [email protected]
On 04/06/2020 03:54 PM, Colin King wrote:
> From: Colin Ian King<[email protected]>
>
> An earlier commit "io_uring: remove @nxt from handlers" removed the
> setting of pointer nxt and now it is always null, hence the non-null
> check and call to io_wq_assign_next is redundant and can be removed.
>
> Addresses-Coverity: ("'Constant' variable guard")
> Signed-off-by: Colin Ian King<[email protected]>
Looks good.
Reviewed-by: Chaitanya Kulkarni <[email protected]>
next prev parent reply other threads:[~2020-04-06 22:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 22:54 [PATCH] io_uring: remove redundant variable pointer nxt and io_wq_assign_next call Colin King
2020-04-06 22:59 ` Chaitanya Kulkarni [this message]
2020-04-06 23:33 ` Jens Axboe
2020-04-07 6:12 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB4965E6F6CCDA94AAD2EA1DDB86C20@BYAPR04MB4965.namprd04.prod.outlook.com \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox