public inbox for [email protected]
 help / color / mirror / Atom feed
From: "Zhang, Qiang" <[email protected]>
To: Jens Axboe <[email protected]>
Cc: "[email protected]" <[email protected]>,
	"[email protected]" <[email protected]>
Subject: 回复: [PATCH] io-wq: set task TASK_INTERRUPTIBLE state before schedule_timeout
Date: Wed, 28 Oct 2020 02:47:53 +0000	[thread overview]
Message-ID: <BYAPR11MB2632A45DB4DA30E34D412528FF170@BYAPR11MB2632.namprd11.prod.outlook.com> (raw)
In-Reply-To: <[email protected]>



________________________________________
发件人: Jens Axboe <[email protected]>
发送时间: 2020年10月27日 21:35
收件人: Zhang, Qiang
抄送: [email protected]; [email protected]
主题: Re: [PATCH] io-wq: set task TASK_INTERRUPTIBLE state before schedule_timeout

On 10/26/20 9:09 PM, [email protected] wrote:
> From: Zqiang <[email protected]>
>
> In 'io_wqe_worker' thread, if the work which in 'wqe->work_list' be
> finished, the 'wqe->work_list' is empty, and after that the
> '__io_worker_idle' func return false, the task state is TASK_RUNNING,
> need to be set TASK_INTERRUPTIBLE before call schedule_timeout func.
>
>I don't think that's safe - what if someone added work right before you
>call schedule_timeout_interruptible? Something ala:
>
>
>io_wq_enqueue()
>                        set_current_state(TASK_INTERRUPTIBLE();
>                        schedule_timeout(WORKER_IDLE_TIMEOUT);
>
>then we'll have work added and the task state set to running, but the
>worker itself just sets us to non-running and will hence wait
>WORKER_IDLE_TIMEOUT before the work is processed.
>
>The current situation will do one extra loop for this case, as the
>schedule_timeout() just ends up being a nop and we go around again

although the worker task state is running,  due to the call schedule_timeout, the 
current worker still possible to be switched out.
if set current worker task is no-running, the current worker be switched out, but
the schedule will call io_wq_worker_sleeping func  to wake up free worker task, if 
wqe->free_list is not empty.  

>checking for work. Since we already unused the mm, the next iteration
>will go to sleep properly unless new work came in.
>
>--
>Jens Axboe


  reply	other threads:[~2020-10-28 21:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27  3:09 [PATCH] io-wq: set task TASK_INTERRUPTIBLE state before schedule_timeout qiang.zhang
2020-10-27 13:35 ` Jens Axboe
2020-10-28  2:47   ` Zhang, Qiang [this message]
2020-10-28 13:36     ` 回复: " Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB2632A45DB4DA30E34D412528FF170@BYAPR11MB2632.namprd11.prod.outlook.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox