From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 561D4C433F5 for ; Thu, 10 Mar 2022 12:40:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237246AbiCJMlf (ORCPT ); Thu, 10 Mar 2022 07:41:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239897AbiCJMlf (ORCPT ); Thu, 10 Mar 2022 07:41:35 -0500 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA775148909; Thu, 10 Mar 2022 04:40:34 -0800 (PST) Received: by mail-lj1-x22d.google.com with SMTP id o6so7526850ljp.3; Thu, 10 Mar 2022 04:40:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DAtfKJxhTlUfLfh7FDdHLWXEZv3s/cYhD3RWZTonYVc=; b=CNx5wp3+3lfwtIyoCM9pRl1cXVqdYbE6/d4Op9YI4mLz2vYcAduj4xLyqq95HxWX8Y /UqkC3O3uouwq15gtsKUA6ISPm+F1W/NRnQEkLSibFQOOlM9Ou0pWViE0PSFvdm+i6hE cVbSFHOo87qTdoL+ls2yBlZrEyEryORUwE8MY9mVRruJmSXBKW5MO0pjMPclHlgbe35v vv73luUALWmVAxQhjuYyrg1o3+DZ5JaBwo7pgQE7XuCtVhXNxaEdVMhp+gJpOh3jpDla hYADDMd0nJAtdtyPxuB/9RzMmIl5x5EZmsyiZDBHc7/PTZkR5jNUByZbxz54s09DOrJC evqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DAtfKJxhTlUfLfh7FDdHLWXEZv3s/cYhD3RWZTonYVc=; b=NDluLH0wklj+oY8FpnZswnnJ6vVfQxwBfNokY/zYVlLAenwrGPY2CgW4ZX3ytnMbQ3 52znFy539AqKtxqJ899L5S8MpCWKsVrxyP7IKppso8+9g49/Q7tJp/Jszn/sAIQAnA5v z26moadzY13YhApQ+aAFQ3rfaeNPZ2gtEMeoy1ycrOHtw2Rf4HbFfwaoCPv+EY3dwDb5 G1FNSYJ1VLj8AKqAxFdJ5KFb7NMezMuRd6nYBdrGJ89cunhYZLxcWky0Tr5gs43/uUoh pkJsnwguGKfznYbpXt90gxnx8By9bv29u8EeEje8A2D/gmL/sdnDmRvXBLKBB2tlROnp +BcQ== X-Gm-Message-State: AOAM531KzQ+R3siFeV/PO/RJOpGGwCb0PA8LvSL0K79zpD/MvVO1rzkt ZfPVH2w1uQjKdJ4e8svTBzURmsbxVp/mnw6UTIc= X-Google-Smtp-Source: ABdhPJyOXMDOJXEweNjgQ/Heimakq+LFmrhTTQqxKwAXvx1dEWUO11jTrEOo7xbbSHGosGfV5AfpN6e8NUahPBFVAbw= X-Received: by 2002:a2e:3004:0:b0:223:c126:5d1a with SMTP id w4-20020a2e3004000000b00223c1265d1amr2931647ljw.408.1646916033166; Thu, 10 Mar 2022 04:40:33 -0800 (PST) MIME-Version: 1.0 References: <20220308152105.309618-1-joshi.k@samsung.com> <20220308152105.309618-11-joshi.k@samsung.com> <20220310083400.GD26614@lst.de> In-Reply-To: <20220310083400.GD26614@lst.de> From: Kanchan Joshi Date: Thu, 10 Mar 2022 18:10:08 +0530 Message-ID: Subject: Re: [PATCH 10/17] block: wire-up support for plugging To: Christoph Hellwig Cc: Kanchan Joshi , Jens Axboe , Keith Busch , Pavel Begunkov , io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, sbates@raithlin.com, logang@deltatee.com, Pankaj Raghav , =?UTF-8?Q?Javier_Gonz=C3=A1lez?= , Luis Chamberlain , Adam Manzanares , Anuj Gupta Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Thu, Mar 10, 2022 at 2:04 PM Christoph Hellwig wrote: > > On Tue, Mar 08, 2022 at 08:50:58PM +0530, Kanchan Joshi wrote: > > From: Jens Axboe > > > > Add support to use plugging if it is enabled, else use default path. > > The subject and this comment don't really explain what is done, and > also don't mention at all why it is done. Missed out, will fix up. But plugging gave a very good hike to IOPS. Especially while comparing this with io-uring's block-io path that keeps .plug enabled. Patch 9 (that enables .plug for uring-cmd) and this goes hand in hand.