From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF43EC433EF for ; Tue, 7 Sep 2021 16:48:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D324960E77 for ; Tue, 7 Sep 2021 16:48:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345076AbhIGQth (ORCPT ); Tue, 7 Sep 2021 12:49:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345327AbhIGQt1 (ORCPT ); Tue, 7 Sep 2021 12:49:27 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13E7CC061575 for ; Tue, 7 Sep 2021 09:48:21 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id q11so15426602wrr.9 for ; Tue, 07 Sep 2021 09:48:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LEtLeeGoFT8WbYTgRN3HPOn8m+iO600FeLjofpTTVKc=; b=kFT+bZHs4/bwXFPsPozvGaiFNmOrEdGI2lwaizqHt0g4Tc7o+nFSxLVT2xn9csBjSg 742ZBjU2sTYGnkO6G0ljNyVsV6HkzmR+BDlpZNvd59EfLo8sg0mSH+Ub9LGBlAOxvnrH SBm+yqcd7cZL17QAnpr0ISvX4AN1hJUHzzt2aQRioSLCzFZvC7xue7Dy6HOfIIlil5wk so0FE9HkowHkw2QTNNNENEzrJ7DRCMWbET1gGq+iNAQJfbnYwRjb0djbapWz65kOHi78 svEz+mMHh6AQaPXyrSlPkxY9Vq4ITsWg905bf8ItHn9erSQuTqJYq9fRzerr+GprSRAf LfuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LEtLeeGoFT8WbYTgRN3HPOn8m+iO600FeLjofpTTVKc=; b=fFODcQKsf3ujRzHlz/nu7lWXuOO8Uy8F0JaaGDMw4cqkSfT08Co/R83yOy4TeT50rp AgymvSSLGBizWFlcxXX+k53UenPSH2UgxExJ6HcEYNof7ldrugkxGcqdeNobN+68wYOP mS9od6BGBePIXtXVZHUimu4ZTVEXJYLWPX/V06uZfBDXGssmOC3lUWJpHQvpRIj+5Rof lNsr3yrDizIZJbx0e1KRJ3XjjvjN9NMiGD3Yr6y8tNwnkSUV8V2iNIQ/wpskZxHnLmfk I5gBvGwlvpoZ+8+VeyrT18eBjI7F+sEeRaJqtisV2ziuJQ53ghmeqhoGPTHQaQ6vaOrc DNhw== X-Gm-Message-State: AOAM530+wxSF1lZBHPzXNwqLbBUhn9wQB2h+EMDZ19vluN5OgQyBjjlr etJCVSP6UrZhtKbv0A2XJHuS8r+ZxztzagvqfLI= X-Google-Smtp-Source: ABdhPJx5l+2h9vRLIxgDpts+tXpc6KsZin2C4O26GsUgSORJMvpJyhdwVoRA3G6HU0hoJPjCWLZax6gg9IApUdatgiA= X-Received: by 2002:adf:90cc:: with SMTP id i70mr19815231wri.408.1631033299617; Tue, 07 Sep 2021 09:48:19 -0700 (PDT) MIME-Version: 1.0 References: <20210805125539.66958-1-joshi.k@samsung.com> <20210805125539.66958-7-joshi.k@samsung.com> <20210907075055.GE29874@lst.de> In-Reply-To: <20210907075055.GE29874@lst.de> From: Kanchan Joshi Date: Tue, 7 Sep 2021 22:17:53 +0530 Message-ID: Subject: Re: [RFC PATCH 6/6] nvme: enable passthrough with fixed-buffer To: Christoph Hellwig Cc: Kanchan Joshi , Jens Axboe , Keith Busch , io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, anuj20.g@samsung.com, Javier Gonzalez , hare@suse.de Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Tue, Sep 7, 2021 at 1:21 PM Christoph Hellwig wrote: > > > +/* > > + * Unlike blk_rq_map_user () this is only for fixed-buffer async passthrough. > > + * And hopefully faster as well. > > + */ > > This belongs into io_uring.c. And that hopeful comment needs to be > validated and removed. I'll do away with that comment. But sorry, what part do you think should rather move to io_uring. Is that for the whole helper "nvme_rq_map_user_fixed"? -- Kanchan