From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16A05C433FE for ; Tue, 22 Mar 2022 16:57:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239325AbiCVQ7C (ORCPT ); Tue, 22 Mar 2022 12:59:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239326AbiCVQ7A (ORCPT ); Tue, 22 Mar 2022 12:59:00 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 596E964E5; Tue, 22 Mar 2022 09:57:32 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id c15so24781352ljr.9; Tue, 22 Mar 2022 09:57:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TWipBvtrLS7SDRJREmYi7xhXNmXrdgMxstsUKJVGDuE=; b=G7IqZ71UBXpyaD09zRRZv35E6IQjNOWS/SSNBW5UAnfM4GHf9uJT4rJj3b/YDCt3A+ 6eis8nStO2jnaTjbRwXLsthm2oDAB3vwvYcHsQy54d1OOvn13oAOwbLL5SYVeiqXhmHQ ERQ3VR5V83EjdMqE+ZTZlOjQ5QGITMqwqCdktKtWbO3SyGTtX+6bVbpw2Lsg06JKKVKC r/ZN3ShnOKZdPM3dvYaSh+DKYbB5CdqqLSfucplI2CFshpcz3/lIVs+Yp2Wy88eIrcqK hQFNaTZGtb7w5wT2JEonDuxMgomo5atJQ7aid05aXQG97yQyTvuiekPUGJvXkrK0qulS PnYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TWipBvtrLS7SDRJREmYi7xhXNmXrdgMxstsUKJVGDuE=; b=XJFVChJo2TTyvo+2zLt2iD3ur+s8Rig/Vrek89p8z+cyh98e/vBBTrsMrzhdOAKCre awCeGauZD2RNZg/c2bJms2zqnhu3Xn86vBdKhffB/7HikG/evES46rsPh/6vyDGwi4Yi XmG6X+rCcXV9X7icq8/ENJfiCWrBkU/vIO7DFLPEXAjqyNS3Xi0hbj3Hs4mcXdmsA3RP 8bWfn2Yn3ciOAuo7bf4NgoyhTM34tmebg/NR2OTLwuUX3R6jyHTI0UJuyorumkh9BcI7 xEfmF7kDDwBK47FM0qEB52J98mf7FCvlzzMVgM+XBLfXmQotUIZrU7TVuNeUHKV4/v+F JNvA== X-Gm-Message-State: AOAM530GKCLvkWQKhQnE7s0XIvi61QsSERP9qFLh4CbLp54h95r+cI9s I1bIofJe/uM7FrPdvc1vhIop4s3QO3nLJXt5xs8= X-Google-Smtp-Source: ABdhPJypKsaffUKrJLUbPFtEm8ZS8M14Y/ZHi1ZyW8gvPWJb8Da3NB80ZPwSsX4MEjwRtEjI3cuSkXUCCALqZo+EQq0= X-Received: by 2002:a2e:9990:0:b0:249:88f6:f637 with SMTP id w16-20020a2e9990000000b0024988f6f637mr6185841lji.14.1647968248527; Tue, 22 Mar 2022 09:57:28 -0700 (PDT) MIME-Version: 1.0 References: <20220308152105.309618-1-joshi.k@samsung.com> <20220308152105.309618-6-joshi.k@samsung.com> In-Reply-To: From: Kanchan Joshi Date: Tue, 22 Mar 2022 22:27:02 +0530 Message-ID: Subject: Re: [PATCH 05/17] nvme: wire-up support for async-passthru on char-device. To: Clay Mayers Cc: Kanchan Joshi , "axboe@kernel.dk" , "hch@lst.de" , "kbusch@kernel.org" , "asml.silence@gmail.com" , "io-uring@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , "sbates@raithlin.com" , "logang@deltatee.com" , "pankydev8@gmail.com" , "javier@javigon.com" , "mcgrof@kernel.org" , "a.manzanares@samsung.com" , "anuj20.g@samsung.com" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org > > + > > + if (!status && pdu->meta_buffer) { > > + if (copy_to_user(pdu->meta_buffer, pdu->meta, pdu- > > >meta_len)) > > This copy is incorrectly called for writes. Indeed. Will fix this up in v2, thanks. -- Kanchan