public inbox for [email protected]
 help / color / mirror / Atom feed
From: Kanchan Joshi <[email protected]>
To: Jens Axboe <[email protected]>
Cc: Pavel Begunkov <[email protected]>,
	Kanchan Joshi <[email protected]>,
	Keith Busch <[email protected]>, Christoph Hellwig <[email protected]>,
	[email protected], [email protected],
	[email protected], [email protected],
	[email protected],
	Javier Gonzalez <[email protected]>,
	Nitesh Shetty <[email protected]>,
	[email protected]
Subject: Re: [RFC PATCH 0/4] Asynchronous passthrough ioctl
Date: Thu, 28 Jan 2021 22:55:41 +0530	[thread overview]
Message-ID: <CA+1E3rLD2e4yFsA-gxPGtp2Fg2Z0sdfpS3Rz+WsUC4i5aF43LA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>

On Thu, Jan 28, 2021 at 8:20 PM Jens Axboe <[email protected]> wrote:
>
> On 1/28/21 5:04 AM, Kanchan Joshi wrote:
> > And for some ioctls, driver may still need to use task-work to update
> > the user-space pointers (embedded in uring/ioctl cmd) during
> > completion.
>
> For this use case, we should ensure that just io_uring handles this
> part. It's already got everything setup for it, and I'd rather avoid
> having drivers touch any of those parts. Could be done by having an
> io_uring helper ala:
>
> io_uring_cmd_complete_in_task(cmd, handler);
>
> which takes care of the nitty gritty details.

Ah right. With that, I can do away with exporting task-work.
NVMe completion can invoke (depending on ioctl) this uring-helper with
a handler that does the ioctl-specific update in task context.



-- 
Kanchan

      reply	other threads:[~2021-01-28 17:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210127150134epcas5p251fc1de3ff3581dd4c68b3fbe0b9dd91@epcas5p2.samsung.com>
2021-01-27 15:00 ` [RFC PATCH 0/4] Asynchronous passthrough ioctl Kanchan Joshi
     [not found]   ` <CGME20210127150140epcas5p32832cc0c0db953db199eb9dd326f2d4c@epcas5p3.samsung.com>
2021-01-27 15:00     ` [RFC PATCH 1/4] block: introduce async ioctl operation Kanchan Joshi
     [not found]   ` <CGME20210127150144epcas5p29ccb35d7e7170aba7947b5ee16fd2db0@epcas5p2.samsung.com>
2021-01-27 15:00     ` [RFC PATCH 2/4] kernel: export task_work_add Kanchan Joshi
     [not found]   ` <CGME20210127150149epcas5p4fa8edd47712f28ccdd9bac5139fc6e61@epcas5p4.samsung.com>
2021-01-27 15:00     ` [RFC PATCH 3/4] nvme: add async ioctl support Kanchan Joshi
     [not found]   ` <CGME20210127150156epcas5p26cdf368e4ff6bffb132fa1c7f9430653@epcas5p2.samsung.com>
2021-01-27 15:00     ` [RFC PATCH 4/4] io_uring: add async passthrough " Kanchan Joshi
2021-01-27 15:42   ` [RFC PATCH 0/4] Asynchronous passthrough ioctl Pavel Begunkov
2021-01-27 15:53     ` Pavel Begunkov
2021-01-28 12:04       ` Kanchan Joshi
2021-01-28 14:38         ` Jens Axboe
2021-01-28 17:13           ` Kanchan Joshi
2021-01-28 17:24             ` Jens Axboe
2021-02-22 13:42               ` Kanchan Joshi
2021-02-22 14:33                 ` Jens Axboe
2021-02-23  4:41                   ` Kanchan Joshi
2021-01-28 14:50         ` Jens Axboe
2021-01-28 17:25           ` Kanchan Joshi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+1E3rLD2e4yFsA-gxPGtp2Fg2Z0sdfpS3Rz+WsUC4i5aF43LA@mail.gmail.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox