From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E6CEC7618D for ; Thu, 6 Apr 2023 15:35:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239790AbjDFPfJ (ORCPT ); Thu, 6 Apr 2023 11:35:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239805AbjDFPfI (ORCPT ); Thu, 6 Apr 2023 11:35:08 -0400 Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CA717EFE for ; Thu, 6 Apr 2023 08:35:06 -0700 (PDT) Received: by mail-il1-x130.google.com with SMTP id e9e14a558f8ab-316d901b2ecso382545ab.0 for ; Thu, 06 Apr 2023 08:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680795305; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VUL9Ul78Bpb3XRyOISIrcWSMNz2ErChRMmovjR4Alg0=; b=OYF148h4Nm9P6PgvskOIuWTx30F1Bwm7sbtDJbrJbROEL6DvXKusP6nniCeRlURmqR Bj2InPvg2FA4L1hHmkdJMUGoq+ezpYia8hiEp0SJQBf39ETQ75/GR2XsYCc8SFs1gUGj Jf4DLn0zPZ0GlGNIpf+McheP0yGY5MwfsfoMtXPV96d4guPMxk/R7YSuetOPL3y+1scw En0Dk0K+jo9iVfkcLHvTAX/VoDqS7L/4lxFgnddiTGSXicaTmbnwBfISMqbET7wnlqlr 8lZFgnbtACkUXk5Z9UmfE1fEuCigYlm6OgLjM5ppw/fUxFUJ9+u7Rmfu02TIZR1YcTUO 49CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680795305; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VUL9Ul78Bpb3XRyOISIrcWSMNz2ErChRMmovjR4Alg0=; b=UPGdyWzN+AtsYJ/upunX/bhbvxG0Pyqh5P62XSSOTbmcPLWt7UUwvCZgA30KZZjHao kR8kay+UaUXfKPyfydIWIkytKoWg3yWevZTXAAgaDi3bpi//IVDDirmrLL/KvB6Jeu1v NukONIbpyOfFtXGVxkQRSNE6F2QXzp/13IHbMUl+M8PRIGfJhF0ocwabqMSKv8j64yS4 /gLgV9RAzYq5m69t8fzNSopnqip68aPjJkbtvC6qVHxdXbouDgUL+qPAeF5zuIXQynlA ZHE5+UlJnz+n91aNlr9cCSHAfWqm+gAm7gR26lM7xiofjeUzycIk1G63LmrWXrafKAWG WoDw== X-Gm-Message-State: AAQBX9fatlCbF9nILjaJR3FgiOPHlL3Fxe4yGDLwpZFqUQgHHLAz7DA9 QqTEByBBwZHRd72Kc6WjQaY3XJM5zIGdl5lQO9MJUA== X-Google-Smtp-Source: AKy350bLXM1iysCDol/VAUBxZbdWNsWUekgKrBjhx1FHLZIm5wLO/EyiDgMXj5s262GeacHOp+oPA919pqPuO2gqhqY= X-Received: by 2002:a05:6e02:216b:b0:325:a6fe:11fc with SMTP id s11-20020a056e02216b00b00325a6fe11fcmr223040ilv.17.1680795305527; Thu, 06 Apr 2023 08:35:05 -0700 (PDT) MIME-Version: 1.0 References: <20230406144330.1932798-1-leitao@debian.org> In-Reply-To: <20230406144330.1932798-1-leitao@debian.org> From: Willem de Bruijn Date: Thu, 6 Apr 2023 11:34:28 -0400 Message-ID: Subject: Re: [PATCH 0/5] add initial io_uring_cmd support for sockets To: Breno Leitao Cc: io-uring@vger.kernel.org, netdev@vger.kernel.org, kuba@kernel.org, asml.silence@gmail.com, axboe@kernel.dk, leit@fb.com, edumazet@google.com, pabeni@redhat.com, davem@davemloft.net, dccp@vger.kernel.org, mptcp@lists.linux.dev, linux-kernel@vger.kernel.org, dsahern@kernel.org, willemdebruijn.kernel@gmail.com, matthieu.baerts@tessares.net, marcelo.leitner@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Thu, Apr 6, 2023 at 10:45=E2=80=AFAM Breno Leitao wr= ote: > > From: Breno Leitao > > This patchset creates the initial plumbing for a io_uring command for > sockets. > > For now, create two uring commands for sockets, SOCKET_URING_OP_SIOCOUTQ > and SOCKET_URING_OP_SIOCINQ. They are similar to ioctl operations > SIOCOUTQ and SIOCINQ. In fact, the code on the protocol side itself is > heavily based on the ioctl operations. This duplicates all the existing ioctl logic of each protocol. Can this just call the existing proto_ops.ioctl internally and translate fr= om/to io_uring format as needed?