public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH 1/1] io_uring: more graceful request alloc OOM
@ 2023-05-19 14:05 Pavel Begunkov
  2023-05-20  1:57 ` Jens Axboe
  2023-05-20  9:38 ` yang lan
  0 siblings, 2 replies; 7+ messages in thread
From: Pavel Begunkov @ 2023-05-19 14:05 UTC (permalink / raw)
  To: io-uring; +Cc: Jens Axboe, asml.silence, yang lan

It's ok for io_uring request allocation to fail, however there are
reports that it starts killing tasks instead of just returning back
to the userspace. Add __GFP_NORETRY, so it doesn't trigger OOM killer.

Cc: [email protected]
Fixes: 2b188cc1bb857 ("Add io_uring IO interface")
Reported-by: yang lan <[email protected]>
Signed-off-by: Pavel Begunkov <[email protected]>
---
 io_uring/io_uring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index dab09f568294..ad34a4320dab 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -1073,7 +1073,7 @@ static void io_flush_cached_locked_reqs(struct io_ring_ctx *ctx,
 __cold bool __io_alloc_req_refill(struct io_ring_ctx *ctx)
 	__must_hold(&ctx->uring_lock)
 {
-	gfp_t gfp = GFP_KERNEL | __GFP_NOWARN;
+	gfp_t gfp = GFP_KERNEL | __GFP_NOWARN | __GFP_NORETRY;
 	void *reqs[IO_REQ_ALLOC_BATCH];
 	int ret, i;
 
-- 
2.40.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-05-24  3:17 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-19 14:05 [PATCH 1/1] io_uring: more graceful request alloc OOM Pavel Begunkov
2023-05-20  1:57 ` Jens Axboe
2023-05-20  9:38 ` yang lan
2023-05-22  0:40   ` Pavel Begunkov
2023-05-22  7:55     ` yang lan
2023-05-23 12:08       ` Pavel Begunkov
2023-05-24  3:15         ` yang lan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox