public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Anuj gupta <anuj1072538@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Anuj Gupta <anuj20.g@samsung.com>,
	axboe@kernel.dk, hch@lst.de, kbusch@kernel.org,
	 martin.petersen@oracle.com, asml.silence@gmail.com,
	brauner@kernel.org,  jack@suse.cz, viro@zeniv.linux.org.uk,
	io-uring@vger.kernel.org,  linux-nvme@lists.infradead.org,
	linux-block@vger.kernel.org,  gost.dev@samsung.com,
	linux-scsi@vger.kernel.org, vishak.g@samsung.com,
	 linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v11 00/10] Read/Write with meta/integrity
Date: Wed, 4 Jun 2025 12:45:44 +0530	[thread overview]
Message-ID: <CACzX3As_FH1tMgZHMoCJMPhnuB__oh7KBzd9Z_JLtg2CLFZ4rA@mail.gmail.com> (raw)
In-Reply-To: <aD_qN7pDeYXz10NU@infradead.org>

> > Testing has been done by modifying fio:
> > https://github.com/SamsungDS/fio/tree/priv/feat/pi-test-v11
>
> It looks like this never got into upstream fio.  Do you plan to submit
> it?  It would also be extremely useful to have a testing using it in
> blktests, because it seems like we don't have any test coverage for the
> read/write with metadata code at the moment.
>
> Just bringing this up because I want to be able to properly test the
> metadata side of the nvme/block support for the new DMA mapping API
> and I'm ѕtruggling to come up with good test coverage.
>

Hi Christoph,

The fio plumbing I had done for testing was pretty hacky (e.g., using
NVMe ioctls directly to query PI capabilities), so I didn’t send it
upstream. I plan to submit a liburing test. While working on it, I
realized that writing generic userspace tests is tricky without a way to
query the device’s integrity capabilities. The current sysfs interface
is limited — it doesn't expose key fields like pi_size or metadata_size,
which are necessary to correctly prepare protection information in
userspace.

That’s what motivated the ioctl RFC I sent earlier — to make it feasible
for userspace to construct metadata buffers correctly. Once it gets
settled, I can write some tests using it. Do you see this differently?

  reply	other threads:[~2025-06-04  7:16 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20241128113036epcas5p397ba228852b72fff671fe695c322a3ef@epcas5p3.samsung.com>
2024-11-28 11:22 ` [PATCH v11 00/10] Read/Write with meta/integrity Anuj Gupta
     [not found]   ` <CGME20241128113056epcas5p2c9278736c88c646e6f3c7480ffb2211f@epcas5p2.samsung.com>
2024-11-28 11:22     ` [PATCH v11 01/10] block: define set of integrity flags to be inherited by cloned bip Anuj Gupta
     [not found]   ` <CGME20241128113058epcas5p1f544aa328a27b59f96b48b94dc0bdf94@epcas5p1.samsung.com>
2024-11-28 11:22     ` [PATCH v11 02/10] block: copy back bounce buffer to user-space correctly in case of split Anuj Gupta
     [not found]   ` <CGME20241128113101epcas5p3fefab67892c16c7bbaba8063c5c4a2c1@epcas5p3.samsung.com>
2024-11-28 11:22     ` [PATCH v11 03/10] block: modify bio_integrity_map_user to accept iov_iter as argument Anuj Gupta
     [not found]   ` <CGME20241128113104epcas5p4c4bd9f936403295e4cbac7c1f52d9b30@epcas5p4.samsung.com>
2024-11-28 11:22     ` [PATCH v11 04/10] fs, iov_iter: define meta io descriptor Anuj Gupta
     [not found]   ` <CGME20241128113106epcas5p1b5b06683bfa72225f3c1ab102b9f361c@epcas5p1.samsung.com>
2024-11-28 11:22     ` [PATCH v11 05/10] fs: introduce IOCB_HAS_METADATA for metadata Anuj Gupta
     [not found]   ` <CGME20241128113109epcas5p46022c85174da65853c85a8848b32f164@epcas5p4.samsung.com>
2024-11-28 11:22     ` [PATCH v11 06/10] io_uring: introduce attributes for read/write and PI support Anuj Gupta
2024-12-03  2:13       ` Martin K. Petersen
2024-12-03  6:56         ` Anuj Gupta
2024-12-03 12:00           ` Pavel Begunkov
2024-12-04  8:09             ` Anuj Gupta
2024-12-05 18:04       ` Keith Busch
2024-12-05 20:17         ` Martin K. Petersen
2024-12-06 12:07         ` Pavel Begunkov
     [not found]   ` <CGME20241128113112epcas5p186ef86baaa3054effb7244c54ee2f991@epcas5p1.samsung.com>
2024-11-28 11:22     ` [PATCH v11 07/10] block: introduce BIP_CHECK_GUARD/REFTAG/APPTAG bip_flags Anuj Gupta
2025-02-03  6:53       ` Christoph Hellwig
2025-02-03 14:39         ` Anuj Gupta
2025-02-04  5:39           ` Christoph Hellwig
2025-02-05 11:51             ` Anuj Gupta
2025-02-05 15:42               ` Christoph Hellwig
     [not found]   ` <CGME20241128113114epcas5p29c7e2a71a136cb50c636a9fe5d87bb0b@epcas5p2.samsung.com>
2024-11-28 11:22     ` [PATCH v11 08/10] nvme: add support for passing on the application tag Anuj Gupta
     [not found]   ` <CGME20241128113117epcas5p3b0387c302753c5424ba410f5b38ddeb9@epcas5p3.samsung.com>
2024-11-28 11:22     ` [PATCH v11 09/10] scsi: add support for user-meta interface Anuj Gupta
     [not found]   ` <CGME20241128113120epcas5p3bd415b5a09b3d5b793cbdda0b4102a62@epcas5p3.samsung.com>
2024-11-28 11:22     ` [PATCH v11 10/10] block: add support to pass user meta buffer Anuj Gupta
2024-11-29 16:04   ` [PATCH v11 00/10] Read/Write with meta/integrity Jens Axboe
2025-06-04  6:39   ` Christoph Hellwig
2025-06-04  7:15     ` Anuj gupta [this message]
2025-06-04  7:30       ` Christoph Hellwig
2025-06-04 19:53     ` Daniel Gomez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACzX3As_FH1tMgZHMoCJMPhnuB__oh7KBzd9Z_JLtg2CLFZ4rA@mail.gmail.com \
    --to=anuj1072538@gmail.com \
    --cc=anuj20.g@samsung.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=brauner@kernel.org \
    --cc=gost.dev@samsung.com \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=io-uring@vger.kernel.org \
    --cc=jack@suse.cz \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=vishak.g@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox