From: Anuj gupta <[email protected]>
To: Keith Busch <[email protected]>
Cc: [email protected], [email protected],
[email protected], [email protected], [email protected],
[email protected], [email protected],
Keith Busch <[email protected]>
Subject: Re: [PATCHv3 2/5] block: bio-integrity: directly map user buffers
Date: Tue, 21 Nov 2023 21:40:20 +0530 [thread overview]
Message-ID: <CACzX3AvO2GSvwagd=PkxsG3uiKgT4vpiMzYA1RJOjEMQD=yN6A@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
On Tue, Nov 21, 2023 at 4:11 AM Keith Busch <[email protected]> wrote:
>
> From: Keith Busch <[email protected]>
>
> Passthrough commands that utilize metadata currently bounce the user
> space buffer through the kernel. Add support for mapping user space
> directly so that we can avoid this costly overhead. This is similiar to
Nit: s/similiar/similar
> /**
> * bio_integrity_free - Free bio integrity payload
> * @bio: bio containing bip to be freed
> @@ -105,6 +136,8 @@ void bio_integrity_free(struct bio *bio)
>
> if (bip->bip_flags & BIP_BLOCK_INTEGRITY)
> kfree(bvec_virt(bip->bip_vec));
> + else if (bip->bip_flags & BIP_INTEGRITY_USER)
> + bio_integrity_unmap_user(bip);;
Nit: extra semicolon here
--
Anuj Gupta
next prev parent reply other threads:[~2023-11-21 16:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 22:40 [PATCHv3 0/5] block integrity: directly map user space addresses Keith Busch
2023-11-20 22:40 ` [PATCHv3 1/5] bvec: introduce multi-page bvec iterating Keith Busch
2023-11-21 5:01 ` Christoph Hellwig
2023-11-21 8:37 ` Ming Lei
2023-11-21 15:49 ` Keith Busch
2023-11-22 0:43 ` Ming Lei
2023-11-22 0:54 ` Keith Busch
2023-11-20 22:40 ` [PATCHv3 2/5] block: bio-integrity: directly map user buffers Keith Busch
2023-11-20 23:19 ` Jens Axboe
2023-11-21 5:04 ` Christoph Hellwig
2023-11-21 16:10 ` Anuj gupta [this message]
2023-11-20 22:40 ` [PATCHv3 3/5] nvme: use bio_integrity_map_user Keith Busch
2023-11-21 5:05 ` Christoph Hellwig
2023-11-20 22:40 ` [PATCHv3 4/5] iouring: remove IORING_URING_CMD_POLLED Keith Busch
2023-11-21 5:05 ` Christoph Hellwig
2023-11-20 22:40 ` [PATCHv3 5/5] io_uring: remove uring_cmd cookie Keith Busch
2023-11-21 5:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACzX3AvO2GSvwagd=PkxsG3uiKgT4vpiMzYA1RJOjEMQD=yN6A@mail.gmail.com' \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox