From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFA4B274B3C for ; Sun, 7 Dec 2025 08:42:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765096955; cv=none; b=ZAVXzfF+oKX2C1aj8dCXzNiTvIxj3kmlhyOU9+JCyb7xjMnFah/Ylr4LJVWUZeydT9lKVfn/R64KLn2nJ/cPhYvcG+yJWTFO/fJjysl0pUzHaOqTaFhpbXRxIMPP5vBX4lPIn97UQpe9uLFdeuZE4U5MJ8i+3yvRB1YzqxGEgn0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765096955; c=relaxed/simple; bh=WfWLzH+QtHiPwejFZ4ESmAPfSKspUK2Iblm8w5YiNzM=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=ISJmoJLxiHGBNMnmn62qkPTGpQC8s8MYn8nnk2CI5NYNT8QK+uStVmXye5mQ5JDVKfBYIokE6Rv29RoYU3Ll7UaUErTXwZUG/nHwwCRbRJSGPWvGuldcFpEamI/0BcKLt0Hiz8GEM8EZa5MmakYze91gm2ipG+IJF6h5UzSp8rs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=LqiyTnsA; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="LqiyTnsA" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-295351ad2f5so6485105ad.3 for ; Sun, 07 Dec 2025 00:42:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1765096953; x=1765701753; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zn0TCrqxsSAmiJy2pjhuWlPB88FPESlPZveON9orP+Q=; b=LqiyTnsAL0tDy2sdgewOCEL8+dsEXsIKOh+mO0lZ+etIv/UC2CJnzGKmSQVqmpwmIS uszny5RUynqJZgxm+7GxaZNqS1mCCQTuH51N0aC295RJE3C1rstJMS/+dU3zRGQJ+ROC Zspp0/b0bRtd0bXg7TxbBJOUdxJTLsZ056yTIszteOo5hXGJib8weGcFAqvEmjXQwe05 6Ce4O/rP3funjbdmzwAuGFl6sQQz3vfycKDhVvcgF+eCkDSiy6XXl08/AtFSyORG9pyZ n82j0IHk8nFUPmQeZEfGz6oxVo2J84CaEPqeFTR8sZ0icnKLhP9FN1v9QJO/nnx3VP/a FvQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765096953; x=1765701753; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zn0TCrqxsSAmiJy2pjhuWlPB88FPESlPZveON9orP+Q=; b=vkdR2o8qYad105YodZINGJa1wewd3W4UZQRDNlwJHMQ7qzYDz11VvhB/ztnSAQXMX8 XapKxP05sve91F642DH8GgLyuBuDMiMZyIe/gKluYz4meG4AJK3WXrNb10aIcXu7sJou xsZDujwZaABfInbzI8JvJ9heesUDDMpQBp7bmFGhEkAuhiyrzftvDS43kcXX78xbWX3t pvQ4R9cIJr4a8htOQvxzOuhWjE8yY1nByvvFs/xmX0VIKEqM/0JTy7bK9JR9WdbASFcI uaKdbCIq1MVCnNeBxUi3SdNKG9e44/g3NbUWisuuMq3wIZ8gmpPRt+xHFbvVScuFRL/f Yb4g== X-Forwarded-Encrypted: i=1; AJvYcCVFhwqUvngECicSSTl8/VpFPhabzc4hSXFi9P8gLm6J+v4sAJPF0yg9lR5M7/RfjAsx/8c8GeUJlQ==@vger.kernel.org X-Gm-Message-State: AOJu0YzB0kLA4baOY/ORPfsoFz/5uKkUfq7EPmUj0uFARtKp6OrLh+YG k/iutgM0GHJhifsEPNsaTka/xJ8TWfbGNM9jTZ6gQtdpw/gbUTKxGIAKs88ErYjI/W29JLClBgr BpjEQDCmP2wZoQyRzZPWiALj5SOXFoj+vMLjPHpJF8g== X-Gm-Gg: ASbGnctqGU320MoqEdgYZYYBFZQq2SWILAVfBT7lKO0VgYAPIw96SfBbXbVu/U8W4hX 4D6oNMOlA+Vus+E+QYyMwnTCDpZ5QlivvLaSeaaGpiykF7WTh3+UzVxCX96jeNaNTf2RvujSA67 Se/EOW+X6gIKgiS4gn0eN/wPa1y4R2ZEMRjPMNP5VHL2fcIDlqbFefC+LUUcS3CaHedC7Deaq9j 79r5gPKtzRZtOr1z8LPjlJLCFdRs2KXDhzvKewZpT+iNAQ3GazYmeI3o7EfrkzwNJGQXw34 X-Google-Smtp-Source: AGHT+IHUT+y6UkGiP9rKvffnCpnc8EeoQi7nHIUcEb/aXf01i65WD400NIIsftq5ucQhbMakatsmyVJ8Hr4ePdfh0Ck= X-Received: by 2002:a05:7022:49f:b0:11e:3e9:3ea5 with SMTP id a92af1059eb24-11e03e9447cmr1848664c88.7.1765096953051; Sun, 07 Dec 2025 00:42:33 -0800 (PST) Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251203003526.2889477-1-joannelkoong@gmail.com> <20251203003526.2889477-25-joannelkoong@gmail.com> In-Reply-To: <20251203003526.2889477-25-joannelkoong@gmail.com> From: Caleb Sander Mateos Date: Sun, 7 Dec 2025 00:42:21 -0800 X-Gm-Features: AQt7F2pc21BBeN2HWbX86e7phYaZSB8x1ZZ_Ee_93JIbwmjcqTTombdxWHZe-j8 Message-ID: Subject: Re: [PATCH v1 24/30] io_uring/rsrc: Allow buffer release callback to be optional To: Joanne Koong Cc: miklos@szeredi.hu, axboe@kernel.dk, bschubert@ddn.com, asml.silence@gmail.com, io-uring@vger.kernel.org, xiaobing.li@samsung.com, linux-fsdevel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Dec 2, 2025 at 4:37=E2=80=AFPM Joanne Koong wrote: > > This is a preparatory patch for supporting kernel-populated buffers in > fuse io-uring, which does not need a release callback. > > Signed-off-by: Joanne Koong Reviewed-by: Caleb Sander Mateos > --- > io_uring/rsrc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c > index 18abba6f6b86..a5605c35d857 100644 > --- a/io_uring/rsrc.c > +++ b/io_uring/rsrc.c > @@ -149,7 +149,8 @@ static void io_buffer_unmap(struct io_ring_ctx *ctx, = struct io_mapped_ubuf *imu) > > if (imu->acct_pages) > io_unaccount_mem(ctx->user, ctx->mm_account, imu->acct_pa= ges); > - imu->release(imu->priv); > + if (imu->release) > + imu->release(imu->priv); > io_free_imu(ctx, imu); > } > > -- > 2.47.3 >