public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Caleb Sander Mateos <csander@purestorage.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
	Sagi Grimberg <sagi@grimberg.me>,
	 io-uring@vger.kernel.org, linux-nvme@lists.infradead.org,
	 linux-kernel@vger.kernel.org, Anuj Gupta <anuj20.g@samsung.com>,
	 Kanchan Joshi <joshi.k@samsung.com>,
	Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH v5 0/5] io_uring/uring_cmd: allow non-iopoll cmds with IORING_SETUP_IOPOLL
Date: Tue, 17 Mar 2026 17:47:08 -0700	[thread overview]
Message-ID: <CADUfDZp-Fq4TAdOcvjwSO4G3sZzekzVsyT_yMsoC9D-2=5aLyw@mail.gmail.com> (raw)
In-Reply-To: <307e4126-91ed-4ca8-9eb0-3f24f1490aa8@kernel.dk>

On Mon, Mar 16, 2026 at 6:01 PM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 3/16/26 4:14 PM, Jens Axboe wrote:
> >
> > On Mon, 02 Mar 2026 10:29:09 -0700, Caleb Sander Mateos wrote:
> >> Currently, creating an io_uring with IORING_SETUP_IOPOLL requires all
> >> requests issued to it to support iopoll. This prevents, for example,
> >> using ublk zero-copy together with IORING_SETUP_IOPOLL, as ublk
> >> zero-copy buffer registrations are performed using a uring_cmd. There's
> >> no technical reason why these non-iopoll uring_cmds can't be supported.
> >> They will either complete synchronously or via an external mechanism
> >> that calls io_uring_cmd_done(), io_uring_cmd_post_mshot_cqe32(), or
> >> io_uring_mshot_cmd_post_cqe(), so they don't need to be polled.
> >>
> >> [...]
> >
> > Applied, thanks!
> >
> > [1/5] io_uring: add REQ_F_IOPOLL
> >       commit: 9165dc4fa969b64c2d4396ee4e1546a719978dd1
> > [2/5] io_uring: remove iopoll_queue from struct io_issue_def
> >       commit: 7995be40deb3ab8b5df7bdf0621f33aa546aefa7
> > [3/5] io_uring: count CQEs in io_iopoll_check()
> >       commit: 3a5e96d47f7ea37fb6adf37882eec1521f8ca75e
> > [4/5] io_uring/uring_cmd: allow non-iopoll cmds with IORING_SETUP_IOPOLL
> >       commit: 23475637b0c47e5028817c9fd4dabe8f7409ca6c
> > [5/5] nvme: remove nvme_dev_uring_cmd() IO_URING_F_IOPOLL check
> >       commit: f144dbac4b177cfd026e417ab98da518ff3372cb
>
> Caleb, want to send the liburing tests and documentation updates too?

Sure. What type of file do you recommend using for non-iopoll
uring_cmds? Most of them seem to have relatively specific hardware
(e.g. blkdev_uring_cmd, nvme_dev_uring_cmd) or kernel configuration
(e.g. ublk_ch_uring_cmd, io_mock_cmd) requirements, as well as
requiring elevated permissions. Maybe io_uring_cmd_sock would be the
most general?

Best,
Caleb

  reply	other threads:[~2026-03-18  0:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 17:29 [PATCH v5 0/5] io_uring/uring_cmd: allow non-iopoll cmds with IORING_SETUP_IOPOLL Caleb Sander Mateos
2026-03-02 17:29 ` [PATCH v5 1/5] io_uring: add REQ_F_IOPOLL Caleb Sander Mateos
2026-03-02 17:29 ` [PATCH v5 2/5] io_uring: remove iopoll_queue from struct io_issue_def Caleb Sander Mateos
2026-03-02 17:29 ` [PATCH v5 3/5] io_uring: count CQEs in io_iopoll_check() Caleb Sander Mateos
2026-03-04 10:32   ` Ming Lei
2026-03-04 15:46     ` Caleb Sander Mateos
2026-03-04 16:29       ` Jens Axboe
2026-03-07  1:38         ` Caleb Sander Mateos
2026-03-07  2:35           ` Ming Lei
2026-03-16 22:11             ` Jens Axboe
2026-03-16 23:39               ` Caleb Sander Mateos
2026-03-02 17:29 ` [PATCH v5 4/5] io_uring/uring_cmd: allow non-iopoll cmds with IORING_SETUP_IOPOLL Caleb Sander Mateos
2026-03-02 17:29 ` [PATCH v5 5/5] nvme: remove nvme_dev_uring_cmd() IO_URING_F_IOPOLL check Caleb Sander Mateos
2026-03-16 22:14 ` [PATCH v5 0/5] io_uring/uring_cmd: allow non-iopoll cmds with IORING_SETUP_IOPOLL Jens Axboe
2026-03-17  1:01   ` Jens Axboe
2026-03-18  0:47     ` Caleb Sander Mateos [this message]
2026-03-18  1:26       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADUfDZp-Fq4TAdOcvjwSO4G3sZzekzVsyT_yMsoC9D-2=5aLyw@mail.gmail.com' \
    --to=csander@purestorage.com \
    --cc=anuj20.g@samsung.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=io-uring@vger.kernel.org \
    --cc=joshi.k@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=ming.lei@redhat.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox