From: Caleb Sander Mateos <csander@purestorage.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: io-uring@vger.kernel.org, asml.silence@gmail.com
Subject: Re: [PATCH 4/5] io_uring: pass in struct io_big_cqe to io_alloc_ocqe()
Date: Fri, 16 May 2025 16:10:18 -0700 [thread overview]
Message-ID: <CADUfDZpLi-YWhnzUntychzMYeLZCMGrrLMKXHRq2Hzk+jZX-FA@mail.gmail.com> (raw)
In-Reply-To: <20250516201007.482667-5-axboe@kernel.dk>
On Fri, May 16, 2025 at 1:10 PM Jens Axboe <axboe@kernel.dk> wrote:
>
> Rather than pass extra1/extra2 separately, just pass in the (now) named
> io_big_cqe struct instead. The callers that don't use/support CQE32 will
> now just pass a single NULL, rather than two seperate mystery zero
> values.
>
> Move the clearing of the big_cqe elements into io_alloc_ocqe() as well,
> so it can get moved out of the generic code.
>
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Reviewed-by: Caleb Sander Mateos <csander@purestorage.com>
next prev parent reply other threads:[~2025-05-16 23:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 20:05 [PATCHSET v3 0/5] Allow non-atomic allocs for overflows Jens Axboe
2025-05-16 20:05 ` [PATCH 1/5] io_uring: open code io_req_cqe_overflow() Jens Axboe
2025-05-16 20:05 ` [PATCH 2/5] io_uring: split alloc and add of overflow Jens Axboe
2025-05-16 23:00 ` Caleb Sander Mateos
2025-05-16 20:05 ` [PATCH 3/5] io_uring: make io_alloc_ocqe() take a struct io_cqe pointer Jens Axboe
2025-05-16 23:07 ` Caleb Sander Mateos
2025-05-16 23:08 ` Caleb Sander Mateos
2025-05-16 23:48 ` Jens Axboe
2025-05-16 20:05 ` [PATCH 4/5] io_uring: pass in struct io_big_cqe to io_alloc_ocqe() Jens Axboe
2025-05-16 23:10 ` Caleb Sander Mateos [this message]
2025-05-16 20:05 ` [PATCH 5/5] io_uring: add new helpers for posting overflows Jens Axboe
2025-05-16 23:17 ` Caleb Sander Mateos
2025-05-16 23:49 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2025-05-17 11:42 [PATCHSET v4 0/5] Allow non-atomic allocs for overflows Jens Axboe
2025-05-17 11:42 ` [PATCH 4/5] io_uring: pass in struct io_big_cqe to io_alloc_ocqe() Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADUfDZpLi-YWhnzUntychzMYeLZCMGrrLMKXHRq2Hzk+jZX-FA@mail.gmail.com \
--to=csander@purestorage.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox