From: Caleb Sander Mateos <csander@purestorage.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: io-uring@vger.kernel.org, asml.silence@gmail.com
Subject: Re: [PATCH 5/5] io_uring: add new helpers for posting overflows
Date: Sat, 17 May 2025 16:32:08 -0700 [thread overview]
Message-ID: <CADUfDZpxAgzGDSPpUcEvrtTPuRYPk0uqhnsDt0B4D5mFgsHFkQ@mail.gmail.com> (raw)
In-Reply-To: <20250517114938.533378-6-axboe@kernel.dk>
On Sat, May 17, 2025 at 4:49 AM Jens Axboe <axboe@kernel.dk> wrote:
>
> Add two helpers, one for posting overflows for lockless_cq rings, and
> one for non-lockless_cq rings. The former can allocate sanely with
> GFP_KERNEL, but needs to grab the completion lock for posting, while the
> latter must do non-sleeping allocs as it already holds the completion
> lock.
>
> While at it, mark the overflow handling functions as __cold as well, as
> they should not generally be called during normal operations of the
> ring.
>
> Reviewed-by: Caleb Sander Mateos <csander@purestorage.com>
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Looks good, thanks!
Caleb
next prev parent reply other threads:[~2025-05-17 23:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-17 11:42 [PATCHSET v4 0/5] Allow non-atomic allocs for overflows Jens Axboe
2025-05-17 11:42 ` [PATCH 1/5] io_uring: open code io_req_cqe_overflow() Jens Axboe
2025-05-17 11:42 ` [PATCH 2/5] io_uring: split alloc and add of overflow Jens Axboe
2025-05-17 23:30 ` Caleb Sander Mateos
2025-05-18 0:48 ` Jens Axboe
2025-05-17 11:42 ` [PATCH 3/5] io_uring: make io_alloc_ocqe() take a struct io_cqe pointer Jens Axboe
2025-05-17 23:28 ` Caleb Sander Mateos
2025-05-17 11:42 ` [PATCH 4/5] io_uring: pass in struct io_big_cqe to io_alloc_ocqe() Jens Axboe
2025-05-17 11:42 ` [PATCH 5/5] io_uring: add new helpers for posting overflows Jens Axboe
2025-05-17 23:32 ` Caleb Sander Mateos [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-05-16 20:05 [PATCHSET v3 0/5] Allow non-atomic allocs for overflows Jens Axboe
2025-05-16 20:05 ` [PATCH 5/5] io_uring: add new helpers for posting overflows Jens Axboe
2025-05-16 23:17 ` Caleb Sander Mateos
2025-05-16 23:49 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADUfDZpxAgzGDSPpUcEvrtTPuRYPk0uqhnsDt0B4D5mFgsHFkQ@mail.gmail.com \
--to=csander@purestorage.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox