Re: [PATCH 1/2] io_uring/rsrc: declare io_find_buf_node() in header file

[Caleb Sander Mateos <csander@purestorage.com>]

On Fri, Feb 28, 2025 at 5:45 PM Pavel Begunkov <asml.silence@gmail.com> wrote:
>
> On 3/1/25 00:16, Caleb Sander Mateos wrote:
> > Declare io_find_buf_node() in io_uring/rsrc.h so it can be called from
> > other files.
> >
> > Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
> > ---
> >   io_uring/rsrc.c | 4 ++--
> >   io_uring/rsrc.h | 2 ++
> >   2 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c
> > index 45bfb37bca1e..4c4f57cd77f9 100644
> > --- a/io_uring/rsrc.c
> > +++ b/io_uring/rsrc.c
> > @@ -1066,12 +1066,12 @@ static int io_import_fixed(int ddir, struct iov_iter *iter,
> >       }
> >
> >       return 0;
> >   }
> >
> > -static inline struct io_rsrc_node *io_find_buf_node(struct io_kiocb *req,
> > -                                                 unsigned issue_flags)
>
> That's a hot path, an extra function call wouldn't be great,
> and it's an internal detail as well. Let's better see what we
> can do with the nop situation.

I can add back inline. With that, there shouldn't be any difference to
the generated instructions for io_import_reg_buf().

>
> btw, don't forget cover letters for series.

Okay, I didn't have much else to add to the brief commit messages. But
sure, I'll add a cover letter in the future.

Best,
Caleb