From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AC8A264624 for ; Mon, 24 Feb 2025 17:53:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740419628; cv=none; b=Tgj2mcPFWakASwA0iJV4hkKQ5HwsOn95VJZtzgpXUt5AA31PcMu6SjgXwg0V+hB7WgoMHUenHnHvmQB2CEVyX/Jrds/HXF0PmKCKIJIff4LTaq1fQgNGUSebCO1IGRGGgzkmiY4jQWlWQNyegwLwJRFOQFbQYqKPCDYxghr20ik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740419628; c=relaxed/simple; bh=TJOZAeIIJjbAum7vKPxxSUEgL+PtYhuuKao3f1L0n1w=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=BvmX+TNHkgkE049sTC6zZdiLfCiSWlTsUm4Cukcbbwm18cQAJe3nPIdSeN4k5eOiidwoiTTAubq21IvluHGB6ySmwyhjsYV/VO7gHnOdm2/P6jKYl/MawJRRWymNIR87Bb0Xp3IVh7OJtmtfOKw/GFX+y07/X66I6tudNjZLafI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=HHEU1r1x; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="HHEU1r1x" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-220d27fcdaaso9814805ad.0 for ; Mon, 24 Feb 2025 09:53:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1740419624; x=1741024424; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TJOZAeIIJjbAum7vKPxxSUEgL+PtYhuuKao3f1L0n1w=; b=HHEU1r1xYZyGse+hRh6l8mD+rHhmHd2yf1+BobGqZvaNHSQsOeQ0C7XC1WTUjjqGQc PUyvc3ekQ0sw2PpXrHQfAhYM7my1h8l/edTEqYPQwl4L5o6DGpfECeGtt6MvaYuesgqL 4YJ5rFK7awO0CUEkbrACDaiAuRzrNZyqGZR1jkIiOCjZXLQabxuAT25VKiegQHc6vukL K0REQyckzVbKzhhAT3aFJpWMzUvTOVBG4gft148c9CY4ANTBQxAKZ/Hcu0xg0PfxpWQ1 +sy7AADJnWKutKenjokbYD/CO1bzc3nyMyGt2Gf2N3ElYJYyQmTuVawi/8A1qwcVPUAN uRUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740419624; x=1741024424; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TJOZAeIIJjbAum7vKPxxSUEgL+PtYhuuKao3f1L0n1w=; b=YJvWMyQM+qMNmKsEfdkSTY1eCf347nXBWun0Uby6TwhV87NOq7E4qbcFsYku5ehrTq io3eI+/czHWaX/3tuTGGmJ5O2JPEc5fhu2f9YukhG+5hKZlWYKGovFdPyYZVRD6XNADn 4PQpukEo8CbRU/oFFpt+fSZDFeASsmsDSms/jlGasYRCOglZOYbwczZZDNwHfOSRblOj 2Vn6bYXIlmEYXBZZN/a/NxeSyyZ46G1DaO2m1LFq1hHG9o0sYyIxnwLweDDgfNE9cZ4a ZOYmJNElij+HlIsHyHk3iexTyGHRNCzKHtIvAqqMzyZipIw/Vkk1VCFc+70OLwUvDSBd 6/jA== X-Forwarded-Encrypted: i=1; AJvYcCUMnpmMBv1lYaSmR+GJBUE/Zw4sUuBMqGDDdu9t1tvbmegnDq1ac+gzqhJV987L+RO866LhO7dGwg==@vger.kernel.org X-Gm-Message-State: AOJu0YyqNSwIhXVHYFpi+TE1D3yuk4LvvbaFMx7n7wrOi0tJdx+fJEDb 6AHXzeVZPYX0bmgvecwNPYo2d4+SYF+vI2NOk/TZoOaal+gJWq6W+PWooVirLMtYwDw7e3WNWni 2YIR+prwvPfPkWUH3vHdxyXAT5WJgmq5LV3+puKCTeAqp91Q17x8= X-Gm-Gg: ASbGnctPscuMuURO/gUlCkDqshsWwEZhkKuzATmuBJcLpmInLs8MQVkACuLNRHi7Ntk VYi5LiBpv6dYfofsv9b/Jz+MsozBP373UgBvOnNDel7q3vqpS956OtJcuDCWQwyrwcJ/6u0F+1g lxGK/bTzs= X-Google-Smtp-Source: AGHT+IEmKSr9StH1o6AjwBks6b3kLW4tgV8ow5+DNqt2NPti+5RsJWBpzngd6Sal7T/kd3TjhPM6F1HxVfZa0gJCX00= X-Received: by 2002:a17:902:ec8d:b0:215:435d:b41a with SMTP id d9443c01a7336-2219ff31246mr85389055ad.1.1740419624625; Mon, 24 Feb 2025 09:53:44 -0800 (PST) Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250224172337.2009871-1-csander@purestorage.com> In-Reply-To: From: Caleb Sander Mateos Date: Mon, 24 Feb 2025 09:53:32 -0800 X-Gm-Features: AWEUYZlZV4sj4ZGftiGUyWKPl8ccOi3mmENvFBBeSC3j4cgo_ltS-EW9ZaRDYOk Message-ID: Subject: Re: [PATCH] io_uring/waitid: remove #ifdef CONFIG_COMPAT To: Jens Axboe Cc: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Feb 24, 2025 at 9:44=E2=80=AFAM Jens Axboe wrote: > > On 2/24/25 10:23 AM, Caleb Sander Mateos wrote: > > io_is_compat() is already defined to return false if CONFIG_COMPAT is > > disabled. So remove the additional #ifdef CONFIG_COMPAT guards. Let the > > compiler optimize out the dead code when CONFIG_COMPAT is disabled. > > Would you mind if I fold this into Pavel's patch? I can keep it > standalone too, just let me know. Fine by me, though I thought Pavel was suggesting keeping it separate: https://lore.kernel.org/io-uring/da109d01-7aab-4205-bbb1-f5f1387f1847@gmail= .com/T/#u Thanks, Caleb