public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jann Horn <[email protected]>
To: Kent Overstreet <[email protected]>,
	[email protected]
Cc: kernel list <[email protected]>,
	Jens Axboe <[email protected]>,
	 Pavel Begunkov <[email protected]>,
	io-uring <[email protected]>
Subject: bcachefs: suspicious mm pointer in struct dio_write
Date: Wed, 27 Nov 2024 17:57:03 +0100	[thread overview]
Message-ID: <CAG48ez21ZtMJ6gcUND6bLV6XD6b--CXmKSRjKq+D33jhRh1LPw@mail.gmail.com> (raw)

Hi!

In fs/bcachefs/fs-io-direct.c, "struct dio_write" contains a pointer
to an mm_struct. This pointer is grabbed in bch2_direct_write()
(without any kind of refcount increment), and used in
bch2_dio_write_continue() for kthread_use_mm()/kthread_unuse_mm()
which are used to enable userspace memory access from kthread context.
I believe kthread_use_mm()/kthread_unuse_mm() require that the caller
guarantees that the MM hasn't gone through exit_mmap() yet (normally
by holding an mmget() reference).

If we reach this codepath via io_uring, do we have a guarantee that
the mm_struct that called bch2_direct_write() is still alive and
hasn't yet gone through exit_mmap() when it is accessed from
bch2_dio_write_continue()?

I don't know the async direct I/O codepath particularly well, so I
cc'ed the uring maintainers, who probably know this better than me.

             reply	other threads:[~2024-11-27 16:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-27 16:57 Jann Horn [this message]
2024-11-27 18:09 ` bcachefs: suspicious mm pointer in struct dio_write Jens Axboe
2024-11-27 19:43   ` Jann Horn
2024-11-27 20:01     ` Jens Axboe
2024-11-27 20:31       ` Kent Overstreet
2024-11-27 20:25   ` Kent Overstreet
2024-11-27 20:44     ` Jann Horn
2024-11-27 21:08       ` Kent Overstreet
2024-11-27 21:16         ` Jens Axboe
2024-11-27 21:27           ` Kent Overstreet
2024-11-27 21:51             ` Jens Axboe
2024-11-27 21:58               ` Kent Overstreet
2024-11-27 21:59                 ` Jens Axboe
2024-11-27 21:39           ` Jann Horn
2024-11-27 21:52             ` Jens Axboe
2024-11-27 21:53               ` Jann Horn
2024-11-27 20:23 ` Kent Overstreet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAG48ez21ZtMJ6gcUND6bLV6XD6b--CXmKSRjKq+D33jhRh1LPw@mail.gmail.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox