From: Jann Horn <[email protected]>
To: Jens Axboe <[email protected]>
Cc: Clay Harris <[email protected]>, io-uring <[email protected]>
Subject: Re: IORING_OP_CLOSE fails on fd opened with O_PATH
Date: Tue, 2 Jun 2020 21:16:18 +0200 [thread overview]
Message-ID: <CAG48ez3x+d1acZEQv_rouXeMq3+qWsGpntXum=iv6FMZ9ch6Jw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
On Tue, Jun 2, 2020 at 8:42 PM Jens Axboe <[email protected]> wrote:
> On 6/2/20 12:22 PM, Jann Horn wrote:
> > On Sun, May 31, 2020 at 10:19 PM Jens Axboe <[email protected]> wrote:
> >> We just need this ported to stable once it goes into 5.8-rc:
> >>
> >> https://git.kernel.dk/cgit/linux-block/commit/?h=for-5.8/io_uring&id=904fbcb115c85090484dfdffaf7f461d96fe8e53
> >
> > How does that work? Who guarantees that the close operation can't drop
> > the refcount of the uring instance to zero before reaching the fdput()
> > in io_uring_enter?
>
> Because io_uring_enter() holds a reference to it as well?
Which reference do you mean? fdget() doesn't take a reference if the
calling process is single-threaded, you'd have to use fget() for that.
next prev parent reply other threads:[~2020-06-02 19:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 12:47 IORING_OP_CLOSE fails on fd opened with O_PATH Clay Harris
2020-05-31 14:46 ` Jens Axboe
2020-05-31 20:19 ` Jens Axboe
2020-06-02 18:22 ` Jann Horn
2020-06-02 18:42 ` Jens Axboe
2020-06-02 19:16 ` Jann Horn [this message]
2020-06-02 21:39 ` Jens Axboe
2020-06-08 11:21 ` Clay Harris
2020-06-08 20:19 ` Jens Axboe
2020-06-09 1:40 ` Clay Harris
2020-06-09 2:14 ` Jens Axboe
2020-06-09 5:16 ` Clay Harris
2020-06-10 1:52 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG48ez3x+d1acZEQv_rouXeMq3+qWsGpntXum=iv6FMZ9ch6Jw@mail.gmail.com' \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox