From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87D15C7EE23 for ; Wed, 10 May 2023 12:08:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236747AbjEJMIn (ORCPT ); Wed, 10 May 2023 08:08:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236792AbjEJMIm (ORCPT ); Wed, 10 May 2023 08:08:42 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6D5D7D85 for ; Wed, 10 May 2023 05:07:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683720474; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mBHRFYfYRKquYIG9IbgfFHCMnVDomaQ80tiU2jYECfk=; b=hIcAHqV70db6RdTE2LLfehED66qHhJ4bu5pA+P2KT/4czgn/fAzQBmvdD+AcfBB/WkfhxN mv2/bnrMOXyO0B5i+9vJB7fewYLyjo39ZGKf2/5pRN+ydI0aG8MfmlnsvXrehp245oGbu6 rTNsk4/X6aPqaRPInvSjj32D9fu2sYA= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-660-r4R1XbvFMXSd8aOMdcyahA-1; Wed, 10 May 2023 08:07:53 -0400 X-MC-Unique: r4R1XbvFMXSd8aOMdcyahA-1 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-645538f6101so20527503b3a.1 for ; Wed, 10 May 2023 05:07:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683720472; x=1686312472; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mBHRFYfYRKquYIG9IbgfFHCMnVDomaQ80tiU2jYECfk=; b=R5LnyWiPyiwzNd+uMEVUQJjir/cBDJyed5M1hwJRvaq+aUERUah4ZuDTSK/GZ7mP15 m5w+M2LUJh3Cc76iGLLNfT7FoUBaj8m6f4I42EhtTNrkWUkhNKXeVqbMdE6Gq/NCQXZS pOiwMkGxi0cqXS1bc32tXKaUZJOAEGEED2p6fi9S0jROTAqmg90csn+SSNz0vhJ5cU6Z bbsEFHKxx4nAxLaxX+9Vx8Z2AdaUyyECg5ChMD7Jr5wUfY4mtT0k6zxOsr1A13Khdq0/ k/T0Mx9mV+2KYFJ1APrDZxGRww/6o//g+uImKQvOTKzgzuvqKLiakhLr9dCaspOWMFTR i1Hg== X-Gm-Message-State: AC+VfDzaVIorBGI2X8dMFrt7APWoG7TvLPNjtbQGcxlahoYg/NLkEWh1 e9uUYIpkSU+kF9dJwZTaQtP9POwR9UAg+xdfzD66q2jqh7qKpioyoLzA1zhgEH+q2CWFr5RtZ2Q +FYql7/RTY3MqmFa6AscS8IhubexMRtlowMk= X-Received: by 2002:a17:90a:ad09:b0:244:d441:8f68 with SMTP id r9-20020a17090aad0900b00244d4418f68mr25722217pjq.16.1683720472467; Wed, 10 May 2023 05:07:52 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7ZiAfNVnQO0UPQ3VAy4kjRuo5FB9+xdUBrPgacbACuNg4amS2P3Jdczy0yCDToSd5CBd6yB5vipAn175sY1M0= X-Received: by 2002:a17:90a:ad09:b0:244:d441:8f68 with SMTP id r9-20020a17090aad0900b00244d4418f68mr25722188pjq.16.1683720472159; Wed, 10 May 2023 05:07:52 -0700 (PDT) MIME-Version: 1.0 References: <007af59f-4f4c-f779-a1b6-aaa81ff640b3@huaweicloud.com> <1155743b-2073-b778-1ec5-906300e0570a@kernel.dk> <7def2fca-c854-f88e-3a77-98a999f7b120@huaweicloud.com> In-Reply-To: From: Guangwu Zhang Date: Wed, 10 May 2023 20:08:57 +0800 Message-ID: Subject: Re: [bug report] BUG: kernel NULL pointer dereference, address: 0000000000000048 To: Ming Lei Cc: Yu Kuai , Jens Axboe , linux-block@vger.kernel.org, io-uring@vger.kernel.org, Jeff Moyer , Jan Kara , Paolo Valente , "yukuai (C)" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Hi, Don't hit the issue after apply your patch. thanks Ming Lei =E4=BA=8E2023=E5=B9=B45=E6=9C=8810=E6=97=A5= =E5=91=A8=E4=B8=89 14:39=E5=86=99=E9=81=93=EF=BC=9A > > On Wed, May 10, 2023 at 12:05:07PM +0800, Guangwu Zhang wrote: > > HI, > > after apply your patch[1], the system will panic after reboot. > > > > Maybe you can try the following patch? > > diff --git a/block/blk-mq.c b/block/blk-mq.c > index f6dad0886a2f..d84174a7e997 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -1303,7 +1303,7 @@ void blk_execute_rq_nowait(struct request *rq, bool= at_head) > * device, directly accessing the plug instead of using blk_mq_pl= ug() > * should not have any consequences. > */ > - if (current->plug && !at_head) { > + if (current->plug && !at_head && rq->bio) { > blk_add_rq_to_plug(current->plug, rq); > return; > } > > > thanks, > Ming > --=20 Guangwu Zhang, RHCE, ISTQB, ITIL Quality Engineer, Kernel Storage QE Red Hat