public inbox for [email protected]
 help / color / mirror / Atom feed
From: Ammar Faizi <[email protected]>
To: Jens Axboe <[email protected]>
Cc: Pavel Begunkov <[email protected]>,
	io-uring Mailing List <[email protected]>,
	Bedirhan KURT <[email protected]>
Subject: Re: [PATCH v6 liburing] test: Add kworker-hang test
Date: Tue, 9 Nov 2021 12:44:53 +0700	[thread overview]
Message-ID: <CAGzmLMWsFYe3VJLonr7dc6Z3qe7YoB8b1meX6hyiHQdacpzBtw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>

On Sat, Nov 6, 2021 at 6:49 PM Ammar Faizi wrote:
>
> This is the reproducer for the kworker hang bug.
>
> Reproduction Steps:
>   1) A user task calls io_uring_queue_exit().
>
>   2) Suspend the task with SIGSTOP / SIGTRAP before the ring exit is
>      finished (do it as soon as step (1) is done).
>
>   3) Wait for `/proc/sys/kernel/hung_task_timeout_secs` seconds
>      elapsed.
>
>   4) We get a complaint from the khungtaskd because the kworker is
>      stuck in an uninterruptible state (D).
>
> The kworkers waiting on ring exit are not progressing as the task
> cannot proceed. When the user task is continued (e.g. get SIGCONT
> after SIGSTOP, or continue after SIGTRAP breakpoint), the kworkers
> then can finish the ring exit.
>
> We need a special handling for this case to avoid khungtaskd
> complaint. Currently we don't have the fix for this.
[...]
> Cc: Pavel Begunkov <[email protected]>
> Link: https://github.com/axboe/liburing/issues/448
> Signed-off-by: Ammar Faizi <[email protected]>
> ---
>
>  v6:
>    - Fix missing call to restore_hung_entries() when fork() fails.
>
>  .gitignore          |   1 +
>  test/Makefile       |   1 +
>  test/kworker-hang.c | 323 ++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 325 insertions(+)
>  create mode 100644 test/kworker-hang.c

It's ready for review.

-- 
Ammar Faizi

  reply	other threads:[~2021-11-09  5:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19 19:07 [PATCH liburing] test: Add kworker-hang test Ammar Faizi
2021-10-20 12:51 ` [PATCH v2 " Ammar Faizi
2021-11-05 23:35   ` Ammar Faizi
2021-11-05 23:41     ` Jens Axboe
2021-11-06  0:58       ` [PATCH v3 " Ammar Faizi
2021-11-06  7:42         ` [PATCH v4 " Ammar Faizi
2021-11-06 11:37           ` [PATCH v5 " Ammar Faizi
2021-11-06 11:49             ` [PATCH v6 " Ammar Faizi
2021-11-09  5:44               ` Ammar Faizi [this message]
2021-11-09 14:47                 ` Jens Axboe
2021-11-09 15:21                   ` Ammar Faizi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGzmLMWsFYe3VJLonr7dc6Z3qe7YoB8b1meX6hyiHQdacpzBtw@mail.gmail.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox