* [PATCH] io_uring/opdef: remove 'audit_skip' from SENDMSG_ZC
@ 2022-10-07 18:28 Jens Axboe
2022-10-07 18:35 ` Paul Moore
0 siblings, 1 reply; 6+ messages in thread
From: Jens Axboe @ 2022-10-07 18:28 UTC (permalink / raw)
To: io-uring; +Cc: Paul Moore
The msg variants of sending aren't audited separately, so we should not
be setting audit_skip for the zerocopy sendmsg variant either.
Fixes: 493108d95f14 ("io_uring/net: zerocopy sendmsg")
Reported-by: Paul Moore <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
---
diff --git a/io_uring/opdef.c b/io_uring/opdef.c
index 2330f6da791e..83dc0f9ad3b2 100644
--- a/io_uring/opdef.c
+++ b/io_uring/opdef.c
@@ -510,7 +510,6 @@ const struct io_op_def io_op_defs[] = {
.needs_file = 1,
.unbound_nonreg_file = 1,
.pollout = 1,
- .audit_skip = 1,
.ioprio = 1,
.manual_alloc = 1,
#if defined(CONFIG_NET)
--
Jens Axboe
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] io_uring/opdef: remove 'audit_skip' from SENDMSG_ZC
2022-10-07 18:28 [PATCH] io_uring/opdef: remove 'audit_skip' from SENDMSG_ZC Jens Axboe
@ 2022-10-07 18:35 ` Paul Moore
2022-10-13 22:57 ` Paul Moore
0 siblings, 1 reply; 6+ messages in thread
From: Paul Moore @ 2022-10-07 18:35 UTC (permalink / raw)
To: Jens Axboe; +Cc: io-uring
On Fri, Oct 7, 2022 at 2:28 PM Jens Axboe <[email protected]> wrote:
>
> The msg variants of sending aren't audited separately, so we should not
> be setting audit_skip for the zerocopy sendmsg variant either.
>
> Fixes: 493108d95f14 ("io_uring/net: zerocopy sendmsg")
> Reported-by: Paul Moore <[email protected]>
> Signed-off-by: Jens Axboe <[email protected]>
Thanks Jens.
Reviewed-by: Paul Moore <[email protected]>
--
paul-moore.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] io_uring/opdef: remove 'audit_skip' from SENDMSG_ZC
2022-10-07 18:35 ` Paul Moore
@ 2022-10-13 22:57 ` Paul Moore
2022-10-13 23:10 ` Jens Axboe
0 siblings, 1 reply; 6+ messages in thread
From: Paul Moore @ 2022-10-13 22:57 UTC (permalink / raw)
To: Jens Axboe; +Cc: io-uring
On Fri, Oct 7, 2022 at 2:35 PM Paul Moore <[email protected]> wrote:
> On Fri, Oct 7, 2022 at 2:28 PM Jens Axboe <[email protected]> wrote:
> >
> > The msg variants of sending aren't audited separately, so we should not
> > be setting audit_skip for the zerocopy sendmsg variant either.
> >
> > Fixes: 493108d95f14 ("io_uring/net: zerocopy sendmsg")
> > Reported-by: Paul Moore <[email protected]>
> > Signed-off-by: Jens Axboe <[email protected]>
>
> Thanks Jens.
>
> Reviewed-by: Paul Moore <[email protected]>
Hi Jens, I just wanted to check on this, are you planning to send this
to Linus during the v6.1-rcX cycle?
--
paul-moore.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] io_uring/opdef: remove 'audit_skip' from SENDMSG_ZC
2022-10-13 22:57 ` Paul Moore
@ 2022-10-13 23:10 ` Jens Axboe
2022-10-13 23:12 ` Paul Moore
0 siblings, 1 reply; 6+ messages in thread
From: Jens Axboe @ 2022-10-13 23:10 UTC (permalink / raw)
To: Paul Moore; +Cc: io-uring
On Oct 13, 2022, at 4:58 PM, Paul Moore <[email protected]> wrote:
>
> On Fri, Oct 7, 2022 at 2:35 PM Paul Moore <[email protected]> wrote:
>>> On Fri, Oct 7, 2022 at 2:28 PM Jens Axboe <[email protected]> wrote:
>>>
>>> The msg variants of sending aren't audited separately, so we should not
>>> be setting audit_skip for the zerocopy sendmsg variant either.
>>>
>>> Fixes: 493108d95f14 ("io_uring/net: zerocopy sendmsg")
>>> Reported-by: Paul Moore <[email protected]>
>>> Signed-off-by: Jens Axboe <[email protected]>
>>
>> Thanks Jens.
>>
>> Reviewed-by: Paul Moore <[email protected]>
>
> Hi Jens, I just wanted to check on this, are you planning to send this
> to Linus during the v6.1-rcX cycle?
Yes, it was included in the pull sent out earlier today.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] io_uring/opdef: remove 'audit_skip' from SENDMSG_ZC
2022-10-13 23:10 ` Jens Axboe
@ 2022-10-13 23:12 ` Paul Moore
2022-10-14 3:17 ` Jens Axboe
0 siblings, 1 reply; 6+ messages in thread
From: Paul Moore @ 2022-10-13 23:12 UTC (permalink / raw)
To: Jens Axboe; +Cc: io-uring
On Thu, Oct 13, 2022 at 7:10 PM Jens Axboe <[email protected]> wrote:
> On Oct 13, 2022, at 4:58 PM, Paul Moore <[email protected]> wrote:
> > On Fri, Oct 7, 2022 at 2:35 PM Paul Moore <[email protected]> wrote:
> >>> On Fri, Oct 7, 2022 at 2:28 PM Jens Axboe <[email protected]> wrote:
> >>>
> >>> The msg variants of sending aren't audited separately, so we should not
> >>> be setting audit_skip for the zerocopy sendmsg variant either.
> >>>
> >>> Fixes: 493108d95f14 ("io_uring/net: zerocopy sendmsg")
> >>> Reported-by: Paul Moore <[email protected]>
> >>> Signed-off-by: Jens Axboe <[email protected]>
> >>
> >> Thanks Jens.
> >>
> >> Reviewed-by: Paul Moore <[email protected]>
> >
> > Hi Jens, I just wanted to check on this, are you planning to send this
> > to Linus during the v6.1-rcX cycle?
>
> Yes, it was included in the pull sent out earlier today.
Great, thanks again for your help in taking care of this.
--
paul-moore.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] io_uring/opdef: remove 'audit_skip' from SENDMSG_ZC
2022-10-13 23:12 ` Paul Moore
@ 2022-10-14 3:17 ` Jens Axboe
0 siblings, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2022-10-14 3:17 UTC (permalink / raw)
To: Paul Moore; +Cc: io-uring
On 10/13/22 5:12 PM, Paul Moore wrote:
> On Thu, Oct 13, 2022 at 7:10 PM Jens Axboe <[email protected]> wrote:
>> On Oct 13, 2022, at 4:58 PM, Paul Moore <[email protected]> wrote:
>>> On Fri, Oct 7, 2022 at 2:35 PM Paul Moore <[email protected]> wrote:
>>>>> On Fri, Oct 7, 2022 at 2:28 PM Jens Axboe <[email protected]> wrote:
>>>>>
>>>>> The msg variants of sending aren't audited separately, so we should not
>>>>> be setting audit_skip for the zerocopy sendmsg variant either.
>>>>>
>>>>> Fixes: 493108d95f14 ("io_uring/net: zerocopy sendmsg")
>>>>> Reported-by: Paul Moore <[email protected]>
>>>>> Signed-off-by: Jens Axboe <[email protected]>
>>>>
>>>> Thanks Jens.
>>>>
>>>> Reviewed-by: Paul Moore <[email protected]>
>>>
>>> Hi Jens, I just wanted to check on this, are you planning to send this
>>> to Linus during the v6.1-rcX cycle?
>>
>> Yes, it was included in the pull sent out earlier today.
>
> Great, thanks again for your help in taking care of this.
Not a problem, thanks for letting me know about it!
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-10-14 3:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-07 18:28 [PATCH] io_uring/opdef: remove 'audit_skip' from SENDMSG_ZC Jens Axboe
2022-10-07 18:35 ` Paul Moore
2022-10-13 22:57 ` Paul Moore
2022-10-13 23:10 ` Jens Axboe
2022-10-13 23:12 ` Paul Moore
2022-10-14 3:17 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox