From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99FF4C27C76 for ; Sat, 28 Jan 2023 17:03:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229645AbjA1RDy (ORCPT ); Sat, 28 Jan 2023 12:03:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230264AbjA1RDx (ORCPT ); Sat, 28 Jan 2023 12:03:53 -0500 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FF6BEFA4 for ; Sat, 28 Jan 2023 09:03:52 -0800 (PST) Received: by mail-pl1-x632.google.com with SMTP id r8so956397pls.2 for ; Sat, 28 Jan 2023 09:03:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FZB8lg0YeivU1JmY6qzB+xB0HCsqlxdwoCMFwmTxhGc=; b=YuWBbzUv750b3lluA0Xc6lKsr9XDMwG9ONJRXLFKTbkZw5XSnXEy80i6xh+hAwKICO 09F9AfIAay1C21P2ZRssDSjfvhjxbcYu3VeUvBg9AqqSSmQuGXimp+OpQzy/VRa3Dq4e UMK+mkQ4eAdn4/zqmLakHLyO06OJ1Of4mojiF9+jQbBwmDFmClpTAt776z2kAPVMY0eW Ef8QZLIE/cdUpvAPr9Bls6jXYp1JPKDMyo//TNpJOb5xZp8Hcf8LQYHqvXify6hVcUyu JH+60kQqWeh5blSKY2lWPJUf6LNlWDqmFF2LJ6evItT/6tn6UhVgGx3tfoFHjOLc6N1H 0DHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FZB8lg0YeivU1JmY6qzB+xB0HCsqlxdwoCMFwmTxhGc=; b=sQSV6MnSEqZC/U3RuinkRLNyV7MXyQJphuUE9FdNuzUSnrz/PKNqjgTlHKK2/UQ2fE RNevSuY2wNh6iCMBm+z762ucXvorddK+XJp+9H8h7nOwv6pnlWwlZVPgtDtL5/oEPoMt 71G7fsbobuGrpvFErO5v+e057QPqYcy39N1fOioL7SnBZ4q5J0kJhQHmlpOWmdJp0MQb 8X0WMKoaWtbHAaaEszIxV96cVJssRsZP/BRpcea3FTGkZyghKD6kxH1d8agUB3fWztL7 KGMDd0wXCDjcgI4rC7jISrTtbS2+LmApmaQ68UFoa8a5R3cHo6GWVTmRscZ/ymbSu0g0 cTYw== X-Gm-Message-State: AFqh2krdakmk0atWkqqdh6bVILWegcOnBgnPjcJSYyrS2dRbmOXo1U1Q ygCGK9loG4Lx4HGTsWeQWPvMc4qiW+uXds1VI5Jj X-Google-Smtp-Source: AMrXdXts3HgaSZ1OMsaBQlmOSyte1KDM2wha7k7fk7BHABCeqM3pzpwKqS0gOaF7QboopE3ejUebzS9ZE6jmFHPI+3w= X-Received: by 2002:a17:902:c404:b0:194:954c:fb8 with SMTP id k4-20020a170902c40400b00194954c0fb8mr5105429plk.20.1674925431278; Sat, 28 Jan 2023 09:03:51 -0800 (PST) MIME-Version: 1.0 References: <12151218.O9o76ZdvQC@x2> In-Reply-To: <12151218.O9o76ZdvQC@x2> From: Paul Moore Date: Sat, 28 Jan 2023 12:03:40 -0500 Message-ID: Subject: Re: [PATCH v1 0/2] two suggested iouring op audit updates To: Steve Grubb Cc: Jens Axboe , Richard Guy Briggs , Linux-Audit Mailing List , LKML , io-uring@vger.kernel.org, Eric Paris , Stefan Roesch , Christian Brauner , Pavel Begunkov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Sat, Jan 28, 2023 at 11:48 AM Steve Grubb wrote: > On Friday, January 27, 2023 5:53:24 PM EST Paul Moore wrote: > > On Fri, Jan 27, 2023 at 5:46 PM Jens Axboe wrote: > > > On 1/27/23 3:38=E2=80=AFPM, Paul Moore wrote: > > > > On Fri, Jan 27, 2023 at 2:43 PM Jens Axboe wrote: > > > >> On 1/27/23 12:42=E2=80=AFPM, Paul Moore wrote: > > > >>> On Fri, Jan 27, 2023 at 12:40 PM Jens Axboe wro= te: > > > >>>> On 1/27/23 10:23=E2=80=AFAM, Richard Guy Briggs wrote: > > > >>>>> A couple of updates to the iouring ops audit bypass selections > > > >>>>> suggested in consultation with Steve Grubb. > > > >>>>> > > > >>>>> Richard Guy Briggs (2): > > > >>>>> io_uring,audit: audit IORING_OP_FADVISE but not IORING_OP_MAD= VISE > > > >>>>> io_uring,audit: do not log IORING_OP_*GETXATTR > > > >>>>> > > > >>>>> io_uring/opdef.c | 4 +++- > > > >>>>> 1 file changed, 3 insertions(+), 1 deletion(-) > > > >>>> > > > >>>> Look fine to me - we should probably add stable to both of them, > > > >>>> just to keep things consistent across releases. I can queue them= up > > > >>>> for 6.3. > > > >>> > > > >>> Please hold off until I've had a chance to look them over ... > > > >> > > > >> I haven't taken anything yet, for things like this I always let it > > > >> simmer until people have had a chance to do so. > > > > > > > > Thanks. FWIW, that sounds very reasonable to me, but I've seen lot= s > > > > of different behaviors across subsystems and wanted to make sure we > > > > were on the same page. > > > > > > Sounds fair. BTW, can we stop CC'ing closed lists on patch > > > submissions? Getting these: > > > > > > Your message to Linux-audit awaits moderator approval > > > > > > on every reply is really annoying. > > > > We kinda need audit related stuff on the linux-audit list, that's our > > mailing list for audit stuff. > > > > However, I agree that it is crap that the linux-audit list is > > moderated, but unfortunately that isn't something I control (I haven't > > worked for RH in years, and even then the list owner was really weird > > about managing the list). Occasionally I grumble about moving the > > kernel audit development to a linux-audit list on vger but haven't > > bothered yet, perhaps this is as good a reason as any. > > > > Richard, Steve - any chance of opening the linux-audit list? > > Unfortunately, it really has to be this way. I deleted 10 spam emails > yesterday. It seems like some people subscribed to this list are compromi= sed. > Because everytime there is a legit email, it's followed in a few seconds = by a > spam email. > > Anyways, all legit email will be approved without needing to be subscribe= d. The problem is that other subsystem developers who aren't subscribed to the linux-audit list end up getting held mail notices (see the comments from Jens). The moderation of linux-audit, as permissive as it may be for proper emails, is a problem for upstream linux audit development, I would say much more so than 10/day mails. If you are unable/unwilling to switch linux-audit over to an open mailing list we should revisit moving over to a vger list; at least for upstream kernel development, you are welcome to stick with the existing redhat.com list for discussion of your userspace tools. --=20 paul-moore.com