From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF73BC433EF for ; Fri, 15 Jul 2022 19:53:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231241AbiGOTxH (ORCPT ); Fri, 15 Jul 2022 15:53:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230445AbiGOTxG (ORCPT ); Fri, 15 Jul 2022 15:53:06 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA58952FD5 for ; Fri, 15 Jul 2022 12:53:04 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id bk26so8117093wrb.11 for ; Fri, 15 Jul 2022 12:53:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eoB4WlzK60FfsTcEbS+2/+Q3Hn7n6G9AnefRUurVRPY=; b=MmkNJgf4adqUSub9F1axftbHk9wZnHA4JaaalePnEyJ7EOgvM9CSTIp7CslsWNpNom plt6nc9oFiSxD00JMKi/5EOwlmXpWhKKLPmqkun4FYoVbVK895cQT7S7+Vd/LigWiVty pN/RxT5jtb8En4Y+5s4RcIHCKbo0881QzLzF3pfwo+o47ENo67rzFrmDTy9Zc3R8IWX5 fj16Sg0PozOZ9dI7mu5B3vnG008Uj4/3EkRx7ioJUx3eFytLGngXn6gs/L95Z/J/9qMT 3w0+JVJ/efmtAfMjwzJYofJ74Yu1uiMkuviDV8AUe2bH7M7ZedeZ8J4z5oYXYh1pzcOs zwzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eoB4WlzK60FfsTcEbS+2/+Q3Hn7n6G9AnefRUurVRPY=; b=QkY8zPTO+3s2n4YC1MUAvGsLK2Ga64x7ojRVvL0utgVP14fkHgbC+KDCpnK7BBOlth ja4qCxmVCZjMG/mHREHWwETaLENDMxXrxads/yFAOPhJo16AlFCy8O5/air8JlGpR1Wy 9M7DzUqWy18ZddV68jpEm4aiG3d1xA6PwJjwgPD+RYdEJM0jssMFkiDEWDiq1YMvs+Xp jadrOeUQgYpmrANfEj6nnJew/x5c8S0jSpSuOSMJ3oH+9+eFVAYtNFqU+PgXZpDrwtYP Y5sw3tbwhg+PUIxuH8j+2zp0bet+mXh5+7pw99lSNCdDGb3Rnw6pGhzw7cCgELABgHqu tPfw== X-Gm-Message-State: AJIora8kw9sM+eO9S0CGvUnhIgnJowVckhDKkEdlyk5DwceCRuhFVvcl WoM3XvYJHZZWOe3LiXnErb65CLMipYKconyGAHIN X-Google-Smtp-Source: AGRyM1t4EF/iYxd2UkC/st4fF7/g1qJCRBqTVLY6gX5RFKjWehP/FkVvPuh7my6+DKGsdqn3Q8a1Zc/g1cNB1UFzXX8= X-Received: by 2002:adf:f345:0:b0:21d:6a26:6d8f with SMTP id e5-20020adff345000000b0021d6a266d8fmr14412309wrp.538.1657914783213; Fri, 15 Jul 2022 12:53:03 -0700 (PDT) MIME-Version: 1.0 References: <20220715191622.2310436-1-mcgrof@kernel.org> In-Reply-To: From: Paul Moore Date: Fri, 15 Jul 2022 15:52:52 -0400 Message-ID: Subject: Re: [PATCH v2] lsm,io_uring: add LSM hooks for the new uring_cmd file op To: Jens Axboe , Luis Chamberlain Cc: casey@schaufler-ca.com, joshi.k@samsung.com, linux-security-module@vger.kernel.org, io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, a.manzanares@samsung.com, javier@javigon.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Fri, Jul 15, 2022 at 3:28 PM Jens Axboe wrote: > On 7/15/22 1:16 PM, Luis Chamberlain wrote: > > io-uring cmd support was added through ee692a21e9bf ("fs,io_uring: > > add infrastructure for uring-cmd"), this extended the struct > > file_operations to allow a new command which each subsystem can use > > to enable command passthrough. Add an LSM specific for the command > > passthrough which enables LSMs to inspect the command details. > > > > This was discussed long ago without no clear pointer for something > > conclusive, so this enables LSMs to at least reject this new file > > operation. > > From an io_uring perspective, this looks fine to me. It may be easier if > I take this through my tree due to the moving of the files, or the > security side can do it but it'd have to then wait for merge window (and > post io_uring branch merge) to do so. Just let me know. If done outside > of my tree, feel free to add: > > Acked-by: Jens Axboe Thank you both. -- paul-moore.com