From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88CF713B2A4 for ; Thu, 30 Jan 2025 17:15:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738257347; cv=none; b=j+1cE9X2yaNy815lNP5hSsg7RYdMQ+Fv4mBZynvPm2zlTY88glvqLSRl6CVcgCs7vf5QJLwqgUfI8ZaInrxwh7Ci2CiFD0lSCaS4izzy9EqrRIl6FsJR6BOJErVP2h2AFmf4hClO8RuKOtWP09I8H58X605QpzN3Djqmw7gYoXg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738257347; c=relaxed/simple; bh=7bLqfCB0x0Su4sN4TfU2Dokj5aO1TTFadwDu9y3Nur0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=sTkbEuJjuueiMzCS4mN458xoeOsDJGYQnqqYXb1IGWqR1ZOOrSyvkI2RKE04LOG/K8NRvQ82g2Vh0OIypiLStRSGX4gV5XK7V/n0FWujpyE/Uq3ajd98gU+OThHfRiDUPeOQ+prWPF99wyzYc7sg1Q9fsaXqWJuQJm/TlMdqi9A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=dlRF4WRU; arc=none smtp.client-ip=209.85.219.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="dlRF4WRU" Received: by mail-yb1-f170.google.com with SMTP id 3f1490d57ef6-e58a7e02514so1828109276.1 for ; Thu, 30 Jan 2025 09:15:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1738257344; x=1738862144; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wXwAKgPC0WWLrzCPMBSB6dxF1QIbwOHpmxztQ8zHp20=; b=dlRF4WRU/Ruf5toK5lr9KbnJabQGwJIh7+UId2WdkWjuH3P8EoV2ysczjYMHKzL07O CXBx9IZ0M4bOgurCIh/MHPH2EN9hDSql58/I3mg9HMaZ8enEcFzgkd2fT/H+72CLzPmG EhY0FpC9U3k0HVuYas39l+3LRuEnM8yGvoy+4AkHPbiwR2dHvTDWdkKQfg1DyqjKTfbK HWmCu7jXS06nkjUBkIIjYbYYnvhfPjChd4cgRcT72yw2rsI7c0fwPaFWa6lOPLM+2WWu AWryEPlJx0nhgIxkhQJFr4zjdsf96Mj1i4Alg2krLToduovTv/CLCKjXgLnXRlRsG+aj 67DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738257344; x=1738862144; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wXwAKgPC0WWLrzCPMBSB6dxF1QIbwOHpmxztQ8zHp20=; b=pctqWaKKW2LRqrMM5ltHSzB320JcREB2n0sJ3kvHyPQoS76r36a8HfoZiXDei62MVN sEtZQM94S8bga8xhzOBQA1pOI1bPQYO/xMdnE0pe0XHlHN2pSOPE3Zw1p74/QldbSTyk I2fjUTU1tQX0KMpSRHy5yV0Hp/RGLtmeeVGrKvPHMrik5kZaDy5zAe0+gDcCkCcBcHYm Mhj+jcPX4lvH1FkuSwuwNMfnPrJTZzKTthcKpgOwWCmOrOOPnpEsonGFAbHeAgHgsA/+ Q3GG5IUII8exiIia9uLl3OQ01tawbOBHry7tnpv7qGKr5f3XLyMvm4Kc7DINQFCUAl3n nEKQ== X-Forwarded-Encrypted: i=1; AJvYcCWz6plNbXgFvmqjrrwnPEZYZ5cp4pipqJhUgzm0EobVF+Is5tBGa6bRhDz3zW8EdVdadGHfHIMc5A==@vger.kernel.org X-Gm-Message-State: AOJu0Ywt8wEWCWxTqFVDbHt7iUVMH35g6xLNlwOFv7LofB+yKd+GP//G psOdGrTQVt23ph3+kPwHv3vwu41tmqJ6mtp/45aNhG6aNC+8VGpSgjAlUL6bwWepc8WTrOcSsKl QZObkuXnz99hrlJmQTfU+e9IFeVMdhhVTcA90 X-Gm-Gg: ASbGncvgSPa8jcgaFut7GbX2egpXAHZrCSn2DRxisXP6cBNoeplUI2QgF2Gqr59hQr0 r+ebwHDJaLW6hpQV5dfsbCTBjgjG0OZdfWQIWqZCPzuTtlkvIxIy+fDwTNZw5piAYN00zBO0= X-Google-Smtp-Source: AGHT+IFQmR/dVOUcr5X4dKyehyTb3q/f+4emvxi0NWfXQJk4MY6xdD9R4017+V2TS3Imp2oGSKI5UhjtQ3E5tNQyzzg= X-Received: by 2002:a05:690c:7445:b0:6ef:5cd2:49bb with SMTP id 00721157ae682-6f7a8408102mr70814827b3.30.1738257344457; Thu, 30 Jan 2025 09:15:44 -0800 (PST) Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250127155723.67711-1-hamzamahfooz@linux.microsoft.com> <20250127155723.67711-2-hamzamahfooz@linux.microsoft.com> <84e580b3-0af9-457f-822c-f03271d20e21@schaufler-ca.com> In-Reply-To: <84e580b3-0af9-457f-822c-f03271d20e21@schaufler-ca.com> From: Paul Moore Date: Thu, 30 Jan 2025 12:15:33 -0500 X-Gm-Features: AWEUYZkjt58Q6kGpA1-bf44RrRGs7lGzm9BmtjXrzlkCdaYgJFXIzQxNPQcrwuQ Message-ID: Subject: Re: [PATCH v3 2/2] lsm,io_uring: add LSM hooks for io_uring_setup() To: Casey Schaufler Cc: Hamza Mahfooz , linux-kernel@vger.kernel.org, James Morris , "Serge E. Hallyn" , Jens Axboe , Pavel Begunkov , Stephen Smalley , Ondrej Mosnacek , =?UTF-8?Q?Bram_Bonn=C3=A9?= , =?UTF-8?Q?Thi=C3=A9baud_Weksteen?= , =?UTF-8?Q?Christian_G=C3=B6ttsche?= , Masahiro Yamada , linux-security-module@vger.kernel.org, io-uring@vger.kernel.org, selinux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jan 28, 2025 at 7:02=E2=80=AFPM Casey Schaufler wrote: > > I can't say I agree that it's an access control because although it is > specific to a process it isn't specific to an object. You can still acces= s > the set of objects using other means. It is a mechanism control, preventi= ng > use of io_uring entirely. I see your argument and raise you "capabilities". Granted, we could have a fairly lively debate about the merits of capabilities, which I'm not encouraging here, I'm only mentioning it as a counterpoint and evidence that there is precedent for things like this as "access control". > I'm much more concerned about bugs in io_uring than in xyzzy. The io_urin= g > people have been pretty good about addressing LSM issues, so it's not > a huge deal, but I never like seeing switches to turn off features becaus= e > security is active. > > If no one else shares my concern you can put my comments down to the > ravings of the lunatic fringe and ignore them. Fair enough. FWIW, I appreciate the discussion, even if we didn't quite reach consensus this time around. --=20 paul-moore.com