From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81023C47083 for ; Fri, 4 Jun 2021 05:04:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4FABB6140F for ; Fri, 4 Jun 2021 05:04:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229704AbhFDFGg (ORCPT ); Fri, 4 Jun 2021 01:06:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229628AbhFDFGf (ORCPT ); Fri, 4 Jun 2021 01:06:35 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB31BC06174A for ; Thu, 3 Jun 2021 22:04:37 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id ci15so12513604ejc.10 for ; Thu, 03 Jun 2021 22:04:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F4KNkxgVBE2IaKKrWIflXpiMTxbcNGtO3JcMgEhgrn4=; b=o94bs7U9IPq9Pa1huceut2mtx1/qS1BIzr2m7/D0ElSnvLcgt/EZJzk5KB3yZ4Skz8 o90x3f6tanRZ1P65uIu/7LtBEKoZ7BXvggS5EGo5YSO41QLKC9oI16QIQhUwg4JOUL8d JslQuUfN6xT67ucLy6w+SLo2zZNYLDC7n4wH/8coHXDqIRphosK91tA1d/iUaT/itW40 TzTUGjHJH7VgOgntc+QjbNxfCSId1gNZ2lzAIOvt2s1XPzUirumPWP9K/SmySReNkdOi uJNHPw5+1cE6NMrrKaEyRYIH3hizdNeDjUGUKNZlCY/Vi/Z1SEPuW1foC3jGUA2xY2cy PYfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F4KNkxgVBE2IaKKrWIflXpiMTxbcNGtO3JcMgEhgrn4=; b=Y5Rq4L9NMolqt4tACQqZQJvD9ClmuQ80IM6NumsjDK+EmsrlA9e2pahDwf+4N+t58s MhpaGBkKsL0fOpqnT7lc309f7pIzbrkhhdFnNyOZkD1xlIYDheddvVkcZUomsUObKsOt hx6R2a/uwBoPsbOAepoC6W2VyPCp1jfNdmHiFWbXdjiIv9WUSNeHK9Lt83E1kTVGK0DX zR1C7vq8370h7J+1CfIiUj0gEe6dQ53Clz/GCOsVWVEkqEbuQWPZH/Eyf87URwG30AZu Ixk6AK07Nia8Ssfzja2UpMnpm4a5/xHTn5r9aJiCDcP76+BlgA1IEpebxIncJChROfeT FxPw== X-Gm-Message-State: AOAM530mExGKoSVWjsfZk49VV7Zslq+4cSBInKLFr/DACWPR1SzMo5BT Ru6KJL56ZPqq8ZXFa6pPuDqfjvkVyG9J0GJxirmi X-Google-Smtp-Source: ABdhPJwJrbIpifPHt0RmxDhbFGonFTcmrxomuiF8TJjro/LYRcNy1Ukcm+dNkb4N5xI5Zs6y+uH7Kz1ctjm94ABTP34= X-Received: by 2002:a17:906:4111:: with SMTP id j17mr2438703ejk.488.1622783076402; Thu, 03 Jun 2021 22:04:36 -0700 (PDT) MIME-Version: 1.0 References: <162163367115.8379.8459012634106035341.stgit@sifl> <162163379461.8379.9691291608621179559.stgit@sifl> <162219f9-7844-0c78-388f-9b5c06557d06@gmail.com> <8943629d-3c69-3529-ca79-d7f8e2c60c16@kernel.dk> <9e69e4b6-2b87-a688-d604-c7f70be894f5@kernel.dk> <3bef7c8a-ee70-d91d-74db-367ad0137d00@kernel.dk> <46381e4e-a65d-f217-1d0d-43d1fa8a99aa@kernel.dk> In-Reply-To: <46381e4e-a65d-f217-1d0d-43d1fa8a99aa@kernel.dk> From: Paul Moore Date: Fri, 4 Jun 2021 01:04:25 -0400 Message-ID: Subject: Re: [RFC PATCH 2/9] audit,io_uring,io-wq: add some basic audit support to io_uring To: Jens Axboe Cc: Pavel Begunkov , linux-security-module@vger.kernel.org, selinux@vger.kernel.org, linux-audit@redhat.com, io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, Kumar Kartikeya Dwivedi , Alexander Viro Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Thu, Jun 3, 2021 at 11:54 AM Jens Axboe wrote: > On 5/28/21 10:02 AM, Paul Moore wrote: > > On Wed, May 26, 2021 at 4:19 PM Paul Moore wrote: > >> ... If we moved the _entry > >> and _exit calls into the individual operation case blocks (quick > >> openat example below) so that only certain operations were able to be > >> audited would that be acceptable assuming the high frequency ops were > >> untouched? My initial gut feeling was that this would involve >50% of > >> the ops, but Steve Grubb seems to think it would be less; it may be > >> time to look at that a bit more seriously, but if it gets a NACK > >> regardless it isn't worth the time - thoughts? > >> > >> case IORING_OP_OPENAT: > >> audit_uring_entry(req->opcode); > >> ret = io_openat(req, issue_flags); > >> audit_uring_exit(!ret, ret); > >> break; > > > > I wanted to pose this question again in case it was lost in the > > thread, I suspect this may be the last option before we have to "fix" > > things at the Kconfig level. I definitely don't want to have to go > > that route, and I suspect most everyone on this thread feels the same, > > so I'm hopeful we can find a solution that is begrudgingly acceptable > > to both groups. > > Sorry for the lack of response here, but to sum up my order of > preference: > > 1) It's probably better to just make the audit an opt-out in io_op_defs > for each opcode, and avoid needing boiler plate code for each op > handler. The opt-out would ensure that new opcodes get it by default > it someone doesn't know what it is, and the io_op_defs addition would > mean that it's in generic code rather then in the handlers. Yes it's > a bit slower, but it's saner imho. > > 2) With the above, I'm fine with adding this to io_uring. I don't think > going the route of mutual exclusion in kconfig helps anyone, it'd > be counter productive to both sides. > > Hope that works and helps move this forward. I'll be mostly out of touch > the next week and a half, but wanted to ensure that I sent out my > (brief) thoughts before going away. Thanks Jens. I'll revise the patchset based on this (basically doing an opt-out version of what you did on May 26th) and do a v2 post with the other accumulated fixes/changes. If there is anything else that needs discussion/review I'm sure Pavel can help us out, he's been helpful thus far. -- paul moore www.paul-moore.com