From: Paul Moore <[email protected]>
To: Luis Chamberlain <[email protected]>
Cc: [email protected], [email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected]
Subject: Re: [PATCH] lsm,io_uring: add LSM hooks to for the new uring_cmd file op
Date: Fri, 15 Jul 2022 15:51:48 -0400 [thread overview]
Message-ID: <CAHC9VhS_dy_qeY=7KnSqs0ZT9dzAbSEyq5WMNKvZTD5=oreGew@mail.gmail.com> (raw)
In-Reply-To: <YtG5zRPFV967/[email protected]>
On Fri, Jul 15, 2022 at 3:02 PM Luis Chamberlain <[email protected]> wrote:
> On Fri, Jul 15, 2022 at 02:46:16PM -0400, Paul Moore wrote:
> > It looks like I owe you an apology, Luis. While my frustration over
> > io_uring remains, along with my disappointment that the io_uring
> > developers continue to avoid discussing access controls with the LSM
> > community, you are not the author of the IORING_OP_URING_CMD. You
> > are simply trying to do the right thing by adding the necessary LSM
> > controls and in my confusion I likely caused you a bit of frustration;
> > I'm sorry for that.
>
> No frustration caused, I get it.
Thanks for your understanding, I appreciate it as well as your help in
this area.
> > Well, we're at -rc6 right now which means IORING_OP_URING_CMD is
> > happening and it's unlikely the LSM folks are going to be able to
> > influence the design/implementation much at this point so we have to
> > do the best we can. Given the existing constraints, I think your
> > patch is reasonable (although please do shift the hook call site down
> > a bit as discussed above), we just need to develop the LSM
> > implementations to go along with it.
> >
> > Luis, can you respin and resend the patch with the requested changes?
>
> Sure thing.
>
> > I also think we should mark the patches with a 'Fixes:' line that
> > points at the IORING_OP_URING_CMD commit, ee692a21e9bf ("fs,io_uring:
> > add infrastructure for uring-cmd").
>
> I'll do that.
Great, thanks again for the help.
--
paul-moore.com
next prev parent reply other threads:[~2022-07-15 19:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 0:05 [PATCH] lsm,io_uring: add LSM hooks to for the new uring_cmd file op Luis Chamberlain
2022-07-14 0:38 ` Casey Schaufler
2022-07-15 0:54 ` Luis Chamberlain
2022-07-15 1:25 ` Casey Schaufler
2022-07-14 3:00 ` Paul Moore
2022-07-15 1:00 ` Luis Chamberlain
2022-07-15 18:46 ` Paul Moore
2022-07-15 19:02 ` Luis Chamberlain
2022-07-15 19:51 ` Paul Moore [this message]
2022-07-15 19:07 ` Jens Axboe
2022-07-15 19:50 ` Paul Moore
2022-07-15 20:00 ` Jens Axboe
2022-07-15 21:16 ` Casey Schaufler
2022-07-15 21:32 ` Jens Axboe
2022-07-15 21:37 ` Luis Chamberlain
2022-07-15 21:47 ` Jens Axboe
2022-07-15 20:50 ` Casey Schaufler
2022-07-15 23:03 ` Casey Schaufler
2022-07-15 23:05 ` Jens Axboe
2022-07-15 23:14 ` Casey Schaufler
2022-07-15 23:18 ` Jens Axboe
2022-07-15 23:31 ` Casey Schaufler
2022-07-15 23:34 ` Jens Axboe
2022-07-16 3:20 ` Kanchan Joshi
2022-07-18 14:55 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhS_dy_qeY=7KnSqs0ZT9dzAbSEyq5WMNKvZTD5=oreGew@mail.gmail.com' \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox