public inbox for [email protected]
 help / color / mirror / Atom feed
From: Matteo Rizzo <[email protected]>
To: Bart Van Assche <[email protected]>
Cc: [email protected], [email protected],
	[email protected], [email protected], [email protected],
	[email protected], [email protected], [email protected],
	[email protected], [email protected],
	[email protected], [email protected],
	[email protected], [email protected],
	[email protected], [email protected], [email protected],
	[email protected], [email protected], [email protected]
Subject: Re: [PATCH v2 1/1] Add a new sysctl to disable io_uring system-wide
Date: Thu, 29 Jun 2023 17:28:47 +0200	[thread overview]
Message-ID: <CAHKB1wKbSoK+=ceM_WLgBConNaua=0UPQv9ZmDp6LNXh3QNr=Q@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>

On Thu, 29 Jun 2023 at 17:16, Bart Van Assche <[email protected]> wrote:
>
> On 6/29/23 06:27, Matteo Rizzo wrote:
> > +static int __read_mostly sysctl_io_uring_disabled;
>
> Shouldn't this be a static key instead of an int in order to minimize the
> performance impact on the io_uring_setup() system call? See also
> Documentation/staging/static-keys.rst.
>
> Thanks,
>
> Bart.

Is io_uring_setup in any hot path? io_uring_create is marked as __cold.

--
Matteo

  reply	other threads:[~2023-06-29 15:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-29 13:27 [PATCH v2 0/1] Add a sysctl to disable io_uring system-wide Matteo Rizzo
2023-06-29 13:27 ` [PATCH v2 1/1] Add a new " Matteo Rizzo
2023-06-29 15:15   ` Bart Van Assche
2023-06-29 15:28     ` Matteo Rizzo [this message]
2023-06-29 17:37       ` Bart Van Assche
2023-06-29 16:17   ` Jeff Moyer
2023-06-29 18:36   ` Gabriel Krisman Bertazi
2023-06-30 15:04     ` Matteo Rizzo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHKB1wKbSoK+=ceM_WLgBConNaua=0UPQv9ZmDp6LNXh3QNr=Q@mail.gmail.com' \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox