From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13F091E8329 for ; Wed, 6 Aug 2025 18:30:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754505053; cv=none; b=Cw7lBa4LGIYtg3BKy/ccdw1By4TZ4dPG730Bsuw54G+Wq0hXWaILGozx9bZ+vWzBayeX2cxA3rE7yoqAGdW+yzD/ZrJpW3ZBjwuMPb4KWJmBzT5h5uvHFR3wj6PJSrokwFBomlSp22sd5CPKFmGlMenytevrkYIATx7W3VNhmA4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754505053; c=relaxed/simple; bh=vLj+fdJb2Vks5utREQNrEigpGF6KFgjJSUgqIR6F6UY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=FbbDET5vH2UdbG0IxQruMGAwGg3BcgQ+s2Nib4NMX+DfgtWHnJ4u47jL6r4f8LSMt40Fl3IgesJQW8hvSq+WboVGnHYawz3AD7xkEm9Cq6TJrgqUBNgVFZD0VaglgfaD0N4mPmIQ2hmcwUDN8W348AbogEVLnTi27uoAA74OUZc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=bLuBDr8R; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bLuBDr8R" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-55ba0f2f081so1465e87.1 for ; Wed, 06 Aug 2025 11:30:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1754505050; x=1755109850; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3TDOublo3Q2tG40X6vbYcBf3dOqybzUDofJqFWP7aQk=; b=bLuBDr8R3DPgp9/CRCw6rrvYVEgbPFVcuniJBKND9WjsSe1zGB5Qr2mHPBfRI0Nunp Sb4/FzlMyFzB/8PfUAiIot5J7QxNgVCIbgDEOFK/0O4FrXHq9Vve6oR0riPJlP9HK6Nd N8URHZYkn3Z+1lF4JjmXOOU5gQg4EQO4kcutvKigOzIzx08di4hHXC663pP84hWhmUip BKktcRQmulS1pjpSJW3AvkU2XIgKnAUrNas4UgCwyzAEayP2MOrnLAHDANfTwdgc9bX+ 5ZQ1fXlJlfPiyolSUjnM2cBCLtz9RyI9i2U0tkYyDS5fpvakwxusKGrywlBsMOdj9Efj lSUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754505050; x=1755109850; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3TDOublo3Q2tG40X6vbYcBf3dOqybzUDofJqFWP7aQk=; b=QtIWYzEC4ygOoKc5t63B2D5Z2ikoYUEvC70cElL9+B3ybmsVOptyT3WdYvMWePtXEx roH3Zm0dT2Z7h9HEp1TSBtGWFcilkQhfhJP9zd5zcYO6oYX97+TgsdiwTvpMCfZSMPAf crUIU7jKLbflNnKrzQAjMFr89VpFYtAO/iew50AeK6M3J1bk374tckGFpUiFmlF8dEIF 94QRIyhO5qdWVpA6XEFOVBwy0tH4ZXk4aNWAjJSlXCPO88esfqUITWOfjFFgNpCO0EI3 W5qgtrFCTfZc/CIrRIpdFOhSgaFRprmC7TpAgc80ULBPR9EQXAYUssS3kXOOpCIxzz5x 2qyA== X-Forwarded-Encrypted: i=1; AJvYcCX6ohts4As2FqYW8IM3WNT94MRhLKbHhJTHJriesfAmvPx4KnkDw3BnI4UH7ynIjMQZhMs87Jr6zg==@vger.kernel.org X-Gm-Message-State: AOJu0YzcTawzxd9xR5UU1wvZMD/1WzY1L5+fKx3Jo/LNp5vPJDdm4on9 TtKZbTgSbRfzXFatzEru1Nv6RVPYvZAh7UuTVE58ApoRt9Zo65BR3na0J4F2FUFEDmBUhkxBpks nK0rAQxxclqZXSr/jj/TTnBiEk04mdb4BxnondBGs X-Gm-Gg: ASbGncsfU5Vj02RLyXQ2HIZnaAMCCUMZYhwyt8A1/ArguD2iEs61tCZlpvZu8HRu0Hk hD6j/bNbMaiyqp5r1YyhlhF1KKSKj/u4uMkfep9N+6+sodMYy5ITqtvU3YphQbD56nX2HsgHuX+ lj07HgZoztLPaOwlOQ831GYONlJL7LzUoUYMtmk0EyDoSBnZfSpCMy+DOtHh83vWncLpOsybiH3 /FckSPS6gQObZ/u6EEExPe2d3Qq3mQrhwVeuBDQg/YQwaR9 X-Google-Smtp-Source: AGHT+IGt/wOJpNx7GnnwYBOLWPcP3IZ20CYAR4HnNGLoquJY9uECaHULv4YoLWdZT3k/01JfdD6rDnK0mvdb6p8RQV0= X-Received: by 2002:a05:6512:6406:b0:55a:2d72:de56 with SMTP id 2adb3069b0e04-55cb6ee8ebamr13453e87.5.1754505049986; Wed, 06 Aug 2025 11:30:49 -0700 (PDT) Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250801171009.6789bf74@kernel.org> <11caecf8-5b81-49c7-8b73-847033151d51@gmail.com> <20250806111108.33125aa2@kernel.org> In-Reply-To: <20250806111108.33125aa2@kernel.org> From: Mina Almasry Date: Wed, 6 Aug 2025 11:30:38 -0700 X-Gm-Features: Ac12FXxs3PsW0TDpaFvxbsuRlfuu8IOZMcSAN6tdJGrWWtI1P2KBlk8RG97WhOk Message-ID: Subject: Re: [RFC v1 21/22] net: parametrise mp open with a queue config To: Jakub Kicinski Cc: Pavel Begunkov , netdev@vger.kernel.org, io-uring@vger.kernel.org, Eric Dumazet , Willem de Bruijn , Paolo Abeni , andrew+netdev@lunn.ch, horms@kernel.org, davem@davemloft.net, sdf@fomichev.me, dw@davidwei.uk, michael.chan@broadcom.com, dtatulea@nvidia.com, ap420073@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Aug 6, 2025 at 11:11=E2=80=AFAM Jakub Kicinski wr= ote: > > On Wed, 6 Aug 2025 09:48:56 -0700 Mina Almasry wrote: > > iouring zcrx and devmem can configure netdev_rx_queue->rx_buf_len in > > addition to netdev_rx_queue->mp_params in this scenario. > > Did you not read my message or are you disagreeing that the setting > should be separate and form a hierarchy? Sorry, I was disagreeing. The flow above seems complicated. I'm probably missing something that requires this complication. I was suggesting an approach I find more straightforward. Something like: ``` nedev_config =3D get_driver_defaults() qcfg =3D get_driver_defaults() for each setting: if qcfg[i].X is set: use qcfg[i].X else use netdev_config.X ``` APIs that set netdev-global attributes could set netdev_config.X. APIs that set per-queue attributes would set qcfg[i].X (after validating that the driver supports setting this param on a queue granularity). With this flow we don't need to duplicate each attribute like rx-buf-len in 3 different places and have a delicate hierarchy of serving the config. And we treat mp like any other 'X'. It's just a setting that exists per-queue but not per netdev. Although I don't feel strongly here. If you feel the duplication is warranted please do go ahead1 :-D --=20 Thanks, Mina