From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB5F01E3772 for ; Tue, 22 Apr 2025 21:30:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745357459; cv=none; b=WJU9dXl3tzDMzx1knBvj3IaNosorcHjNLVzWYOrqrFO5GbklmQYtCNUuslkVbiBvXqSYeURruG/uXuJbGeD9YlS/m07fyINe2oXsCtdCNkguPJV5Wf0nRFXGypJrwuRAUoAK8Wlh5Dt/pzf08JA1xLAoLmpBQHdorotqruer6BA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745357459; c=relaxed/simple; bh=QgWx/mGTOHW5+7tGU+2WKWru7coX4Xp6cIn7ZGTb7ls=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=em3Kjd1aKMj5/sQl1sjoO3GfIyokDfXQzkamlfywrjvwKFctNNEBcOK7P2v+gybpKkdeLdSTw07uPOiXLYsRRjrpHpxwSru67bHRjPf5LfuJ2fVpYTlGoG1lQPK+db3JHbEnZC+yXyaq5YGIDgT++xFI2tL/PvIoSDiLms6hfpQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=GB7eL9mu; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GB7eL9mu" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2240aad70f2so79845ad.0 for ; Tue, 22 Apr 2025 14:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1745357457; x=1745962257; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Svf2ygZXkmCy0ML2RTDTzsfPn2nyYFTdu9KxKlqPAMw=; b=GB7eL9muGEq2eNRHjsAa5UlA8JCZVgnhmydKuptdQE9PiUvhitHuM6+nHl7k4fP6j0 I1jbWoTqUSt+FBJJaRSjdH//1cpvP5jqCQBqH6Cegb+j9XcV09M2zJ61iTqdndkB2aAp GjZeu9EJk9PDm2NXxkTw13580cEMqXX6LzjP+eNIcgm7B8o1g2Ynh1vfZD+6byvbhdvF YobfiM53q1xsDnAryKQdgc/W+m4KICbdn4qvcZ858aOU4Zr5hJDE6mKVvNt+q56YV+Iy YrzRZIYrJvekbfs9gUk1fb1ocKhivgNcDljcEx5YFVx3CsDIJ+AOZJgpbo9sfxw/sABW bGWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745357457; x=1745962257; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Svf2ygZXkmCy0ML2RTDTzsfPn2nyYFTdu9KxKlqPAMw=; b=joJM0yu7DWazViTSnIkzOnP1JhHri9Q3xPdcPRupl0mmZKQpUCOdZ3mNRWH/dkGJTI KvBY1T6JgJ+p2jLlO47/63/KeKOtHozdndGtmHioA3HaEIcFnXw1cosTfqcpl+Ya6DZl JvYNzv24Xh42vaarkbAOSYhZ4pumD6ijyRtO48VDhI6sRvD60QS4mAjGxNhR0WNYbkxG rbKJY4oVv7DrL2/QtLV1Mw4P8Wk1qrNH+IQrOLR9hB2WSmZwgsG7nsFj+v1WOmeF+hrQ Iln+31lgAJFYrZGpJlEv4ll9TKWYpPCso1d9M26pUPnJaaPydQAp1dGiM2T2MOxODY42 ephw== X-Forwarded-Encrypted: i=1; AJvYcCX6OnJII3xmdRuy1+dr6CW1iS2EDRtOhRWSB/3c0MlkguX0oLqOMB/IJ/GIcoWQofVd5AgSJUawdA==@vger.kernel.org X-Gm-Message-State: AOJu0YziudeIqgaDovJj9sQqS5hfk5cYxm/B8c5aOAbzi/qGi5+FUieB VUUbiQ1961figcW+zRPWeCKKAf5mRQsuEJXlbCWnGcm1F8Nn5C07l7+MJJngAngyQ5zpBNLMfu/ LlFKw4U0Xf5qfjJklTkSKu3COQOl2hka6lKAw X-Gm-Gg: ASbGncsVbqYK6C6IK9aPpgYyTRrO8JdsnK/NtwwiP6qNraNzKNLVvkvtP+FcR6z77zz TZbLrODuwS7RrQTkrlf0ZZ+XTqMTj+ujKThn9/hTNcy/FUYle8paomw+cwrVFzCSLTJoTFrM2AX JdIfdO7ge8QVTdJ7iiUYtVU4wbSiMM0TsUHMx8clTPys0fIDet3S7+ X-Google-Smtp-Source: AGHT+IEsxPoKV42ELz4r3PlLIa9B44ITOq/P7IHVyPrE3pHPM2hSBs7ANYJO9Qlwme81VQmpCIMF5XJigErG9Bs9itA= X-Received: by 2002:a17:903:f8b:b0:21f:3c4a:136f with SMTP id d9443c01a7336-22da2c11b3emr916085ad.28.1745357456832; Tue, 22 Apr 2025 14:30:56 -0700 (PDT) Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250417231540.2780723-1-almasrymina@google.com> <20250417231540.2780723-8-almasrymina@google.com> In-Reply-To: From: Mina Almasry Date: Tue, 22 Apr 2025 14:30:44 -0700 X-Gm-Features: ATxdqUF6FGOZDMaVY4FPxfYTFEWH1OIzJQfd7hMv2NVJ5VM5o9Gd234gao1kzAo Message-ID: Subject: Re: [PATCH net-next v9 7/9] gve: add netmem TX support to GVE DQO-RDA mode To: Harshitha Ramamurthy Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, io-uring@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Donald Hunter , Jonathan Corbet , Andrew Lunn , Jeroen de Borst , Kuniyuki Iwashima , Willem de Bruijn , Jens Axboe , Pavel Begunkov , David Ahern , Neal Cardwell , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Stefan Hajnoczi , Stefano Garzarella , Shuah Khan , sdf@fomichev.me, dw@davidwei.uk, Jamal Hadi Salim , Victor Nogueira , Pedro Tammela , Samiullah Khawaja Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Apr 22, 2025 at 10:43=E2=80=AFAM Harshitha Ramamurthy wrote: > > On Thu, Apr 17, 2025 at 4:15=E2=80=AFPM Mina Almasry wrote: > > > > Use netmem_dma_*() helpers in gve_tx_dqo.c DQO-RDA paths to > > enable netmem TX support in that mode. > > > > Declare support for netmem TX in GVE DQO-RDA mode. > > > > Signed-off-by: Mina Almasry > > > > --- > > > > v4: > > - New patch > > --- > > drivers/net/ethernet/google/gve/gve_main.c | 4 ++++ > > drivers/net/ethernet/google/gve/gve_tx_dqo.c | 8 +++++--- > > 2 files changed, 9 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/e= thernet/google/gve/gve_main.c > > index 8aaac9101377..430314225d4d 100644 > > --- a/drivers/net/ethernet/google/gve/gve_main.c > > +++ b/drivers/net/ethernet/google/gve/gve_main.c > > @@ -2665,6 +2665,10 @@ static int gve_probe(struct pci_dev *pdev, const= struct pci_device_id *ent) > > > > dev_info(&pdev->dev, "GVE version %s\n", gve_version_str); > > dev_info(&pdev->dev, "GVE queue format %d\n", (int)priv->queue_= format); > > + > > + if (!gve_is_gqi(priv) && !gve_is_qpl(priv)) > > + dev->netmem_tx =3D true; > > + > > a nit: but it would fit in better and be more uniform if this is set > earlier in the function where other features are set for the > net_device. > Thanks for taking a look. I actually thought about that while trying to implement this, but AFAIU (correct if wrong), gve_is_gqi and gve_is_qpl need priv to be initialized, so this feature set must be performed after gve_init_priv in this function. I suppose this feature checking maybe can be put before register_netdev. Do you prefer that? --=20 Thanks, Mina