From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0EA5326D62 for ; Tue, 19 Aug 2025 19:27:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755631667; cv=none; b=bcLtuwqK5NAlxslJlFy37ab1wzWzdwXyWFLSRS9a9WOlJlDZKc2KqwoxSAKphZiBCHHkTsWzviZ0HKIF3CICsl1YQkUFOECHzbAymOJrdx8+pXrzqK/blKcWNGbxk+DEU56p+D8ftY+7nWamkB2JP0Md2epxo6OR22pMSXBQtlg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755631667; c=relaxed/simple; bh=BlVzj2EUR10ubBzzoCWGCgBRnjT2tSR4AsN+B/Tx+uE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=j4WfC7irlrHVwamQcJoAgPo/HKvb6keLj/FI18SwiEPo3T+q56dQCfSkZaR8d+43poJNUtGmKKDq9BHiqgaM83yxcpXGb1I6n1S6lQXtDPzXQROexPa6XcHM3ublPimJauwq/2wIuitqx5k8Ift6MpaPrhNH/4bzh+3iGJ3oJFM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=2yvPoS8H; arc=none smtp.client-ip=209.85.160.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="2yvPoS8H" Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-4b0bf08551cso97371cf.1 for ; Tue, 19 Aug 2025 12:27:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1755631665; x=1756236465; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BlVzj2EUR10ubBzzoCWGCgBRnjT2tSR4AsN+B/Tx+uE=; b=2yvPoS8HQWczeJaM7fx8jeCdrDaBiQmi4SbIn0siSypuiFDVh16Rl2L6b7paZZzsWu aQhddtinIru6QmgeVDzpB/rjT+OeRBQHG3pnwufmOcWe3Gmn78Qa5RnxvgUd6h9LR9nO srUzWuwWD20Ex6NB8g9qm47h8ybzzzwhRI3/MXMS5BgOSurLoWLhXjf2PXP2abvdtnVS qupbU5P7iamPH/DDFRWRlGvOi9wczfTDkJWX/Gf13CPTqK91oCmVFXXkrvrfzig1uo70 Qaw04YlvGNy3ZluJ2AUhPNmCPmZdujB7/dg9gZoJF1DeLcKRQopTP7CulTrCrcBPQZYC lv3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755631665; x=1756236465; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BlVzj2EUR10ubBzzoCWGCgBRnjT2tSR4AsN+B/Tx+uE=; b=pG5AdOk4nd53OCTJD6ki15sVxAvBO46XDYhyyIfs42aYYcT1w9PmqDSXcOLvPKK7aj f9e2q1itBul1++l6cicCt8oXUpstFp6HS2JOHqZkVqTdocnMpWyH5Tu+wUkgjMqw7joO C25UcyIGxc0dUmODl9w3wKcCD6PI9NlLOVc/s+PLeEavvWDgPTPDMuxdca+urcz7ly35 7uI6n9fAl/rGaZf8LtVkaKsxj+zxaZjqVb8OF34X9AoVi2Jl42kbG4n9a51fEbG27F62 uoH8SMCC1w8IxcKKH96Zbq+YRjXNpNpZ/W6vpcog2Lqj1BZMKJUGmpCIAfwoJXuWMYLO qYOg== X-Forwarded-Encrypted: i=1; AJvYcCWjPOhnSEkxUC65HT8poDnyQ1gtKBTXilnmlkKzrWxZxBx/YxwZHBnvsrBT+Mkmiqsda8n8hwyWXA==@vger.kernel.org X-Gm-Message-State: AOJu0YzsN8x43WIPLgyUa+NVsdoeM1+J3Q23X6sbz2Jic+dQ4I7rcxdr Kko40OiZ+YFjyJaAPMfTW+0TCBczZ7VjAzqZJxmfPopRVHN28UKjlg9GdvbQ2Pfci44F8RG7RJf dGEwmm8IMVWWhx5HSfizBDsDgT4srs8PrKcRgewMt X-Gm-Gg: ASbGncvm7TMWLDO2UjLpSzDmcPcVpI8VTJjXCPQ7D0pvnL/tfUqwVAbA7BJmj/h02cW hzBgjncNuWNfxy+Nvm+kmggKajy3rfidyuHjGCo6VggMIMtjPNUkMRiH1UtzRanHskxQ4PoQxwd KFO6pxQy/IZdenHZ9XubLog3EF8AZ98H1BwP33UnLlND746mljcBbBSZChSfJUFLc1/wOBDXgPW Gd2lc2M0PRWL90CNpUxPPGzwENQkFffW0zasrk1Kd5xQHTIOTZ8GNQ= X-Google-Smtp-Source: AGHT+IEDWpSWU5ZzY/KJckLXK1MXb3iQFKIaTTR+UKAO1//noOtBrDSrcuDwJaJI6GftEm+TVmZKste1iti0T0BhbeY= X-Received: by 2002:a05:622a:156:b0:4b0:8576:e036 with SMTP id d75a77b69052e-4b2916cdeffmr923341cf.0.1755631664504; Tue, 19 Aug 2025 12:27:44 -0700 (PDT) Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: In-Reply-To: From: Mina Almasry Date: Tue, 19 Aug 2025 12:27:27 -0700 X-Gm-Features: Ac12FXzollJPprpvLpQ4-IC38LVTaqJboHUEkHUZ0bfbl4-1_1fZtat3-UCqxVo Message-ID: Subject: Re: [PATCH net-next v3 04/23] net: use zero value to restore rx_buf_len to default To: Pavel Begunkov Cc: Jakub Kicinski , netdev@vger.kernel.org, Eric Dumazet , Willem de Bruijn , Paolo Abeni , andrew+netdev@lunn.ch, horms@kernel.org, davem@davemloft.net, sdf@fomichev.me, dw@davidwei.uk, michael.chan@broadcom.com, dtatulea@nvidia.com, ap420073@gmail.com, linux-kernel@vger.kernel.org, io-uring@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Aug 19, 2025 at 8:51=E2=80=AFAM Pavel Begunkov wrote: > > On 8/19/25 01:07, Mina Almasry wrote: > > On Mon, Aug 18, 2025 at 6:56=E2=80=AFAM Pavel Begunkov wrote: > >> > >> From: Jakub Kicinski > >> > >> Distinguish between rx_buf_len being driver default vs user config. > >> Use 0 as a special value meaning "unset" or "restore driver default". > >> This will be necessary later on to configure it per-queue, but > >> the ability to restore defaults may be useful in itself. > >> > >> Signed-off-by: Jakub Kicinski > >> Signed-off-by: Pavel Begunkov > > > > I wonder if it should be extended to the other driver using > > rx_buf_len, hns3. For that, I think the default buf size would be > > HNS3_DEFAULT_RX_BUF_LEN. > > I'd rather avoid growing the series even more, let's follow up on > that in a separate patch on top, that should be just fine. And > thanks for the review > > > Other than that, seems fine to me, > > > > Reviewed-by: Mina Almasry > > With the said above, do you want me to retain the review tag? > I initially thought adding my reviewed-by would be fine, but on closer look, doesn't this series break rx_buf_len setting for hns3? AFAICT so far, in patch 3 you're adding a check to ethnl_set_rings where it'll be an error if rx_buf_len > rx_buf_len_max, and i'm guessing if the driver never sets rx_buf_len_max it'll be 0 initialized and that check would always fail? Or did I miss something? --=20 Thanks, Mina