public inbox for [email protected]
 help / color / mirror / Atom feed
From: Linus Torvalds <[email protected]>
To: Kees Cook <[email protected]>
Cc: "Eric Biederman" <[email protected]>,
	"Alexander Viro" <[email protected]>,
	"Christian Brauner" <[email protected]>,
	"Jan Kara" <[email protected]>,
	[email protected], [email protected],
	"Ingo Molnar" <[email protected]>,
	"Peter Zijlstra" <[email protected]>,
	"Juri Lelli" <[email protected]>,
	"Vincent Guittot" <[email protected]>,
	"Dietmar Eggemann" <[email protected]>,
	"Steven Rostedt" <[email protected]>,
	"Ben Segall" <[email protected]>, "Mel Gorman" <[email protected]>,
	"Valentin Schneider" <[email protected]>,
	"Jens Axboe" <[email protected]>,
	"Pavel Begunkov" <[email protected]>,
	"Andrew Morton" <[email protected]>,
	"Chen Yu" <[email protected]>,
	"Shuah Khan" <[email protected]>,
	"Mickaël Salaün" <[email protected]>,
	[email protected], [email protected],
	[email protected]
Subject: Re: [PATCH] exec: Make sure task->comm is always NUL-terminated
Date: Sat, 30 Nov 2024 13:33:05 -0800	[thread overview]
Message-ID: <CAHk-=wgSsP6w=wLeydMiZLjNwDaZrxyTx7MjFHo+BLXa+6YtVg@mail.gmail.com> (raw)
In-Reply-To: <202411301244.381F2B8D17@keescook>

On Sat, 30 Nov 2024 at 13:05, Kees Cook <[email protected]> wrote:
>
> Yeah, this just means it has greater potential to be garbled.

Garbled is fine. Id' just rather it be "consistently padded".

> This is fine, but it doesn't solve either an unstable source nor
> concurrent writers to dest.

Yeah, I guess concurrent writers will also cause possibly inconsistent padding.

Maybe we just don't care. As long as it's NUL-terminated, it's a
string. If somebody is messing with the kernel, they get to the
garbled string parts.

           Linus

  reply	other threads:[~2024-11-30 21:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-30  4:49 [PATCH] exec: Make sure task->comm is always NUL-terminated Kees Cook
2024-11-30  7:15 ` Linus Torvalds
2024-11-30 21:05   ` Kees Cook
2024-11-30 21:33     ` Linus Torvalds [this message]
2024-12-01 20:23   ` Linus Torvalds
2024-11-30 21:40 ` David Laight
2024-12-01 21:49 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wgSsP6w=wLeydMiZLjNwDaZrxyTx7MjFHo+BLXa+6YtVg@mail.gmail.com' \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox