From: Linus Torvalds <[email protected]>
To: Jens Axboe <[email protected]>
Cc: Martin Raiber <[email protected]>,
Pavel Begunkov <[email protected]>,
io-uring <[email protected]>
Subject: Re: Fixed buffers have out-dated content
Date: Sat, 16 Jan 2021 15:05:10 -0800 [thread overview]
Message-ID: <CAHk-=wh3Agdy3h+rsx5HTOWt6dS-jN9THBqNhk=mWG4KnCK0tw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
On Sat, Jan 16, 2021 at 2:12 PM Jens Axboe <[email protected]> wrote:
>
> Linus, I'm looking into the above report, all of it should still be
> intact in the quoted section. Figured it would not hurt to loop you in,
> in case this is a generic problem and since Martin identified that
> reverting the above changes on the mm side makes it go away. Maybe
> there's already some discussion elsewhere about it that I'm not privy
> to.
Ok, that commit clearly ended up more painful that it should have been.
The problem is that with it, if we revert it, then we'd have to also
revert a308c71bf1e6 ("mm/gup: Remove enfornced COW mechanism"). which
depends on it.
And that fixed its own set of problems.
Darn.
I'll go think about this.
Martin, since you can apparently trigger the problem easily, hopefully
you're willing to try a couple of patches?
Linus
next prev parent reply other threads:[~2021-01-16 23:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 23:39 Fixed buffer have out-dated content Martin Raiber
2021-01-09 16:23 ` Jens Axboe
2021-01-09 16:58 ` Martin Raiber
2021-01-09 20:32 ` Pavel Begunkov
2021-01-10 16:50 ` Martin Raiber
2021-01-14 21:50 ` Fixed buffers " Martin Raiber
2021-01-16 19:30 ` Pavel Begunkov
2021-01-16 19:39 ` Jens Axboe
2021-01-16 22:12 ` Jens Axboe
2021-01-16 23:05 ` Linus Torvalds [this message]
2021-01-16 23:34 ` Linus Torvalds
2021-01-17 20:07 ` Martin Raiber
2021-01-17 20:14 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wh3Agdy3h+rsx5HTOWt6dS-jN9THBqNhk=mWG4KnCK0tw@mail.gmail.com' \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox