From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14894C433DB for ; Sat, 20 Mar 2021 19:19:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D70F461941 for ; Sat, 20 Mar 2021 19:19:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229846AbhCTTSj (ORCPT ); Sat, 20 Mar 2021 15:18:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229840AbhCTTSg (ORCPT ); Sat, 20 Mar 2021 15:18:36 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24AC9C061762 for ; Sat, 20 Mar 2021 12:18:36 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id o126so5602204lfa.0 for ; Sat, 20 Mar 2021 12:18:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oVNqh986E52U93S+Xl3r6awL7z3dUtOFYc3bgu+oIXg=; b=ZwgK1qvl23/gFe170eG0WMX0xqWAH7nCJr3BD91hAZ2cSNe8zVq2W14ahSXrh3wD6d m2GedAPvKaiJp6gRXkow9DP84VvHm8t+f5F4GTXcZAD5QJtJWXRuAZNs5GHx+HTBX03M KFEeM4tShubhnQ1pVZoZSBp+1xU0QW15i1geU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oVNqh986E52U93S+Xl3r6awL7z3dUtOFYc3bgu+oIXg=; b=ZD1Si7yg0EaNb7mSv0M8cp73yqYAw+qa2FfYSP5lfWefuLWHH2qiGbsqo1TnBa1AmN w2sVB7I313NHSQDUxHzWtLbwD06bvWdEW3wgE+U8zM4mGVhEVoh/60qsvcmx1bVN7prT 1H7DHBvxoBJ8k5v35wGIidIK9QlrCc8pkMJp54YLOA6w3lQVTKt3NYU1RG472ZXfTVzV nWxehexcNBUXifZ+ltGy0OoTn7wc6toC3cTgLF7RCk6AE1dWWOTw6sRdQUPfkEwmflNw tgWhcKE9O7VHzHD3num8Y8cElFTtrjOfKE5b/MoMd5EtJs26jcF7hxPtoJhppS2Hktcp JWwA== X-Gm-Message-State: AOAM532usWhwxt9P503hdRCypt/u9jg5xF+Aq0shzjlACQLCBfLZ1n9Y 2gB8vK8m/qnAn+3ugKoS4ZfYLUXRREx4DA== X-Google-Smtp-Source: ABdhPJzaL1OoJYntAYhOin5Vr0KnpHRzG1xyo2JVdro9Vw9qa/wXKTUCS86Yn7KRSmAIuTlGRKaqTg== X-Received: by 2002:ac2:4f84:: with SMTP id z4mr4461656lfs.608.1616267913006; Sat, 20 Mar 2021 12:18:33 -0700 (PDT) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com. [209.85.167.42]) by smtp.gmail.com with ESMTPSA id m27sm1191250ljc.109.2021.03.20.12.18.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Mar 2021 12:18:32 -0700 (PDT) Received: by mail-lf1-f42.google.com with SMTP id w37so15081536lfu.13 for ; Sat, 20 Mar 2021 12:18:31 -0700 (PDT) X-Received: by 2002:a05:6512:3ba9:: with SMTP id g41mr4170310lfv.421.1616267911421; Sat, 20 Mar 2021 12:18:31 -0700 (PDT) MIME-Version: 1.0 References: <20210320153832.1033687-1-axboe@kernel.dk> In-Reply-To: From: Linus Torvalds Date: Sat, 20 Mar 2021 12:18:15 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHSET 0/2] PF_IO_WORKER signal tweaks To: "Eric W. Biederman" Cc: Jens Axboe , io-uring , Linux Kernel Mailing List , Oleg Nesterov Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Sat, Mar 20, 2021 at 10:51 AM Linus Torvalds wrote: > > Alternatively, make it not use > CLONE_SIGHAND|CLONE_THREAD at all, but that would make it > unnecessarily allocate its own signal state, so that's "cleaner" but > not great either. Thinking some more about that, it would be problematic for things like the resource counters too. They'd be much better shared. Not adding it to the thread list etc might be clever, but feels a bit too scary. So on the whole I think Jens' minor patches to just not have IO helper threads accept signals are probably the right thing to do. Linus