From: Linus Torvalds <torvalds@linux-foundation.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Jens Axboe <axboe@kernel.dk>,
Caleb Sander Mateos <csander@purestorage.com>,
io-uring <io-uring@vger.kernel.org>,
workflows@vger.kernel.org
Subject: Re: Link trailers revisited (was Re: [GIT PULL] io_uring fix for 6.17-rc5)
Date: Sat, 6 Sep 2025 08:31:59 -0700 [thread overview]
Message-ID: <CAHk-=wh8hvhtgg+DhyXeJSyZ=SrUYE85kAFRYiKBRp6u2YwvgA@mail.gmail.com> (raw)
In-Reply-To: <20250906-almond-tench-of-aurora-3431ee@lemur>
On Sat, 6 Sept 2025 at 06:51, Konstantin Ryabitsev
<konstantin@linuxfoundation.org> wrote:
>
> Unfortunately, `shazam -M` is not perfect, because we do need to know the
> base-commit, and there's still way too many series sent without this info.
No, no. You're thinking about it wrong.
An emailed patch series is *not* a git pull. If you want actual real
git history, just use git. Using a patch series and shazam for that
would be *bad*. It's actively worse than just using git, with zero
upside.
No, the upside of a patch series is that it's *not* fixed in stone yet
- not in history, not in acks, not in actual code. So do *not*
encourage people to think of it as some second-rate "git history"
model. It's not, and it would be *BAD* at it.
Instead, embrace the "it's a patch series". You should *not* strive to
make "b4 shazam" think it should recreate the original git tree. not
at all.
Instead, it should be a "here's a patch series with a cover letter,
make a pretty history of it, delineate it with a merge, and save the
relevant information from the cover letter in the merge message".
Look, we already have subsystems that do that. I don't know if they
use b4 shazam - maybe they do, maybe they don't - but the end result
is what matters.
For example, the networking people use this model for small series of
patches, and you can see it in patterns like this (I picked a random
area, this is meant to illustrate the point, the commits themselves
are not relevant):
gitk d2644cbc736f..f63e7c8a8389
and look at the kind of "pseudo-linear" history, where small series
are delineated with that separate branch and merge, but this is *not*
some kind of global history where people tried to keep original commit
bases around etc.
That kind of global history would be *worse* for the whole "send
patches by email" model.
So don't strive to replicate git - badly. Strive to do a *good* job.
Your comment about how you want to know the base commit makes me think
you are missing the point.
git is git.
And emailed patch series are a different thing entirely, and trying
for some 1:1 thing only makes things objectively worse.
Linus
next prev parent reply other threads:[~2025-09-06 15:32 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 11:18 [GIT PULL] io_uring fix for 6.17-rc5 Jens Axboe
2025-09-05 17:24 ` Linus Torvalds
2025-09-05 17:45 ` Konstantin Ryabitsev
2025-09-05 18:06 ` Linus Torvalds
2025-09-05 19:33 ` Link trailers revisited (was Re: [GIT PULL] io_uring fix for 6.17-rc5) Konstantin Ryabitsev
2025-09-05 20:09 ` Linus Torvalds
2025-09-05 20:47 ` Sasha Levin
2025-09-06 11:27 ` Greg KH
2025-09-06 11:27 ` Greg KH
2025-09-06 11:30 ` Greg KH
2025-09-06 13:51 ` Konstantin Ryabitsev
2025-09-06 15:31 ` Linus Torvalds [this message]
2025-09-06 18:50 ` Konstantin Ryabitsev
2025-09-06 19:19 ` Linus Torvalds
2025-09-08 9:11 ` Jani Nikula
2025-09-08 11:59 ` Mark Brown
2025-09-08 20:11 ` dan.j.williams
2025-09-09 11:29 ` Mark Brown
2025-09-09 13:17 ` Rafael J. Wysocki
2025-09-09 14:18 ` Jakub Kicinski
2025-09-09 14:35 ` Jens Axboe
2025-09-09 14:42 ` Konstantin Ryabitsev
2025-09-09 14:48 ` Vlastimil Babka
2025-09-09 14:50 ` Jens Axboe
2025-09-09 15:30 ` Rafael J. Wysocki
2025-09-09 16:40 ` Linus Torvalds
2025-09-09 17:08 ` Mark Brown
2025-09-09 17:50 ` Linus Torvalds
2025-09-09 17:58 ` Linus Torvalds
2025-09-09 18:31 ` Konstantin Ryabitsev
2025-09-09 19:36 ` dan.j.williams
2025-09-10 1:12 ` dan.j.williams
2025-09-10 12:19 ` Mark Brown
2025-09-09 17:25 ` dan.j.williams
2025-09-09 17:56 ` Alexei Starovoitov
2025-09-09 18:01 ` Linus Torvalds
2025-09-09 18:13 ` Alexei Starovoitov
2025-09-09 18:06 ` Vlastimil Babka
2025-09-09 18:14 ` Linus Torvalds
2025-09-09 18:22 ` Vlastimil Babka
2025-09-09 21:05 ` Mark Brown
2025-09-10 1:33 ` Konstantin Ryabitsev
2025-09-09 14:44 ` Greg KH
2025-09-09 15:14 ` Danilo Krummrich
2025-09-09 16:32 ` [RFC] b4 dig: Add AI-powered email relationship discovery command Sasha Levin
2025-09-09 17:22 ` Laurent Pinchart
2025-09-09 17:26 ` Jens Axboe
2025-09-09 18:54 ` Sasha Levin
2025-09-10 10:13 ` Laurent Pinchart
2025-09-10 10:55 ` Sasha Levin
2025-09-10 11:29 ` Laurent Pinchart
2025-09-10 13:38 ` Konstantin Ryabitsev
2025-09-10 14:03 ` Andrew Dona-Couch
2025-09-11 14:48 ` Nicolas Frattaroli
2025-09-11 15:05 ` Sasha Levin
2025-09-11 19:13 ` Nicolas Frattaroli
2025-09-11 19:57 ` Sasha Levin
2025-09-15 11:26 ` Mark Brown
2025-09-15 11:48 ` Sasha Levin
2025-09-15 12:03 ` Mark Brown
2025-09-11 23:24 ` Konstantin Ryabitsev
2025-09-07 22:04 ` [GIT PULL] io_uring fix for 6.17-rc5 Jonathan Corbet
2025-09-05 19:04 ` Jens Axboe
2025-09-05 19:07 ` Jens Axboe
2025-09-05 19:13 ` Caleb Sander Mateos
2025-09-05 19:16 ` Jens Axboe
2025-09-05 19:15 ` Linus Torvalds
2025-09-05 19:23 ` Jens Axboe
2025-09-05 19:21 ` Linus Torvalds
2025-09-05 19:30 ` Jens Axboe
2025-09-05 20:54 ` Linus Torvalds
2025-09-06 0:01 ` Jens Axboe
2025-09-07 18:47 ` Jonathan Corbet
2025-09-08 22:15 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wh8hvhtgg+DhyXeJSyZ=SrUYE85kAFRYiKBRp6u2YwvgA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=gregkh@linuxfoundation.org \
--cc=io-uring@vger.kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox